mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lukasz Luba <lukasz.luba@arm.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: rjw@rjwysocki.net, ulf.hansson@linaro.org,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Thara Gopinath <thara.gopinath@linaro.org>,
	Lina Iyer <ilina@codeaurora.org>,
	Ram Chandrasekar <rkumbako@codeaurora.org>,
	Zhang Rui <rui.zhang@intel.com>,
	Palmer Dabbelt <palmerdabbelt@google.com>,
	Anup Patel <anup.patel@wdc.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Kajol Jain <kjain@linux.ibm.com>,
	Zqiang <qiang.zhang@windriver.com>,
	Daniel Jordan <daniel.m.jordan@oracle.com>,
	Mike Leach <mike.leach@linaro.org>,
	Atish Patra <atish.patra@wdc.com>,
	Andrew Jones <drjones@redhat.com>
Subject: Re: [PATCH v4 4/4] powercap/drivers/dtpm: Add CPU energy model based support
Date: Wed, 2 Dec 2020 17:09:38 +0000	[thread overview]
Message-ID: <54ca2ae1-a7c5-f587-c1e7-583b5e3113af@arm.com> (raw)
In-Reply-To: <20201201192801.27607-5-daniel.lezcano@linaro.org>



On 12/1/20 7:28 PM, Daniel Lezcano wrote:
> With the powercap dtpm controller, we are able to plug devices with
> power limitation features in the tree.
> 
> The following patch introduces the CPU power limitation based on the
> energy model and the performance states.
> 
> The power limitation is done at the performance domain level. If some
> CPUs are unplugged, the corresponding power will be subtracted from
> the performance domain total power.
> 
> It is up to the platform to initialize the dtpm tree and add the CPU.
> 
> Here is an example to create a simple tree with one root node called
> "pkg" and the CPU's performance domains.
> 
> static int dtpm_register_pkg(struct dtpm_descr *descr)
> {
> 	struct dtpm *pkg;
> 	int ret;
> 
> 	pkg = dtpm_alloc(NULL);
> 	if (!pkg)
> 		return -ENOMEM;
> 
> 	ret = dtpm_register(descr->name, pkg, descr->parent);
> 	if (ret)
> 		return ret;
> 
> 	return dtpm_register_cpu(pkg);
> }
> 
> static struct dtpm_descr descr = {
> 	.name = "pkg",
> 	.init = dtpm_register_pkg,
> };
> DTPM_DECLARE(descr);
> 
> Cc: Thara Gopinath <thara.gopinath@linaro.org>
> Cc: Lina Iyer <ilina@codeaurora.org>
> Cc: Ram Chandrasekar <rkumbako@codeaurora.org>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>


LGTM

Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Tested-by: Lukasz Luba <lukasz.luba@arm.com>

Regards,
Lukasz

      reply	other threads:[~2020-12-02 17:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-01 19:27 [PATCH V4 0/4] powercap/dtpm: Add the DTPM framework Daniel Lezcano
2020-12-01 19:27 ` [PATCH v4 1/4] units: Add Watt units Daniel Lezcano
2020-12-01 19:27 ` [PATCH v4 2/4] Documentation/powercap/dtpm: Add documentation for dtpm Daniel Lezcano
2020-12-02 13:33   ` Lukasz Luba
2020-12-01 19:28 ` [PATCH v4 3/4] powercap/drivers/dtpm: Add API for dynamic thermal power management Daniel Lezcano
2020-12-02 12:37   ` Lukasz Luba
2020-12-02 17:19     ` Lukasz Luba
2020-12-01 19:28 ` [PATCH v4 4/4] powercap/drivers/dtpm: Add CPU energy model based support Daniel Lezcano
2020-12-02 17:09   ` Lukasz Luba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54ca2ae1-a7c5-f587-c1e7-583b5e3113af@arm.com \
    --to=lukasz.luba@arm.com \
    --cc=anup.patel@wdc.com \
    --cc=atish.patra@wdc.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=daniel.m.jordan@oracle.com \
    --cc=drjones@redhat.com \
    --cc=ilina@codeaurora.org \
    --cc=kjain@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mike.leach@linaro.org \
    --cc=mpe@ellerman.id.au \
    --cc=palmerdabbelt@google.com \
    --cc=qiang.zhang@windriver.com \
    --cc=rjw@rjwysocki.net \
    --cc=rkumbako@codeaurora.org \
    --cc=rui.zhang@intel.com \
    --cc=thara.gopinath@linaro.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®