From: Diogo Ivo <diogo.ivo@siemens.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Len Brown <lenb@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-watchdog@vger.kernel.org, jan.kiszka@siemens.com,
benedikt.niedermayr@siemens.com
Subject: Re: [PATCH v3 2/2] ACPI: PNP: Add Intel OC Watchdog IDs to non-PNP device list
Date: Wed, 26 Mar 2025 09:01:28 +0000 [thread overview]
Message-ID: <54d3c7a8-1392-4870-9bd6-48aebe3881f1@siemens.com> (raw)
In-Reply-To: <CAJZ5v0jh1jJy+YRMtLDnYqAhPrN2Pox+NY0Vqh_uqb7F=NwqEg@mail.gmail.com>
On 3/25/25 6:59 PM, Rafael J. Wysocki wrote:
> On Tue, Mar 25, 2025 at 6:19 PM Diogo Ivo <diogo.ivo@siemens.com> wrote:
>>
>> Hello,
>>
>> On 3/17/25 10:55 AM, Diogo Ivo wrote:
>>> Intel Over-Clocking Watchdogs are described in ACPI tables by both the
>>> generic PNP0C02 _CID and their ACPI _HID. The presence of the _CID then
>>> causes the PNP scan handler to attach to the watchdog, preventing the
>>> actual watchdog driver from binding. Address this by adding the ACPI
>>> _HIDs to the list of non-PNP devices, so that the PNP scan handler is
>>> bypassed.
>>>
>>> Note that these watchdogs can be described by multiple _HIDs for what
>>> seems to be identical hardware. This commit is not a complete list of
>>> all the possible watchdog ACPI _HIDs.
>>>
>>> Signed-off-by: Diogo Ivo <diogo.ivo@siemens.com>
>>> ---
>>> v2->v3:
>>> - Reword the commit message to clarify purpose of patch
>>> ---
>>> ---
>>> drivers/acpi/acpi_pnp.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/acpi/acpi_pnp.c b/drivers/acpi/acpi_pnp.c
>>> index 01abf26764b00c86f938dea2ed138424f041f880..3f5a1840f573303c71f5d579e32963a5b29d2587 100644
>>> --- a/drivers/acpi/acpi_pnp.c
>>> +++ b/drivers/acpi/acpi_pnp.c
>>> @@ -355,8 +355,10 @@ static bool acpi_pnp_match(const char *idstr, const struct acpi_device_id **matc
>>> * device represented by it.
>>> */
>>> static const struct acpi_device_id acpi_nonpnp_device_ids[] = {
>>> + {"INT3F0D"},
>>> {"INTC1080"},
>>> {"INTC1081"},
>>> + {"INTC1099"},
>>> {""},
>>> };
>>>
>>>
>>
>> Gentle ping on this patch.
>
> Do you want me to pick it up or do you want to route it through a
> different tree?
Unless the watchdog maintainers have any objections it's fine if you
pick it up.
Best regards,
Diogo
next prev parent reply other threads:[~2025-03-26 9:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 10:55 [PATCH v3 0/2] Add driver for Intel Over-Clocking Watchdog Diogo Ivo
2025-03-17 10:55 ` [PATCH v3 1/2] watchdog: Add driver for Intel OC WDT Diogo Ivo
2025-03-27 13:56 ` Markus Elfring
2025-04-08 8:31 ` Diogo Ivo
2025-05-08 15:12 ` Diogo Ivo
2025-03-17 10:55 ` [PATCH v3 2/2] ACPI: PNP: Add Intel OC Watchdog IDs to non-PNP device list Diogo Ivo
2025-03-25 17:18 ` Diogo Ivo
2025-03-25 18:59 ` Rafael J. Wysocki
2025-03-26 9:01 ` Diogo Ivo [this message]
2025-03-26 14:02 ` Guenter Roeck
2025-03-27 19:36 ` Rafael J. Wysocki
2025-06-01 20:15 ` [PATCH v3 0/2] Add driver for Intel Over-Clocking Watchdog Andy Shevchenko
2025-06-03 9:43 ` Diogo Ivo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54d3c7a8-1392-4870-9bd6-48aebe3881f1@siemens.com \
--to=diogo.ivo@siemens.com \
--cc=benedikt.niedermayr@siemens.com \
--cc=jan.kiszka@siemens.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rafael@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®