RE: [PATCH 1/2] dt-bindings: media: add ITE IT6625/IT6626 HDMI bridge binding

[<Hermes.Wu@ite.com.tw>]

Hi Sakari

>-----Original Message-----
>From: Sakari Ailus <sakari.ailus@iki.fi> 
>Sent: Wednesday, September 16, 2026 4:56 PM
>To: Hermes Wu (吳佳宏) <Hermes.Wu@ite.com.tw>
>Cc: Mauro Carvalho Chehab <mchehab@kernel.org>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; linux-media@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
>Subject: Re: [PATCH 1/2] dt-bindings: media: add ITE IT6625/IT6626 HDMI bridge binding
>
>Hi Hermes,
>
>Thanks for the set. I know the set has been merged already so could you address the issues in follow-up patches, please?

I will do. Thanks for the review.

>On Mon, Jul 20, 2026 at 03:57:45PM +0800, Hermes Wu via B4 Relay wrote:
>> From: Hermes Wu <Hermes.wu@ite.com.tw>
>> 
>> Document the devicetree binding for the ITE IT6625/IT6626 HDMI to MIPI 
>> CSI-2 bridge. The device exposes three graph ports: port@0
>> (MIPI0) and port@1 (MIPI1) are the two selectable CSI-2 D-PHY/C-PHY 
>> outputs, and port@2 is the HDMI connector input. Only port@0 is 
>> required, since a board only needs to wire up as many of the bridge's 
>> outputs as it actually uses.
>> 
>> Signed-off-by: Hermes Wu <Hermes.wu@ite.com.tw>
>> ---
>>  .../devicetree/bindings/media/i2c/ite,it6625.yaml  | 136 
>> +++++++++++++++++++++
>>  1 file changed, 136 insertions(+)
>> 
>> diff --git 
>> a/Documentation/devicetree/bindings/media/i2c/ite,it6625.yaml 
>> b/Documentation/devicetree/bindings/media/i2c/ite,it6625.yaml
>> new file mode 100644
>> index 
>> 0000000000000000000000000000000000000000..102af5dcb380b0ad2462c376e5a8
>> 7b22d7296f14
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/i2c/ite,it6625.yaml
>> @@ -0,0 +1,136 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/media/i2c/ite,it6625.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: ITE IT6625/IT6626 HDMI to dual MIPI CSI-2 bridge
>> +
>> +maintainers:
>> +  - Hermes Wu <Hermes.wu@ite.com.tw>
>> +
>> +description: |-
>> +  The ITE IT6625 and IT6626 are HDMI to MIPI CSI-2 bridge devices.
>> +  IT6625 supports an HDMI 2.0 input and converts it to one or two 
>> +D-PHY CSI
>> +  outputs, while IT6626 supports an HDMI 2.1 input and converts it to 
>> +one or
>> +  two C/D-PHY CSI outputs. The bridges are programmable through I2C 
>> +and
>> +  expose one HDMI input port and two selectable CSI-2 output ports. 
>> +The
>> +  bridge can operate in split mode or clone mode.
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - ite,it6625
>> +      - ite,it6626
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  reset-gpios:
>> +    description:
>> +      GPIO connected to the active-low reset line.
>> +    maxItems: 1
>> +
>> +  ports:
>> +    $ref: /schemas/graph.yaml#/properties/ports
>> +    properties:
>> +      port@0:
>> +        $ref: /schemas/graph.yaml#/$defs/port-base
>> +        unevaluatedProperties: false
>> +        description: CSI-2 output port MIPI0
>> +
>> +        properties:
>> +          endpoint:
>> +            $ref: /schemas/media/video-interfaces.yaml#
>> +            unevaluatedProperties: false
>> +
>> +            properties:
>> +              data-lanes:
>> +                minItems: 1
>> +                maxItems: 4
>> +
>> +              bus-type:
>> +                enum:
>> +                  - 1 # MEDIA_BUS_TYPE_CSI2_CPHY
>> +                  - 4 # MEDIA_BUS_TYPE_CSI2_DPHY
>
>If bus-type isn't required, a default need to be specified.
>
>> +
>> +              clock-noncontinuous: true
>> +              link-frequencies: true
>> +
>> +            required:
>> +              - data-lanes
>> +
>> +      port@1:
>> +        $ref: /schemas/graph.yaml#/$defs/port-base
>> +        unevaluatedProperties: false
>> +        description: CSI-2 output port MIPI1
>> +
>> +        properties:
>> +          endpoint:
>> +            $ref: /schemas/media/video-interfaces.yaml#
>> +            unevaluatedProperties: false
>> +
>> +            properties:
>> +              data-lanes:
>> +                minItems: 1
>> +                maxItems: 4
>> +
>> +              bus-type:
>> +                enum:
>> +                  - 1 # MEDIA_BUS_TYPE_CSI2_CPHY
>> +                  - 4 # MEDIA_BUS_TYPE_CSI2_DPHY
>
>Ditto.
>
>> +
>> +              clock-noncontinuous: true
>> +              link-frequencies: true
>> +
>> +            required:
>> +              - data-lanes
>> +
>> +      port@2:
>> +        $ref: /schemas/graph.yaml#/$defs/port-base
>> +        unevaluatedProperties: false
>> +        description: HDMI connector input port
>> +
>> +        properties:
>> +          endpoint:
>> +            $ref: /schemas/graph.yaml#/$defs/endpoint-base
>> +            unevaluatedProperties: false
>> +
>> +    required:
>> +      - port@0
>> +required:
>> +  - compatible
>> +  - reg
>> +  - ports
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/gpio/gpio.h>
>> +
>> +    i2c {
>> +      #address-cells = <1>;
>> +      #size-cells = <0>;
>> +
>> +      hdmi-bridge@4c {
>> +        compatible = "ite,it6625";
>> +        reg = <0x4c>;
>> +
>> +        reset-gpios = <&gpio 2 GPIO_ACTIVE_LOW>;
>> +
>> +        ports {
>> +          #address-cells = <1>;
>> +          #size-cells = <0>;
>> +
>> +          port@0 {
>> +            reg = <0>;
>> +            csi_out0: endpoint {
>> +              remote-endpoint = <&csi2_rx0>;
>> +              bus-type = <4>; /* MEDIA_BUS_TYPE_CSI2_DPHY */
>> +              data-lanes = <1 2 3 4>;
>> +            };
>> +          };
>> +        };
>> +      };
>> +    };
>> 
>
>--
>Regards,
>
>Sakari Ailus
>