From: Marc Zyngier <maz@kernel.org>
To: Lina Iyer <ilina@codeaurora.org>
Cc: <swboyd@chromium.org>, <linus.walleij@linaro.org>,
<bjorn.andersson@linaro.org>, <evgreen@chromium.org>,
<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<mkshah@codeaurora.org>, <linux-gpio@vger.kernel.org>,
<agross@kernel.org>, <dianders@chromium.org>
Subject: Re: [PATCH 00/12] Support wakeup capable GPIOs
Date: Fri, 15 Nov 2019 10:08:03 +0000 [thread overview]
Message-ID: <54da99976d9bd2d543d2341ad9eb982e@www.loen.fr> (raw)
In-Reply-To: <1573756521-27373-1-git-send-email-ilina@codeaurora.org>
Hi Lina,
On 2019-11-14 18:35, Lina Iyer wrote:
> Hi all,
>
> Thanks for all the reviews.
>
> Here is the next spin of the wakeup capable GPIO support. In order to
> facilitate basic support available in the kernel, I have dropped the
> SPI
> register configuration. The feature was added when this series was
> restarted based on new hierarchy support in gpiolib. But, the SPI
> configuration can be done in the firmware. This would avoid a whole
> lot
> of code in linux that serve little to no purpose. Users of GPIO never
> have the need to change the trigger type (level edge and vice-versa)
> and
> the basic configuration can be set in the firmware before boot.
>
> Changes in v1:
> - Address review comments
> - Add Reviewed-by tags
> - Drop SPI config patches
> - Rebase on top of Rajendra's PDC changes [6]
>
> Changes in RFC v2[5]:
> - Address review comments #3, #4, #6, #7, #8, #9, #10
> - Rebased on top of linux-next GPIO latest patches
> [1],[3],[4]
> - Increase PDC max irqs in #2 (avoid merge conflicts with
> downstream)
> - Add Reviewed-by #5
>
> Please consider reviewing these patches.
It has been a long time coming, and I'm minded to take the first 9
patches into the irqchip tree. Anyone objects? The last 3 patches
can go via the platform maintainer tree.
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2019-11-15 10:08 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 18:35 Lina Iyer
2019-11-14 18:35 ` [PATCH 01/12] irqdomain: add bus token DOMAIN_BUS_WAKEUP Lina Iyer
2019-11-15 18:48 ` Stephen Boyd
2019-11-14 18:35 ` [PATCH 02/12] drivers: irqchip: qcom-pdc: update max PDC interrupts Lina Iyer
2019-11-15 18:48 ` Stephen Boyd
2019-11-14 18:35 ` [PATCH 03/12] drivers: irqchip: pdc: Do not toggle IRQ_ENABLE during mask/unmask Lina Iyer
2019-11-15 18:49 ` Stephen Boyd
2019-11-14 18:35 ` [PATCH 04/12] drivers: irqchip: add PDC irqdomain for wakeup capable GPIOs Lina Iyer
2019-11-15 19:03 ` Stephen Boyd
2019-11-14 18:35 ` [PATCH 05/12] of: irq: document properties for wakeup interrupt parent Lina Iyer
2019-11-15 19:03 ` Stephen Boyd
2019-11-14 18:35 ` [PATCH 06/12] genirq: Introduce irq_chip_get/set_parent_state calls Lina Iyer
2019-11-15 19:04 ` Stephen Boyd
2019-11-14 18:35 ` [PATCH 07/12] drivers: irqchip: pdc: Add irqchip set/get state calls Lina Iyer
2019-11-15 19:05 ` Stephen Boyd
2019-11-14 18:35 ` [PATCH 08/12] drivers: pinctrl: msm: setup GPIO chip in hierarchy Lina Iyer
2019-11-14 18:43 ` Linus Walleij
2019-11-14 18:57 ` Lina Iyer
2019-11-15 19:33 ` Stephen Boyd
2019-11-15 20:55 ` Lina Iyer
2019-11-15 21:57 ` Lina Iyer
2019-11-15 22:09 ` Stephen Boyd
2019-11-15 22:13 ` Lina Iyer
2019-11-14 18:35 ` [PATCH 09/12] drivers: pinctrl: sdm845: add PDC wakeup interrupt map for GPIOs Lina Iyer
2019-11-15 19:33 ` Stephen Boyd
2019-11-14 18:35 ` [PATCH 10/12] arm64: dts: qcom: add PDC interrupt controller for SDM845 Lina Iyer
2019-11-15 19:34 ` Stephen Boyd
2019-11-14 18:35 ` [PATCH 11/12] arm64: dts: qcom: setup PDC as the wakeup parent for TLMM on SDM845 Lina Iyer
2019-11-15 19:34 ` Stephen Boyd
2019-11-14 18:35 ` [PATCH 12/12] arm64: defconfig: enable PDC interrupt controller for Qualcomm SDM845 Lina Iyer
2019-11-15 19:34 ` Stephen Boyd
2019-11-15 10:08 ` Marc Zyngier [this message]
2019-11-15 16:20 ` [PATCH 00/12] Support wakeup capable GPIOs Lina Iyer
2019-11-15 19:35 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54da99976d9bd2d543d2341ad9eb982e@www.loen.fr \
--to=maz@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=ilina@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkshah@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®