From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 691813CFF73 for ; Thu, 6 Aug 2026 11:22:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786015349; cv=none; b=qNpXBh9i5gDYHX4LPDkpJOHG17Y4cLRcn+EIEokJgyhWA17BgKKd0SfS3TlRJ6QcrxzFmhoueKdkHkUZ0b2djcXR3hJc6FtthVwdDJqhkDxDXwMFQOk1kwj1OkWx7Ko7lCG7ciekg1oHWPkIr70rnPxt3zV4j4PqEINidNpRgs4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786015349; c=relaxed/simple; bh=EmoTjcFKKWkEpYz+sN13qHspYotNdUDpMAOcLy9NsfY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fyFnfNt+LLXmT2LOZHzUBp3JZOqKUSM73HuL9UeztKwFxzE0P71lV3x0MomxWpmbbF9zqUBU/yQiW1IRQXVKq1XUUxMHgWaI9xez6DfxPxtoyv00a/xiSN59eaueZXrWUuTYdu/XN/ak255RUpBdhyzjowwpoi7/McGbCAQDXAA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZLYUTQ4/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AoXEW0OW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZLYUTQ4/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AoXEW0OW" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6769nev01277819 for ; Thu, 6 Aug 2026 11:22:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= el4JFaFHcBqvnx7H70Vfy2ndmqSRpKtLmn/ho+OvcDE=; b=ZLYUTQ4/21InzYzI Kqp2HdEQDJI59EkODPj5yoYaPCytkZaTGg747L2v7FZI7XEZShC/UbIPX6C6sc/+ 7KnfRvysOxR0ZhYG1AgaDgdCJlzXTj8OucxRlemLumQ6sWDez0YRHYZUqTU/IMRW e6r2ZfLt9WjdO3sERIAxcUu05iWO/RxzBQ/meD21Tb3ihhwwvbbpdXhbMdyzCn8M S/Nnunmhi2rZ6duabmVmX7rjs8KSz4rQ5ddSWNvbvnHZisGp5AKZUdfevoJPa/PT atz4oYnoUKbDKa0iZ0e9n2ZNReDHE7HD06vxcfcYn4LClx/3WK5ayu1olUtAzMIr 1jivTQ== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fvjuehu10-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 06 Aug 2026 11:22:27 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-38e54b6556aso2385869a91.2 for ; Thu, 06 Aug 2026 04:22:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786015347; x=1786620147; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=el4JFaFHcBqvnx7H70Vfy2ndmqSRpKtLmn/ho+OvcDE=; b=AoXEW0OWu6Zq4/kjZJCqw1Zd5p5UC8RlrTpNK+I7aAQfOCLqo4ZGAFQVo7bzLp7Ipt 9KdF0lHrl14EVP6ClDrbh5wZ8sgcAfgfYXy8Ow/q+u6DkFDECZP2UT9w/A9Pn/KbLloX XrtP1nUKexgMa9lXZZhhgiWMh4YJgXZpxRtV8PXNzMk1ucSaEbvUlKiI8/HAPToDyfef o6IpdJ4uiG1xgu4d+XEV6Xk6U1zXLRMc465oPKx2xaF7qtBD76zBR2XBkPWD9EdUF1JA oTk2zR0ZBMsf4sNO/UujeYmSCpRPNjh7ak+EJJXC/ViMLu1S5TwFiPk5cK5D0MKC9b05 AQYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786015347; x=1786620147; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=el4JFaFHcBqvnx7H70Vfy2ndmqSRpKtLmn/ho+OvcDE=; b=hsH4n5MQWBZW6Xm2v5wViX6Azux7npSD7lCeRc1HYfY39hHyaCXyXRbg+eKmC6GZKL 8NrNzFZRm7XJTaAHqT7Im7X3NYk41iCrPDXPSdlPgJXL8VBdmi8GkI36W50K1RD+TM0z e5az9oKMEizO2Gb84LO5MEwTWer5XY4B/yHP3b8ejUZBFmb1ot9C/YMSKlCyCnhQU5oB 5+WuQcvn+O6zv6XvJs699IiIAkQbxHpK4sJ3c4ZNP4ykHqruS6rqiy0CGE6kj5NhroU/ VWSoh+fE7kMPgnBHynn7pv5kf2zOJP+IUGQgvj2m4T25MmEOBtzO2vbObojkxY+iE8xu i74Q== X-Gm-Message-State: AOJu0YxggD5wCjqkFmwzGuNB50g+EQpIwUkbJ/EL/ElTrWQR1nppIHOV I+nrp48qErKcEjycwNo0uRI53GOhL9q9XjLAzogI+qATM/H0KBYL2B6NFmU1dzMMQpc/XIvulIA ACH1AUPjE0ZqwC0zUjnk5qyq+g5ewsgn1tk6EE8p4jBfMgzwnJ8pnSlWeqkOpEZ/Itqk= X-Gm-Gg: AR+sD100+MTK0NXXloakN/oX8fDfad3wiPV+NBtonUim4hEd8w29gfVt3V9uFPok70M qxTeCEeWl4DO628AfF3Eep+x5IHrWCxlaYtcmqjbCxrtMnqyizSNgEasn1YYdOCQ6EhE28hU9qs G0r7bhJk2W4b7p9MAL4P6yNmasHQARGCyJhd5uEv6wZ1gtG0NyA4iQo/S3B+IlUH/UYpf6cQIEE s3ibIhwQ8ePierq/7/hprRp03NVo5zySCw9GfEdVskLzPGbklsYAIRhkH48K9ITwLog3l7zXRfa nhgSTtdYxyKjMBruXdp288tz5xmjeIdjRp8F2nQ3nHQlor5QdtNIlOfj3sLLX4y54MqpnT3Szle XqMqEWq/vEU0z8DuolTKOYykzOiJTKhn537wcGz1BWw9bPWfMNyqxAFd0eHf0BvC75uVdkWxd X-Received: by 2002:a17:90b:1c84:b0:38f:5828:857e with SMTP id 98e67ed59e1d1-3903c5b4c5emr11406185a91.16.1786015346847; Thu, 06 Aug 2026 04:22:26 -0700 (PDT) X-Received: by 2002:a17:90b:1c84:b0:38f:5828:857e with SMTP id 98e67ed59e1d1-3903c5b4c5emr11406139a91.16.1786015346367; Thu, 06 Aug 2026 04:22:26 -0700 (PDT) Received: from [10.133.33.203] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39085f5b98csm1343904a91.13.2026.08.06.04.22.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2026 04:22:25 -0700 (PDT) Message-ID: <54e74486-12f2-4b09-916a-1a8806871b6c@oss.qualcomm.com> Date: Thu, 6 Aug 2026 19:22:20 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] cpufreq: allow cpuinfo max to decrease when boost is disabled To: Sibi Sankar , rafael@kernel.org, viresh.kumar@linaro.org, mingo@redhat.com, peterz@infradead.org, linux-arm-msm@vger.kernel.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com Cc: linux-kernel@vger.kernel.org, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, kprateek.nayak@amd.com, linux-pm@vger.kernel.org, zhongqiu.han@oss.qualcomm.com References: <20260806044230.909961-1-sibi.sankar@oss.qualcomm.com> <20260806044230.909961-2-sibi.sankar@oss.qualcomm.com> Content-Language: en-US From: Zhongqiu Han In-Reply-To: <20260806044230.909961-2-sibi.sankar@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=aNzAb79m c=1 sm=1 tr=0 ts=6a746e73 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=BelGTQZ_NpiV2tDX9rUA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-GUID: EkunLXELbW2atm_eA9ilCmyK79JxHoA9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA2MDA4OSBTYWx0ZWRfX8LPvF0vLkSP+ pSp9ErRiAOGk2hoNvPTF2bpWoVWmJtOFpLAj3y2EpvRa7WsLF8jsrwQB/Cfx4d5mPY9SRAiyrca rw0NUO5gQEfK0iHTCDlE7YApNyAEihax7Bg48HBIQ0tDKCCEqcDbITcwCOHN/qJPdIrhuRZdCPO L9vXa4c2uD8cOly4BtJSE7KR62j3YYL5caym2J9ZUSiXEMuB5P8jkyyUkPYyWumYdy+U4A1pgqO gSCRNj+0FngFNSUdOQSdIs1GR0vdsFS8myztmVOsx928HgCqkv37tZxUodM+mvcRYMHwWZlqlxa lCHWHM6PTtgw/eion4nnqp/3XgugkJE21Z8CXrxudaxSZ6FHjiuXQNY7+xcTJS6gNvVj5EadqeR UCWQd+6g1ZAwnrD8mo7cp0o2H08s/0XbD93lPvs5DoTcOFTP2a7NrZ711VTQPPAQivU4kIJiG1R Q/bTD7GrqDoG7Ci733g== X-Proofpoint-ORIG-GUID: EkunLXELbW2atm_eA9ilCmyK79JxHoA9 X-Proofpoint-Spam-Info: AW1haW4tMjYwODA2MDA4OSBTYWx0ZWRfX1h23YHL1tePb wuiXN016E2j+A4PvfRPVq45n0FHWl1YRri/45T5bryfhAbaLfN3+HxC1qHCOdDqsw7TPs9XTUdu CRWfbssxRpBLyaTE6/nKCvRv0OwIuLE= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-05_06,2026-08-05_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 suspectscore=0 adultscore=0 clxscore=1015 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608060089 Hi Sibi and Ananthu, On 8/6/2026 12:42 PM, Sibi Sankar wrote: > From: Ananthu C V > > Commit 538b0188da46 ("cpufreq: ACPI: Set cpuinfo.max_freq directly > if max boost is known") guarded cpuinfo max updates to only allow > increases, preserving values set directly by drivers above the freq > table maximum. This prevents cpuinfo max from decreasing on boost > disable, leaving policy max pinned at the boost ceiling. > > Remove the guard so cpuinfo max is always derived from the frequency > table scan. Drivers that correctly flag boost entries are unaffected > since the scan already excludes them when boost is off. > > Fixes: 538b0188da46 ("cpufreq: ACPI: Set cpuinfo.max_freq directly if max boost is known") > Signed-off-by: Ananthu C V > Signed-off-by: Sibi Sankar > --- > drivers/cpufreq/freq_table.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/cpufreq/freq_table.c b/drivers/cpufreq/freq_table.c > index ea994647abc8..791118466ca4 100644 > --- a/drivers/cpufreq/freq_table.c > +++ b/drivers/cpufreq/freq_table.c > @@ -50,12 +50,7 @@ int cpufreq_frequency_table_cpuinfo(struct cpufreq_policy *policy) > } > > policy->cpuinfo.min_freq = min_freq; > - /* > - * If the driver has set its own cpuinfo.max_freq above max_freq, leave > - * it as is. > - */ > - if (policy->cpuinfo.max_freq < max_freq) > - policy->cpuinfo.max_freq = max_freq; As I understand it, the guard added by commit 538b0188da46 is intended for drivers (e.g. acpi-cpufreq and AMD) that may set cpuinfo.max_freq above the maximum frequency in the frequency table. Removing it may cause those drivers to lose their boost maximum frequency. The regression should instead be related to commit db80ad776cd2 ("cpufreq: Remove driver default policy->min/max init"), which removed the "policy->max = max_freq" initialization that previously allowed policy->max to track the result of the boost-aware frequency scan. Please feel free to let me know what you think. Thanks > + policy->cpuinfo.max_freq = max_freq; > > if (min_freq == ~0) > return -EINVAL; -- Thx and BRs, Zhongqiu Han