From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 312393A9DAE for ; Thu, 9 Jul 2026 06:04:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783577093; cv=none; b=FpP839lC6urDuClaiPq8fbEOFGtNx99CXBKhpZwxrb/KVBx4aYp45QwHgSUhbAXxBF76XLm0XMLYBYSGlO4kVBewuDMhfHCQA+PUGCrsz3hQI9fGBeOjhJWIHn6tSEfeRT08IwAsXnhRJ/u4Jk4CeFEzDmZzlCPhXOb6jMRrjPA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783577093; c=relaxed/simple; bh=WNJuEus8ck16SJoGo/esVS4JXj9YzA1nQDebh6BcIBg=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=B+Gz9BeuBvrJLXOAE/7xXMnMSAKZIbstvjFOjeUSpxIoKzymU8ydypDHwpBH4PCCyuIuXrtczQWNQVvRxvwas3JgOHEtW/HnoNVyca9Lz6xJPtVn6c3LRzVf97277Kky8hplBNUk6QIjCm+oK+VTSlhk15nPkShS8M+S4EzrdGA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Np2snA1/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XoGNZY6T; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Np2snA1/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XoGNZY6T" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6695xxOB710968 for ; Thu, 9 Jul 2026 06:04:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +YIXIY/4ZJpVgegUJNfS3ZfbS4I1oxhM8KfIDXfCtY0=; b=Np2snA1/9/isQ181 qiD3dLF7ej+WpyHZceM06jh0OpZP5rH+j29q6qQocW61/eoYLQCtTIDMmgWUT0S1 9AEl6pDxX9JAftxZMZWA4GA5m4pjdiCo5guvIXaeJ3EWSbqoyVrk6xeaXgTkuLXi MXLyn2BrnYPhr8Ankiedj7Zg4S4BEO3eSNRwn7hW4VxnFMDLZk5HGU2dPEg3MAXs /d60uiqlkVNvWQCqtvYNYWsopZ371RiSji5JtnFoyDhD03fzuzq6UQp2Qne94pA1 daElkmvwRrlcl12KGFvnYN8xQWFSvKx8X/mJwzjBIJ3J2l7stiZaGJvvjP1yKRun aW3Plg== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fa55vg6sx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 09 Jul 2026 06:04:50 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-38101e6fc6cso2645114a91.0 for ; Wed, 08 Jul 2026 23:04:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783577090; x=1784181890; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=+YIXIY/4ZJpVgegUJNfS3ZfbS4I1oxhM8KfIDXfCtY0=; b=XoGNZY6Tro80OL44tgW2tLlJ+pwLQAAZGQxlAkEAQH2GxYgLb1zwm3h5I//TGYHUMq QOy5zWTzvReZpRs04iceFcPiRZPaMyl9I/41O+A786LbIKhHWi+8L0RuIbrNKR5gKXIK 7J256lzRpEk8sdRVWtv0rb8V/Rf96d+jZAbqilk30qer9GXt6MfjijGnHGPrXJqVBFUQ Oq6UFXucufOwiswi5VqbMVIzd0Lv1K+sWUJ3n0BCndQA6CbPu78g4IlGufLxTUt+VnyZ ojMUcItpGBCUxmP0sdB/cWoczuSWppJFMVLZYVXP+U7LeKQyq15Tuj4aS7CJmc3x7tge gIjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783577090; x=1784181890; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+YIXIY/4ZJpVgegUJNfS3ZfbS4I1oxhM8KfIDXfCtY0=; b=tBcr0wKw3vHRK5YOSHMMrRfhZXWfjbSKAGQEzK6/oreggUZRYKH8hOK/ABFcg+Kx8V FnwiMmdGzZKgRWmIwzKLVp3mKH+nr8jY8CxXYatjrxj+WnyvjPN5NQYhBYXFWXgsGaOn QWVRc7oBdfr6fajEjOvlLgAkULYBedQERiPJyY2pZBU2zX9EOjMBcEf4su3EUbK5Fz7M nSem+0k++ewFBtkO+2EEVH1fBxfHY5qIMcv43CxvGAFnPBqcX1iQoosn+lAZsBX83IvD Ik+/spBaJ4FKQpFqpUla0AVMLXDkajVNnF7z21uqVVAw19RMEMxXZ221v2ZX+VtkGp7i fYeQ== X-Forwarded-Encrypted: i=1; AHgh+Rr20ZxC5BqkmAGYBopfZ6i5WVD4B7cHYh/gq7hed63L8Ie2+oXW7YWEEMbi2ylYR+g1KDd4Z14gLxBSChY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8383Nkdh4sIj33NWGlQH8dxn18aJju7H65gQ1exD66BdMSPLM rP7SvD8HKQc8p2L8PjdyOiU+k46izajHzKPrQs4tdYajr0IrhuGk9nCxI9/EpxlMPs5omvVidow SnHjpi6bi2nG1GV4JhQxeznB3n2pQh2KU38jXpo+r7ND0oTE9o8jkKe1Ito3wUG97PUQ= X-Gm-Gg: AfdE7cmX6Y8PXLhP9ZiVM9Kc8AYvjSJGuNE+ba6EGI43Aiz/Wgai8fRN1kAT9zMRosX SR16pL/wtcjpA74L+KdjRkoRH01sD4g9jx1Fms0HNxN6n4hn61rsof/57tUYIB4yb7J7Vq3zqLE 3lTXnVsDv0+ceDqbVFVr5QvbgzP2SHTBKM+gHMP8ZJ5xaLmodmQ3tKzxnPYIfB/L/AdwUJ44xUZ AHeGnl6sGWdD2B71PYFcAHtKItITt4k+PnJjTsEnebLwqJLcNDCXDlxtmKuvhN49zzQ2iPF9kBC rAgDrjnQ1TEiaABzvouumuzJyQPuclkjWRD01BMrnBvHy01UOZVdCLyqN6NX3B1KtV0DCWI0Iaj uk+QSVhmH2SPZVFSaxpKHScy0xubokZ1GISzl2L/S+YJn X-Received: by 2002:a17:90b:2742:b0:37f:133a:3e02 with SMTP id 98e67ed59e1d1-3893d62c905mr5984414a91.0.1783577089769; Wed, 08 Jul 2026 23:04:49 -0700 (PDT) X-Received: by 2002:a17:90b:2742:b0:37f:133a:3e02 with SMTP id 98e67ed59e1d1-3893d62c905mr5984383a91.0.1783577089287; Wed, 08 Jul 2026 23:04:49 -0700 (PDT) Received: from [10.217.219.87] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38a5632235bsm558996a91.15.2026.07.08.23.04.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jul 2026 23:04:48 -0700 (PDT) Message-ID: <54e814c8-c2b7-4414-aeba-469973a30b42@oss.qualcomm.com> Date: Thu, 9 Jul 2026 11:34:44 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] i2c: designware: amdisp: balance genpd on probe failure To: Guangshuo Li , Mika Westerberg , Andy Shevchenko , Nirujogi Pratap , Bin Du , Andi Shyti , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260708090552.739789-1-lgs201920130244@gmail.com> Content-Language: en-US From: Mukesh Savaliya In-Reply-To: <20260708090552.739789-1-lgs201920130244@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA5MDA1NCBTYWx0ZWRfXyjL64IkSMyzf O5Qr0RENkvBFn/Q5TtAZuGnsoYtC0zmc456BJVVKWEJM/nNJmdxgY0N/7xu+OwQr1vfApWqdXN0 +H4r/otTcERvPrKtvkztCM+G370Zt/JGegOldhC1mqVRlMzM37RdNGG/8JkoS3IPfIQ4h2Z4bhj viLX0GwEBorrR+pdIag7zDc5WC4tj+2wKlwtnrgZ1SMjLsXCpFMnIN2YlhwF09n7HOS8vAkD8Ny LNpM6nZP3M7XJ0ksMvZA5gYjbwnP3uFIwUTSbsyPeJtNSS48RmVj9YCb7pFlrFU7BbmcrAeGquN 33DEiVltIyHhcDm9gsUySRnKBvjFNkPjHbZ/nXx44DEwlhJ4w8/Fr6B+NXReP5p/ucamQRiIMeB xn+doDzlZV3KQO6eUtfIhe4CQmqjbcLa1XY2UVzVn8D+KkwT29PXLf/bKgHcSgV1mkxCdBvHchb WTaJmu5QniIJ9F3moqw== X-Authority-Analysis: v=2.4 cv=KfDidwYD c=1 sm=1 tr=0 ts=6a4f3a02 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=-WDWT1t3AFrGqDG-RHsA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA5MDA1NCBTYWx0ZWRfX3go9UwQExKcp xKFZ+Yv1sLR+ZdHn6M0Ic/Qwf7GbEMvs+MIMXWStOi8vmGby3wi6QbdeKfieLBSh3YmtvRvJcL8 CtKwaimBLEXR2mgbhJcfEU70vVt8V4g= X-Proofpoint-ORIG-GUID: q28WO9-hv7JwzJUrCYTvZydWa_MM8Q1L X-Proofpoint-GUID: q28WO9-hv7JwzJUrCYTvZydWa_MM8Q1L X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-09_01,2026-07-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 malwarescore=0 adultscore=0 clxscore=1015 priorityscore=1501 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607090054 Looks fine to me, Have someone from AMD also Ack'ing this as requested by Andy Shevchenko. On 7/8/2026 2:35 PM, Guangshuo Li wrote: > The change referenced by the Fixes tag avoids a runtime PM resume during > probe by powering the ISP domain directly with dev_pm_genpd_resume() > before calling i2c_dw_probe(). Runtime PM is enabled only after > i2c_dw_probe() has succeeded. > > However, the i2c_dw_probe() failure path still uses the old runtime PM > cleanup path. At that point pm_runtime_enable() has not been called yet, > so pm_runtime_disable() is not paired with any enable. The failure path > also skips the dev_pm_genpd_suspend() needed to balance the direct > dev_pm_genpd_resume() call. > > Suspend the genpd on the i2c_dw_probe() failure path instead of disabling > runtime PM. This keeps the direct genpd resume/suspend pairing symmetric > on both success and failure paths. > > Fixes: e2f1ada8e089 ("i2c: designware: amdisp: Fix resume-probe race condition issue") > Signed-off-by: Guangshuo Li > --- > drivers/i2c/busses/i2c-designware-amdisp.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Acked-by: Mukesh Kumar Savaliya