From: Paolo Abeni <pabeni@redhat.com>
To: Siddharth Vadapalli <s-vadapalli@ti.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
linux@armlinux.org.uk, rogerq@kernel.org, leon@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, vigneshr@ti.com,
srk@ti.com
Subject: Re: [PATCH net-next v3 2/2] net: ethernet: ti: am65-cpsw/cpts: Fix CPTS release action
Date: Thu, 19 Jan 2023 14:06:26 +0100 [thread overview]
Message-ID: <54ebe3efac89c68db30658e82b1ba1a7355d4456.camel@redhat.com> (raw)
In-Reply-To: <20230118095439.114222-3-s-vadapalli@ti.com>
Hi,
On Wed, 2023-01-18 at 15:24 +0530, Siddharth Vadapalli wrote:
> @@ -1014,18 +1013,12 @@ struct am65_cpts *am65_cpts_create(struct device *dev, void __iomem *regs,
> }
> cpts->phc_index = ptp_clock_index(cpts->ptp_clock);
>
> - ret = devm_add_action_or_reset(dev, am65_cpts_release, cpts);
> - if (ret) {
> - dev_err(dev, "failed to add ptpclk reset action %d", ret);
> - return ERR_PTR(ret);
> - }
> -
> ret = devm_request_threaded_irq(dev, cpts->irq, NULL,
> am65_cpts_interrupt,
> IRQF_ONESHOT, dev_name(dev), cpts);
> if (ret < 0) {
> dev_err(cpts->dev, "error attaching irq %d\n", ret);
> - return ERR_PTR(ret);
> + goto reset_ptpclk;
> }
>
> dev_info(dev, "CPTS ver 0x%08x, freq:%u, add_val:%u\n",
This chunk does not apply cleanly to current net-next (context is
changed). Please rebase and re-spin (you can preserve/keep the already
acquire reviewed-by tags)
Thanks!
Paolo
next prev parent reply other threads:[~2023-01-19 13:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 9:54 [PATCH net-next v3 0/2] Fix CPTS release action in am65-cpts driver Siddharth Vadapalli
2023-01-18 9:54 ` [PATCH net-next v3 1/2] net: ethernet: ti: am65-cpsw: Delete unreachable error handling code Siddharth Vadapalli
2023-01-18 11:30 ` Leon Romanovsky
2023-01-18 9:54 ` [PATCH net-next v3 2/2] net: ethernet: ti: am65-cpsw/cpts: Fix CPTS release action Siddharth Vadapalli
2023-01-18 11:29 ` Leon Romanovsky
2023-01-19 13:06 ` Paolo Abeni [this message]
2023-01-20 4:42 ` [PATCH net-next v4 " Siddharth Vadapalli
2023-01-20 5:48 ` Jakub Kicinski
2023-01-20 5:52 ` Siddharth Vadapalli
2023-01-18 21:24 ` [PATCH net-next v3 0/2] Fix CPTS release action in am65-cpts driver Tony Nguyen
2023-01-19 10:27 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54ebe3efac89c68db30658e82b1ba1a7355d4456.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=rogerq@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®