From: "Michel Dänzer" <michel.daenzer@mailbox.org>
To: Hector Martin <marcan@marcan.st>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Javier Martinez Canillas <javierm@redhat.com>
Cc: stable@vger.kernel.org,
Pekka Paalanen <pekka.paalanen@collabora.com>,
asahi@lists.linux.dev, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/simpledrm: Only advertise formats that are supported
Date: Fri, 28 Oct 2022 11:18:51 +0200 [thread overview]
Message-ID: <54ee5dcb-d573-ade6-9132-8b165fbc875c@mailbox.org> (raw)
In-Reply-To: <cfe65da9-497d-b825-7332-874b6e87c087@marcan.st>
On 2022-10-27 12:53, Hector Martin wrote:
>
> Q: Why not just add a conversion from XRGB2101010 to XRGB8888?
> A: Because that would only fix KDE, and would make it slower vs. not
> advertising XRGB2101010 at all (double conversions, plus kernel
> conversion can be slower). Plus, it doesn't make any sense as it only
> fills in one entry in the conversion matrix. If we wanted to actually
> fill out the conversion matrix, and thus support everything simpledrm
> has advertised to day correctly, we would need helpers for:
>
> rgb565->rgb888
> rgb888->rgb565
> rgb565->xrgb2101010
> rgb888->xrgb2101010
> xrgb2101010->rgb565
> xrgb2101010->rgb888
> xrgb2101010->xrgb8888
>
> That seems like overkill and unlikely to actually help anyone, it'd just
> give userspace more options to shoot itself in the foot with a
> sub-optimal format choice. And it's a pile of code.
In addition to everything you mentioned, converting from XRGB2101010 to XRGB8888 loses the additional information, defeating the only point of using XRGB2101010 instead of XRGB8888 in the first place.
--
Earthling Michel Dänzer | https://redhat.com
Libre software enthusiast | Mesa and Xwayland developer
next prev parent reply other threads:[~2022-10-28 9:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 10:13 Hector Martin
2022-10-27 10:53 ` Hector Martin
2022-10-28 9:18 ` Michel Dänzer [this message]
2022-10-27 11:08 ` Thomas Zimmermann
2022-10-27 12:22 ` Pekka Paalanen
2022-10-27 12:51 ` Thomas Zimmermann
2022-10-27 12:31 ` Hector Martin
2022-10-28 10:04 ` Ville Syrjälä
2022-10-28 11:11 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54ee5dcb-d573-ade6-9132-8b165fbc875c@mailbox.org \
--to=michel.daenzer@mailbox.org \
--cc=airlied@gmail.com \
--cc=asahi@lists.linux.dev \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marcan@marcan.st \
--cc=mripard@kernel.org \
--cc=pekka.paalanen@collabora.com \
--cc=stable@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®