From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE30E1D47BC for ; Fri, 17 Jan 2025 05:27:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737091679; cv=fail; b=gk6uV7iiq0qUtX4nfLf+yksPpunvD0t3VwwDalTA1epyBIoC8sLATdwhzRg8eTh1EFjon1AdSUyqytBtL+0Ui/HlDsUKtTxfWGTx0u7NBo4s8/DORGn7yOFW4WOagepj7rf8F7jis5kikmfhWM9TfGqfR1DgbOBHl70TRolSOcU= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737091679; c=relaxed/simple; bh=0D2Bo39O4R/msgrCfOVVJBVsu/F2z1UWdWMk3+NL9yo=; h=Message-ID:Date:Subject:From:Cc:References:To:In-Reply-To: Content-Type:MIME-Version; b=U3IINxvMzeogqm4alJzxfF5O1jiAvqi7cJoIdtLxhBzLfliXzjjGz1eLiF8mAU75rqGnEwefPnYM1ma6Bg46QKsgRW+QyaK6pnmt/TVLaMxMZlamx7+voy1eVdN0EVVM/vGlaOarlHxYa6b7PG3ICppCqNzkeAOjLzHhaDCYb50= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=lxVStHG1; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=qGCoDSsP; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="lxVStHG1"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="qGCoDSsP" Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50GMBoC9007906; Fri, 17 Jan 2025 05:27:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2023-11-20; bh=6gkn3eoCl2j0jyWw4W2coVboXBuxncnmGSGXxNd0O5o=; b= lxVStHG1YMW6jjMRlq/oBP7PwBDtYIKObqgkb/PIMcsqqdK0bhE41e6LsagKkU5U qHS2s22srGcrBZftaPuBm1z7Ij6PJaYn+Ofdqu0dxnR8mMSClEaSLaHYtaBPcoJh Utr0QZMvDtZdwbSJO9Q90gSO8E5Sw7ziei/ZR48eBEg19xxBUxNaeMj+I7tm++sz 7pozkvYcQ8p7/AupeSs/7g9gq2N2BceeXYSriwYF/Ysjh/BGdBD0q3hqHvaGmAFk 6JnV5wKlP/yi999f2wZghNDy08y/D3T4kBnyc0WW3XaHmJWTAB8kF6y8wpF5SZVv nFSPe26jNUkIgB90JMycgg== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 447830gwen-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 17 Jan 2025 05:27:43 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 50H30Yt9005190; Fri, 17 Jan 2025 05:27:43 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2041.outbound.protection.outlook.com [104.47.70.41]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 4473e5xpt2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 17 Jan 2025 05:27:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aMMKvOyfgCWH3B+WPOv4+y5SUfxVp5eali9zfBjREg25yrjqtJ0cWIjxBvmuwfnsTLtwtilKeBhU3ELrKP7pQzUUh7MAvWftyJP///biOzLes6Omstap9gfwWZIoWtTD2bdqh6Vm4KynGRgLHt7s8D8A5AZZc0m475dq83w9ScxgIAMQVaK4DA5nCCG9VWYLpxzuyQGpVrFLdy20rA67VUqY4mGr3Etqr52Dyl/61PYapP0xiOikr/DY0twZ/OJx2tCaRf8zBDl2ZR2od+fKNxe5grPW49jUC5HXUHqGtydy29T/hDmaF0LuJAyu4RNOSbu6WIXINcgN9bdYFtZ5Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6gkn3eoCl2j0jyWw4W2coVboXBuxncnmGSGXxNd0O5o=; b=OVg8BRqn6U48Pvt1q2zO0pmxTgJHpRA+fbaLPN1BCufdtOKUrJEcWloIbDng1hyb3ZRBohgzO90VpjftNP0EilMaWr33LaDzZcGfE5i8gqTDXd2gk6omaT19TZkcUZHuxupazQEGH5V0j9p4ErJUfN07oukSDoUEGQ99/06gY85Y8cwMYi+fwmaDg1xkinP6dsjTolIJevMM5BmMgyN17rQ0rx7szKuoQt3/T75CLN1pBA0Sq0hE9ioNavZEraqNplJcsXbbqg9GN80KCM//0kktU/uDx0vH0Wk+YwF5pIy0BNEbUSao10IPPntwXabZBmAvzuChbtb+j/nOlvdoxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6gkn3eoCl2j0jyWw4W2coVboXBuxncnmGSGXxNd0O5o=; b=qGCoDSsPec2RUNoFBCEXSzto29Sw8IIRRC/2QiH1Ast2pfiWqmmaJhGMzuTIoLAhWU4toD8PykZp7OFI3hHsgHHBFa9sSuz9WctjoV4YNzR024S0193gbSLG4xAhSxhN/AXacvrdBZS/yDlj6LldOEDL7blQ+g83yJNXg6flgPo= Received: from CO1PR10MB4468.namprd10.prod.outlook.com (2603:10b6:303:6c::24) by CH3PR10MB6740.namprd10.prod.outlook.com (2603:10b6:610:144::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.13; Fri, 17 Jan 2025 05:27:41 +0000 Received: from CO1PR10MB4468.namprd10.prod.outlook.com ([fe80::485e:729e:c0a4:e562]) by CO1PR10MB4468.namprd10.prod.outlook.com ([fe80::485e:729e:c0a4:e562%2]) with mapi id 15.20.8356.014; Fri, 17 Jan 2025 05:27:41 +0000 Message-ID: <54ef8fde-fcbf-4610-a42e-dbb4713ef5c1@oracle.com> Date: Fri, 17 Jan 2025 16:27:32 +1100 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] workqueue: introduce queue_delayed_work_on_offline_safe. From: imran.f.khan@oracle.com Cc: jiangshanlai@gmail.com, linux-kernel@vger.kernel.org, Tejun Heo References: <20250113043540.2396426-1-imran.f.khan@oracle.com> Content-Language: en-US To: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MN2PR14CA0005.namprd14.prod.outlook.com (2603:10b6:208:23e::10) To CO1PR10MB4468.namprd10.prod.outlook.com (2603:10b6:303:6c::24) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR10MB4468:EE_|CH3PR10MB6740:EE_ X-MS-Office365-Filtering-Correlation-Id: 2fa1c108-81f9-401e-7a49-08dd36b7a9af X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WTM0ODZGOFgvZUs0cXFzZjUyMU45VHZKMnR5NTF6OUdKdlE0R0d5OEsxbEM5?= =?utf-8?B?Qm9KUm1DRFpoMGtPODF0ZWNlQUdtejlUd0FlWE42czFUckkwTkVsQUs4aXF2?= =?utf-8?B?QTZ0YVhDdGtDN25GUjNwZ0FZcmN1UFFCVFhMZktmUnhGYkprODQwR3g1aE9M?= =?utf-8?B?VkdGRXRIWnNHSWtUVHhWaFBqR1ladWhDR0tCbTlpMTViK2ZPeVhFL0Fhb3pl?= =?utf-8?B?V0tuZEJDUlk4aHdtTlZ4QmxEZ1dsblFPSlhBTThuMUtnZnNRTTE1Q29TakRN?= =?utf-8?B?OTF2WGxJeGI1eENOMmdQY0ZPUWVkSjBoK2hoMHp5Rk9xeldod1UzNjZtV21N?= =?utf-8?B?d0VVcysrM29FcjFzQVVSdTVWaWRqOVQ2bnJOVmNiOFh4TGdNai9WaUhvazYv?= =?utf-8?B?NE1aUzFiWVRKdWlQWjh1ODRWR3dQTGRyd2s2Y2xQMk9aTFRScHM3NXJES1I0?= =?utf-8?B?UzNFM0VqVFNVVTZoWm1hOTdkMHVVa1h1VUN1YnJmNk0rTGNVVzNXTXg5dlBO?= =?utf-8?B?WGVKaFcrMUVTMVRNdHBPZXh4Y2dJWExoYjQwSCtiN3c5d0Y0ZWtiNWVhbWo4?= =?utf-8?B?Vm5PdjBrZTkrcHhNYmdUWjM0eU5uN0VmV251S0JtNnA3NUNFVlMwN3NONHJh?= =?utf-8?B?aWVML2JOMVJzQVd4QkU3eTdCc3loLzhSSzF0TkZYWW1VK2o1VklUY2xXMys2?= =?utf-8?B?UjI0Y0NwRzhJSVhYbm1BTlNzOFNvN2JvNU1JaXVYcHcwMnlxRGFxNHJKaCs5?= =?utf-8?B?ZGxMaFY0cHZ1UVR3aTRYUEVoNW1wdTE3WUVXMHZrcFAvZkRFemRDeHV3Uldm?= =?utf-8?B?a29SOEF0NEI2UU16QUxPUDNTYXlFS1IvOENZU3R6QkZsUlNwYnhuMEx1Y002?= =?utf-8?B?YjlMRi9lZ3QxZm5RdlpxOTBxTFZJUlJXSk5MZVNaV1NJd0ZXZU4zZmVpNmxx?= =?utf-8?B?SCtmRnhIYTU4Tk1KejgrUk9QMjhBOWVxNWpKUUtyRDRQWU1rOUlRbk9zeHRS?= =?utf-8?B?bHBkY3VUSCtGc0J0ckt4a1ZFWjdNTlJCNnVzL3RhY2dMSXNlQUdlS1JBTnp5?= =?utf-8?B?bnMwNlhpUUxXZXErVEZkdEx6UDZpVVdLZHFGV0JsQm41MkxCdmpXNVo0UWxu?= =?utf-8?B?blhmS1YxU1hkYTVPQ0JHZnVFalBxVUpOVEFSR2RSRC8rS3ltWEZCNzZHZDh2?= =?utf-8?B?dVF3RkxsaVdXcXBLT3JIK3IyaWxhcjN3VjRrVTBGS3c0T2V4eUR1Vi91ektR?= =?utf-8?B?VlZPRWhnYzVlVHkwa2RIL1FUQTg0ZFVmbWJpWUdwbllKZ29oTkFyQWNNclBm?= =?utf-8?B?Vlh0SkRXK1lZaFRCZC9LeXlOdUdVajJjTXFya2JoK1EvYXRNQVZHbWdPbHg4?= =?utf-8?B?RWVtbE1jNVdGY0ZLQ3RmRlN2OVRySDRleE5EZlhwV2RjMnBBT3VVY1d2MnIz?= =?utf-8?B?bjNFMlJydzhvZitmaC9PVTNjTDRSdlA5djhDMmRjZHVETDJaemdMNnVSd2ZE?= =?utf-8?B?dlk5VmM2Q3VEYXFKOXo4SnF3S1p4WFRKdE9JV3RWOFF6QS8zY0ZLYytjVXpW?= =?utf-8?B?MDY4ZGFUZmE0WmtpZjRKUWN5YjlFYWU5Mnd5enFPUDNYYldNcmZkNVFrSjZW?= =?utf-8?B?TGlwVU8zajZiU0hYbFhlNXpwN25oQ3hQdXJxd3QwL05nbm94aGQ3djhLaWwy?= =?utf-8?B?Z2VYaUI4RUZPRWliVFpZN244dXdKbHRqTWFuQ0U2VWxjYktON3NMajBJODFr?= =?utf-8?B?RmJjaCtxMmgyUEpVeW1pN0lMMjV2VkNnd1Q4aVZVNXdOcGswK0h0OEVDQ1F1?= =?utf-8?B?NkhxZjg5SnlMUGU3akRBQT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR10MB4468.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U2t2ZjhHNkN4NXRUblhxNHBBOEhsbXBraDA0MDFNVXUvb0JvTDlINVhYM1Fn?= =?utf-8?B?OHYrQ1dMTFdPSTZQUkFmMGVxSHRxU0dOR0ZRMUVQOC9acGc1Q0s5NDMvRGdV?= =?utf-8?B?ME1DQzhveldta0Z3OSszcU1SclpscXlUR2loMHlHRXZ0eEs1N3REd3hURWl4?= =?utf-8?B?OTA5S05SQmYzMTVtM1pIeWZxWFpqY0M5cEtFcFdJRDY4TW5SdlNpckhIMS9F?= =?utf-8?B?OGxEWE81RXgxZE5uWnRacEs4V0t0dEFNZ2JKc2tOZ2RzRmxaMFZYbFdvV1V6?= =?utf-8?B?K3FrOUc4MFRtazlqMmM0NVhzTlJJL3grWTQ5V2RHb0NsVVZ3YnpaMmFOcUo5?= =?utf-8?B?V1VOSStpckJpYzJxeVVORy90djVyZlNXSFdTMVpFYWIwOHNMWGVmTTVSNGJq?= =?utf-8?B?QjRkU2RxU05LZ25FR3RTOEh3WG14aE9EZW1MdWpIYkMvVUduT1Bnek53dWF3?= =?utf-8?B?Wk5OSkhNUDRzd2FlK0w0TWlyL0dUalg0a2hwbGJDT2NSME0xL1VFOU1DZEdm?= =?utf-8?B?MzBXem4vbWtIYUE1d3Y1WGFMdEJ2RlFaUDgxMUlkZVZIOENPYnpzMlU0KzE4?= =?utf-8?B?RDNWZGZ6Nk02eFd5aG1IdEo1Skg1RVZPZXAydW5JUWVIZFd2Vm84a0hQaFVC?= =?utf-8?B?NTZoZEhFbTBFTFBkVG5DNWJhOVFQb2J3VEVTQTZCMUg0M2lNNWZZUnpET2Zn?= =?utf-8?B?ckJhcnBPU2xaQi9PbmdtTldKaHdLMUFQMkNwYS95OTBibUFrK2c3NHB1N0VO?= =?utf-8?B?YzJIdmxNaTREUzY3Z1BOSTVuU3ZWUk0xcUQycUkwN0RwQjc3bFZpQ1dTR1VI?= =?utf-8?B?dzBOQTlNeTNpSFIrL1FxRlNTa0plYnJFeGh5Z01URUwzV3A1ejRqejFYT0Vn?= =?utf-8?B?L2o0blJObXZtYjZqWCtrSTlCOEhaY3FUbzhQRmxVWXZQT3RyTnhXeEhpZWho?= =?utf-8?B?emp6VlY5MGxtTnJCU0krWDB0L0VQb2lJY25nU1ZabGh1TlVVZVF0SnVhM2E0?= =?utf-8?B?eFk2NmtUajM3TW5VUzB1endCK2I5WUh5RFBLYTZlOGxWMmNVL0dGTnZ4RnI4?= =?utf-8?B?ZndaUytkWWZheTJhUU1mdWlESnN2bytUaTgydW04L2syai9XdzAyaDZwV2FF?= =?utf-8?B?bFJBSERxWEZyc0dQMzRYM0p2NENlZ244Vy9JTHRNT2FvbWlHd3NBcGxieVFZ?= =?utf-8?B?eHVXaHNUVjZ3TW04eFZFVytrNExDMmlGQWFqNmJ2UnFMc0J0NFZYblpmcVM2?= =?utf-8?B?cStxaGJzajlFaExQVFFpRy9EM1d3aVcyVUdPcm9Pai9RcS96T1I3c3FFanBr?= =?utf-8?B?UXV6aHhXVDM3a2FpcmYzZ3JZRzRhMUs2c2ltL0VkVzByWU9XZWJJVzVKNUJj?= =?utf-8?B?eHZlN1NtSXE0OEYxRXBCRk9kVzl1S0pHZSs0SnpNOGt6eXBSaEhzbXJLSTAx?= =?utf-8?B?NGVCUG1neUI4bCs2eGpEcTdEWUxkdEkrRDRWMlZzWTFJOXFTejhkZUhOOG9J?= =?utf-8?B?L3NwNDlRZXA3ekhFTEZ3N1ZzQ1ZuN2xiK1dQRzBiMGw4UENjTDR1S0JoTTFk?= =?utf-8?B?T0l2RXJDbFIyRmhSdDFLMU1yMlh5K3NXbE9DQ3pDaUx1MHB6UVVqM1RFUlVa?= =?utf-8?B?bkROcE82RGlwN1NDWjl2c0Jxb1JrY2VYL1h2QkJhSmRLNUpObUtZQUZaaVI4?= =?utf-8?B?b0dvcEJmSFFvSzRRMlQyOHNuREFGQ0w1blZISjlMS2Fqak1pODhOMGFlODBl?= =?utf-8?B?K0V3QUVVOGVQWlV2ZWlGSHBmQkcyaGpuRmp0M2tNY2NYT240bEZ2ekxQdmYr?= =?utf-8?B?UHNiN0VtdGN5UGJreDh2UWs5NE9mNGUzb1lUNjVrUC9HSDVpNzlKTklJK0hE?= =?utf-8?B?aHlwVUNoNGxDWWRVaElwdTN0a2x3djlhdFVJRU9rQk1qbTN5L1Ztc29Wd3p3?= =?utf-8?B?MUpFbzhQRlJyQmVJRHU2NDlvRURWaVVNVDB5dGtzcTByS0E5MFhCYnhURURH?= =?utf-8?B?bWhYbXRlcGJrV1M1UnFrTTZaY2JqNmQyb3BDQlJhU3BWcVJDeVVtQVg2bHJ0?= =?utf-8?B?VytOd2pLVmRyKytqenNSTWZnNTFnbFlrbDRwYmRsZytZTzVlV20vdlpyMm1w?= =?utf-8?B?bi9HSThKa2cwU0ZZd1EyMzJLeGR4NTVYVVFpQ0wyaEZ0U3c2QTZuZ3ZCOG5T?= =?utf-8?B?d2c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: rkaHzevufdiAOLSABlTuCUojMnzR6msx8SoTvLBycj7kUxc5LLB28vfegiIaDVSLWkEJCCJRaZ+4PnH1Ko4OOWL0jN4Oik6BXiyXFID0lxmuauZgJawbVbEbkl3uVy5/4r7yHvpIpPPaCL8eliugmMVxglxHR8+np8J19LJe92y3WZiXh3PES08yiA/wTaOJkZaa2E5fMOUSAE06qATuUemcg2h7NQSmE5q9LbiMRsTAcpg0gYNxaki3WYVLwHxn69nfeJ2yyA6wDobCRNn7FR6CRfO7FTw0U0i6ImNaTEIXNcd+Fidof0cZ+3Lvcxg0/Z0G+uvhvuDd8GyeqK3WGazQ9zKOKK7i6heJ3sKKTadhN32A1vmz+w4sJbENEOgcYpjpLB3Daoo0jFRIufksRMjuvSJK+6oq1b34SSwZW0/f2kjnIag7MiFvUrAamZNC83oXbmkrJcjeSY0YpJbjOGl25kT5CBmNLsZ9htjf4twH+9sN5cgW1XZ7Rn8phwSQFjzoLLqi3acibLQZbgZ7+kRCCZbkx5we8wXAeI/O8XtomEj7eICmJRx82H420lk3nB20IWUbvxXVRhtWhF6GaNtKFJLOVQ9M75SBeAKqCbc= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2fa1c108-81f9-401e-7a49-08dd36b7a9af X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2025 05:27:41.2102 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: q1G7e+8UjzINKzZbBZgK13qUJE8VFpVbyYHY4XUd4PM4VwNZ3Jp72XeOhgpyJipxJrWql2ElQiDYnLWgjZvy+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB6740 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-17_01,2025-01-16_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 adultscore=0 spamscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2501170040 X-Proofpoint-GUID: Oh2knH_1XinIeHpU3zl2rrnRvPo_ulM8 X-Proofpoint-ORIG-GUID: Oh2knH_1XinIeHpU3zl2rrnRvPo_ulM8 Hello everyone, Firstly, apologies If I have added too many people. I have used maintainer list for drivers mentioned in [1] and further mentioned below in [2], [3], [4] and [5]. To give some context, in this thread we are discussing the problem of, queue_delayed_work_on (with non zero delay) putting the work on an (already), offlined CPU and that work not getting executed or at least not getting executed timely because the underlying timer would not fire on an offlined cpu. We observed this issue with some in-house changes in RDS code, where some preferred-cpu was being used to queue the delayed_work , but it was offline and as a result corresponding work item remained stuck I could not locate any reports of similar issue in the mailing list but I see that [2], [4] and [5]are also using some sort of cached/preferred cpu information to queue the delayed_work on. So could you please confirm if you have faced issue, similar to one being described here and if not how are you ensuring that selected cpu is and remains online. For example [2] is using a preferred-cpu, obtained from [3], but [3] is using "cpu_online_mask" to confirm that cpu is online. But can't it happen that cpu was seen as online in cpu_online_mask by [3], but by the time, timer of delayed_work got added this cpu was offline. I understand that race window is very slow and very unlikely but it still looks racy or am I understanding something totally wrong. Similarly, [4] and [5] are using cq->chann as cpu for queueing delayed_work on, but its not clear how its ensured that these cpus are online. Is there some implicit semantics,that is confirming that cq->chann is and remains online, during submission of delayed_work. I will very thankful, if you could clarify the above queries. Thanks, Imran [1]: https://lore.kernel.org/all/eab73ac2-d9eb-4ac7-9e0f-9a02b81a31bb@oracle.com/ [2]: https://elixir.bootlin.com/linux/v6.12.6/source/drivers/net/ethernet/pensando/ionic/ionic_dev.c#L177 [3]: https://elixir.bootlin.com/linux/v6.12.6/source/drivers/net/ethernet/pensando/ionic/ionic_dev.c#L76 [4]: https://elixir.bootlin.com/linux/v6.12.6/source/drivers/scsi/lpfc/lpfc_sli.c#L14987 [5]: https://elixir.bootlin.com/linux/v6.12.6/source/drivers/scsi/lpfc/lpfc_sli.c#L15381 On 14/1/2025 2:01 pm, imran.f.khan@oracle.com wrote: > Hello Tejun, > Thanks for taking a look into it. > On 14/1/2025 5:21 am, Tejun Heo wrote: >> On Mon, Jan 13, 2025 at 03:35:40PM +1100, Imran Khan wrote: >> ... >>> I have kept the patch as RFC because from mailing list, >>> I could not find any users, of queue_delayed_work_on, >>> that is ending up queuing dwork on an offlined CPU. >>> We have some in-house code that is running into this problem, >>> and currently we are fixing it on caller side of queue_delayed_work_on. >>> Other users who run into this issue, can also use the approach of >>> fixing it on caller side or we can use the interface introduced >>> here for such use cases. >> >> I'm not sure how necessary this is. If the timer is okay to run on other >> CPUs, might as well just use queue_delayed_work(). >> > > Yes, right now I can't locate something in upstream kernel that gets > broken due to the issue mentioned here. > All (except 3, mentioned further down) users of queued_delayed_work_on > are using smp_processor_id(), to specify the CPU. So specified CPU can't > be an already offlined CPU. > > I see below 3 files (in v6.12.6), using queue_delayed_work_on with some sort of cached > cpu information: > > drivers/net/ethernet/pensando/ionic/ionic_dev.c -> line 177 > drivers/scsi/esas2r/esas2r_main.c -> line 1858 > drivers/scsi/lpfc/lpfc_sli.c > -> line 14987 > -> line 15381 > But looks like in these cases specified CPU remains online or > they simply have not encountered the issue mentioned here. > > > For this patch, yes the timer is okay to run on other CPUs but that is > only as a last resort, most of the times it could still run on specified > CPU (assuming its online) > > Thanks, > Imran > > > >> Thanks. >> >