From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: neil.armstrong@linaro.org, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: amlogic: align LED node names with dtschema
Date: Sat, 26 Nov 2022 15:24:52 +0100 [thread overview]
Message-ID: <54f500cb-d7d0-8af1-eb58-99fbe71791a5@linaro.org> (raw)
In-Reply-To: <a135f93a-235a-27b8-f649-69d62f6ebd30@linaro.org>
On 26/11/2022 15:16, Krzysztof Kozlowski wrote:
> On 25/11/2022 18:16, Neil Armstrong wrote:
>> On 25/11/2022 15:41, Krzysztof Kozlowski wrote:
>>> The node names should be generic and DT schema expects certain pattern:
>>>
>>> amlogic/meson-sm1-bananapi-m5.dtb: leds: 'blue' does not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> ---
>>> arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>
>>
>> <snip>
>>
>>
>> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
>
> Aren't you maintainer of the platform? This means I should take care of
> this patch?
Ah, this will be picked up by Kevin or Jerome? So this tag means only
Reviewer's statement of oversight, right?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-26 14:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 14:41 Krzysztof Kozlowski
2022-11-25 17:16 ` Neil Armstrong
2022-11-26 14:16 ` Krzysztof Kozlowski
2022-11-26 14:24 ` Krzysztof Kozlowski [this message]
2022-11-26 16:03 ` Neil Armstrong
2022-11-27 12:25 ` Krzysztof Kozlowski
2022-11-27 13:33 ` Neil Armstrong
2022-11-27 19:07 ` Krzysztof Kozlowski
2022-11-28 7:17 ` Neil Armstrong
2022-11-25 22:55 ` Martin Blumenstingl
2023-01-02 9:45 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54f500cb-d7d0-8af1-eb58-99fbe71791a5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®