From: Alex Elder <elder@linaro.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: davem@davemloft.net, kuba@kernel.org, bjorn.andersson@linaro.org,
evgreen@chromium.org, cpratapa@codeaurora.org, elder@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 0/3] net: ipa: QMI fixes
Date: Tue, 16 Mar 2021 11:00:37 -0500 [thread overview]
Message-ID: <54f8962c-6503-8d92-2a6c-875c112441a4@linaro.org> (raw)
In-Reply-To: <20210316032557.GB29414@work>
On 3/15/21 10:25 PM, Manivannan Sadhasivam wrote:
> On Mon, Mar 15, 2021 at 11:50:15AM -0500, Alex Elder wrote:
>> On 3/15/21 11:38 AM, Manivannan Sadhasivam wrote:
>>> Hi Alex,
>>>
>>> On Mon, Mar 15, 2021 at 10:21:09AM -0500, Alex Elder wrote:
>>>> Mani Sadhasivam discovered some errors in the definitions of some
>>>> QMI messages used for IPA. This series addresses those errors,
>>>> and extends the definition of one message type to include some
>>>> newly-defined fields.
>>>>
>>>
>>> Thanks for the patches. I guess you need to add Fixes tag for patches 1,2 and
>>> they should be backported to stable.
>>
>> I did not do that, intentionally. The reason is that the
>> existing code only supports IPA v3.5.1 and IPAv4.2. And
>> these bugs seem to cause no problems there.
>>
>> There are some patches coming very soon that will add
>> more formal support for IPA v4.5 (where I know you
>> found these issues). Those will not be back-ported.
>>
>> So these fixes don't appear to be necessary for existing
>> supported platforms.
>>
>
> Hmm, okay. Then please mention this information in the commit description(s)
> that the fix is only needed for IPA4.5.
Mani, you ACKed all three patches after you sent this.
Are you expecting me to send a new version of the code,
or are you willing to accept the series as-is?
Thanks.
-Alex
>
> Thanks,
> Mani
>
>> If you still believe I should have these back-ported,
>> I have no objection to re-posting for that. But I
>> wanted to explain my reasoning before doing it.
>>
>> --> Do you still think I should have these back-ported?
>>
>> Thanks.
>>
>> -Alex
>>
>>>
>>> Thanks,
>>> Mani
>>>
>>>> -Alex
>>>>
>>>> Alex Elder (3):
>>>> net: ipa: fix a duplicated tlv_type value
>>>> net: ipa: fix another QMI message definition
>>>> net: ipa: extend the INDICATION_REGISTER request
>>>>
>>>> drivers/net/ipa/ipa_qmi_msg.c | 78 +++++++++++++++++++++++++++++++----
>>>> drivers/net/ipa/ipa_qmi_msg.h | 6 ++-
>>>> 2 files changed, 74 insertions(+), 10 deletions(-)
>>>>
>>>> --
>>>> 2.27.0
>>>>
>>
next prev parent reply other threads:[~2021-03-16 16:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 15:21 Alex Elder
2021-03-15 15:21 ` [PATCH net-next 1/3] net: ipa: fix a duplicated tlv_type value Alex Elder
2021-03-16 3:37 ` Manivannan Sadhasivam
2021-03-15 15:21 ` [PATCH net-next 2/3] net: ipa: fix another QMI message definition Alex Elder
2021-03-16 3:42 ` Manivannan Sadhasivam
2021-03-15 15:21 ` [PATCH net-next 3/3] net: ipa: extend the INDICATION_REGISTER request Alex Elder
2021-03-16 3:43 ` Manivannan Sadhasivam
2021-03-15 16:38 ` [PATCH net-next 0/3] net: ipa: QMI fixes Manivannan Sadhasivam
2021-03-15 16:50 ` Alex Elder
2021-03-16 3:25 ` Manivannan Sadhasivam
2021-03-16 16:00 ` Alex Elder [this message]
2021-03-16 16:38 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54f8962c-6503-8d92-2a6c-875c112441a4@linaro.org \
--to=elder@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=cpratapa@codeaurora.org \
--cc=davem@davemloft.net \
--cc=elder@kernel.org \
--cc=evgreen@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®