From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753379AbdKWVLE (ORCPT ); Thu, 23 Nov 2017 16:11:04 -0500 Received: from mout.web.de ([212.227.15.4]:55058 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752425AbdKWVLD (ORCPT ); Thu, 23 Nov 2017 16:11:03 -0500 Subject: [PATCH 2/4] ASoC: twl4030: Use common error handling code in twl4030_get_pdata() From: SF Markus Elfring To: alsa-devel@alsa-project.org, Jaroslav Kysela , Liam Girdwood , Mark Brown , Peter Ujfalusi , Takashi Iwai Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <54fbbfe9-ee59-c346-e22a-f059e1f2552f@users.sourceforge.net> Date: Thu, 23 Nov 2017 22:10:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:YHqkoZRnVeeOI+a0KWImPi8StWYDD+UP2yM/RUWOzthiEMzEIf2 IXjF9EDqIGc2PXL+9eUKpT1ThgkdpBpkyqkW4SnCvvoowv646Ej/FKxirHsbbcAFo9iAWO/ 2JiSvpzIUidy7LzwaLETLFMBnAeJd3+uZwr33t3R6MoJB3vo6oYQ4pjxi77ocG5X0umTHQj vcooUwJy578I6IM2XGheA== X-UI-Out-Filterresults: notjunk:1;V01:K0:kCqHjOfBVec=:6yPc2g9AxtPz+xEWHke0nA JVKywnaAM+jYKEL/cs5NmUAgRqb1IsT+nb+MI3hZWXQEcWKmwSgcl9GACx1fFwHZYRvMYi4b+ IoVTwpCa30+YoYIlBUuU/VQdAu+6OZOToR/gs5xP2ZJf308PMakgxSUPlZNkwX2YFilAcmEx6 g76YrKo5qbVACCAzaTqJ14JJgzSAiZtyUF0RSsvK0K6cpJRkVLSaI4Skg6YgJ+JJdwgeKeRTH 457XAafp9BJ+NI4TUESHVnedUeXQtMKTbde/OQUCvsQ/SrgKMeQJdIPeSaiWYDroKNvh8xmDD 0FlCUFgUlSLau4VLBoPwxEzErlhhBk1pJC0d7TVW8CyRIMANciwsaE9JWbjiEdadt0sWpaLvG CGYrGC6U+jyQ7xTYg9WBORbRtWcaDQAp97sGBhxTseuYNUJVKdVMQPLPi67CVz7SGqVBodM36 wNT/sR5RmvggfWxnK64dVappdDAVM2Su4ehfpMjP8o4vVaPq8hz7+8iQBqP+TGQk+oEx0w0vv B/sXCt3eAEzDl/fzWxqudte1cazphsrivy0kv5l22cG8EM7oPA4CElk4e3tYQe4/qoooyyuYQ WqB1nMMGnOc/Vzkul5/Zp7105yc47FReC2I3SmWNEBWBGnlKmY4HMmRRPfV1gGxlMLVwBKn3t nTb3o3/k2NzGKmVaC6wM3qyj1UpphqPgy/mCsGI3VhgsorOwjpyTgir/9+O8U2CA2A0I5oTb2 bSaX3jFao6p4v2oCHUb9w73F5kZOoOCe8yAzStziImA3cvlPtbZEniohkoZDnzPOGy3pxK4h0 saQl8KFDq/3yatO9ws9BVT6Ko7HSE0L56Fk3wVIH2nohr/wm5M= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 23 Nov 2017 21:35:28 +0100 Add a jump target so that a bit of exception handling can be better reused in an if branch of this function. Signed-off-by: Markus Elfring --- sound/soc/codecs/twl4030.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c index 90691701b082..a1f0b45c83ca 100644 --- a/sound/soc/codecs/twl4030.c +++ b/sound/soc/codecs/twl4030.c @@ -239,11 +239,11 @@ static struct twl4030_codec_data *twl4030_get_pdata(struct snd_soc_codec *codec) pdata = devm_kzalloc(codec->dev, sizeof(struct twl4030_codec_data), GFP_KERNEL); - if (!pdata) { - of_node_put(twl4030_codec_node); - return NULL; - } + if (!pdata) + goto put_node; + twl4030_setup_pdata_of(pdata, twl4030_codec_node); +put_node: of_node_put(twl4030_codec_node); } -- 2.15.0