From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from YT5PR01CU002.outbound.protection.outlook.com (mail-canadacentralazon11021085.outbound.protection.outlook.com [40.107.192.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A889830DD0C for ; Fri, 30 Jan 2026 15:36:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.192.85 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769787403; cv=fail; b=V1qMxi5gycwxyeP4r41RY3/OrAq633u2f4stKbGa+qxiOFgMcWexPDGRyQDV+a3lalZ6sQlCgTqXabnmpmMLGLhBMmMzUwiZoyT7iA/HxNcXd9JoMB2zwW4grf0e+i7xctNg3qEmAee7sy8u0OvRJM9uRug8kfVSvXRjLMUOwQo= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769787403; c=relaxed/simple; bh=CV0e7JwsspVVvKXsEGbjbdJTGPCHd4pmO7jHv5ch9IM=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=lzcvqiw6saYIcPvPH0bjbIqnnZ+JSAcGF1FP3Il+NhFfYQAvuP1bm4ZOccKMqafQWD3duWhsd3LCxIo6iENb5jFUFmlQzLawYIihSoB4VUBGPX4UBiLIpswPIzG9S2nBClctLnlz2deTTXP+8w5ARK8eoTOAoZVKK14fsyHhvFM= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com; spf=pass smtp.mailfrom=efficios.com; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b=o3ze0GR8; arc=fail smtp.client-ip=40.107.192.85 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=efficios.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b="o3ze0GR8" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gW40OiN48YSEZx9Ht4aUj6V7SrnTsEhctwuLgc1eqyeDu43OkQD20HY7vxqWCvEK8CxnVYFuueH2/Zk80iMh4Kmx4+cfjqiYgk2afWmw0wK+O3WOixMyBVEWXDgzHi/NXFNZKEQa+eoucyCJVREqDHY23WpZ4/52RXqYU50+joMV8ZCZ4m+OCUCJF90/fm///h6exoSeWQssbLqqacnukM3xw0N+8sS9AIg+YQ27SkVoef4QocXLoiAURl+mF6vvU3dhT39COvxn3cvXM/edcoZ+SVt4r+SFIHW5jBZFXrdoiqLbuwwWzV9lORtKFG8C4i0ViAldpNjaiYc3G95aCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UW6DrqpUqsLMdrAfe7fBEHmhdU5XeEGkHvR+R7v5l40=; b=DlHCtT3L9vA7LKd8hO+wJq5QkQLtSmUu7gYNLpeaOXDle/yqpLhPgxgO9mp9gCUVhyvOoamqisWvcbylDinHbjtM1rioiHhE9btD3If/C1P88PdExdlJGIF21elKXDt94Ttxf3XtmW0Ityy8Kzf8uW7mvDZpo/3NQUYiheAX4Xl4t34O0rJ8iaVnZbusFByU0NFIeKxtRD3itVEslMdolfjD9wU2H2TTMG+OkCIqyxhNoWUmVb6sZzFG6tkgoVpOrb1ffTcfT57g15sadIzrPDlDXC1oXki1oJBroZ+dMlX0UZTn2qLbf46Nay0/KcBLXN6F0ImnHJq497/fPZI30w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UW6DrqpUqsLMdrAfe7fBEHmhdU5XeEGkHvR+R7v5l40=; b=o3ze0GR8he6z0R25cO1BK8UNmD12ox3aXp5QomWGHx+Qww19NQQ/8wgI76NwHt5S+2Lme5DIWc1kV9h989K/nctoOTiceAxgs/RLr6UM/dsvcjWHqHb8ogA0EskZyNo2TYMDtQSqUQleMekg44Zafewr8qoXBkysH3ejfJabcmlHxnpCSpin4UARe9fjnzVBzrMN3FCFq7N13Rg5bMp+5awO8qKZZgvQG9HdV38LJ38BeMqrYahKo38vAtRIaWCghq9p0KdGW0FrFrgtMbWNqkJMeLaFC7rJJk55cInSzpWUfGO2HEpTgeCwp6Q+PKI3uBZktYSZnCYvHzF2q0UTNA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:be::5) by YT3PR01MB8161.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:9a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9564.11; Fri, 30 Jan 2026 15:36:38 +0000 Received: from YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM ([fe80::6004:a862:d45d:90c1]) by YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM ([fe80::6004:a862:d45d:90c1%5]) with mapi id 15.20.9564.010; Fri, 30 Jan 2026 15:36:38 +0000 Message-ID: <54fc689c-fa9a-4e9d-9f5e-9dfd7da54a02@efficios.com> Date: Fri, 30 Jan 2026 10:36:36 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [patch 2/4] sched/mmcid: Protect transition on weakly ordered systems To: Thomas Gleixner , LKML Cc: Ihor Solodrai , Shrikanth Hegde , Peter Zijlstra , Michael Jeanson References: <20260129210219.452851594@kernel.org> <20260129211557.746946556@kernel.org> From: Mathieu Desnoyers Content-Language: en-US In-Reply-To: <20260129211557.746946556@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YT4P288CA0094.CANP288.PROD.OUTLOOK.COM (2603:10b6:b01:d0::22) To YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:be::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT2PR01MB9175:EE_|YT3PR01MB8161:EE_ X-MS-Office365-Filtering-Correlation-Id: ac078409-15cb-4237-906f-08de60155b91 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?OHptYWU4QjBCSUNqRk5MYTVsQ1V2aHQ3MEhoeGR4QU5DWVRXbDdBVERmRitY?= =?utf-8?B?KzE0MGtFVlNjMGc1THBUbTRrL0U3ajJMRXlPQnhVMXpjcWxWY2JZQVdyQWYy?= =?utf-8?B?ZTI3MWVWUFZKU1ZXYlE0NmFudnZoTlAwZHp0OUN5Yy8yV0EwczM4MzVPYWJo?= =?utf-8?B?eTBxSUhxMHNtYWJKamtoVzNVUWh0ckcyMGFWTS8yYzI3NEZSbjRmbnRnVXMv?= =?utf-8?B?aFA4ajFKOXlTM1FzTkh0cmVoNHNmd0swQ1NSYVdDNk1XN1VzQ0llYUZ3Ukpu?= =?utf-8?B?ak16Uk5iWTk1dHVEWmZSU3JSaGxlTUJMeUJtUnExSnI3blpXV2NBSGtjVHJt?= =?utf-8?B?NmRLdk4wM1NuY3dvZU1Ob3czME5GM0VERzJub3BKbzlxWE9za2QvMUQ5R0d6?= =?utf-8?B?U3FuYWdUOEdGelhGUTZCK1RYY2Yxb05LTFFhU0NDUGZmV09sTVhYVnZKR0lx?= =?utf-8?B?bkdDbVk5eFJKbXRTR0RxSkYvSkl1T1ZuUVUrWmdMZS9wUFIxMWtTNVkrTTVZ?= =?utf-8?B?UVk4d29jdXdJODcxZjQzLzNURDJyZWpTaUgxRVFneUYzU2hhdFMzTVUvZkc5?= =?utf-8?B?M1pYSGZkRUV0N0xTK2ZRUkMwMXpuSFEvZ3JOR0x1aWkwbVNUYVhkTHdra0lL?= =?utf-8?B?emRFMzNKM015eDVHb2NMMTcwamRmYVpidmpxVEdqYWl4UmFXcmtlaUV5QU9P?= =?utf-8?B?dFdCU1k0SDUwRmZ3TCs2c2taSHBEb1Vkbno2bExVYXNlRTVjcjc5d2d1aDdy?= =?utf-8?B?cDVYMVdvV2g2blg1dzNWU2U3UGJVZm1adTJRR3lZdE5xcjZBenB2WVNVRG81?= =?utf-8?B?c09MTFE2cjJkUnRDd0k4QnhxVjhVY1NXUWhJK0pYVVFoY0FqdklVc0JoSXht?= =?utf-8?B?V2cwenJMbjRTZFJHT05xM1RoeGdpUG1kSHR5Y1Q1cldRaFZ6MjJWMjRKRG9t?= =?utf-8?B?MCtsV2l0RTlkOUdycWVXZS9SZjJWSFFaTGt6NEsza1BTN2dPenF3OXMwOEpE?= =?utf-8?B?c2k1d2laZmdsdkVFK1RqUGRlanpqa3Q4cWJSSk5mNVhIVlN0dWpHTDJmMGh5?= =?utf-8?B?N1cvMk13eTN4a3ZQdHhRN1lMdGRBc05BN0tSdlFGbytsRGxWRXorNG1pNkJC?= =?utf-8?B?UWRuSDNlSjRVZUNYa3pKaUI0Q0xQdE4rYXhLOFY0RkNoSjk2M3FDL1JYSHpY?= =?utf-8?B?TDhPL0FBQjIwck8zTFQ5b3BZMkIvRi9vWHgrU0pKYVZocDZYc010UStUOXdz?= =?utf-8?B?Z1pSVTYrbnhtZU9BV0ZkcFRYNklUZEd0TTVTVTNQYVdMR3Bva2hQOUh6R3Av?= =?utf-8?B?RFFKWThlems1dlRFNzdrNUF4M0l6VmFValA3UUYvaXliSjZMN1l4VXNVMlhq?= =?utf-8?B?dVdtakJLY1BLdHlqcm1KUHZ4NGMzODFjVTVqNytHcjlLUE5pMUluczhjbkdR?= =?utf-8?B?UTlhL1p5OFpFRGRNeW1kNlRyaEMvbWtQeStmdjQ0OFN5aitybTcxdzFVdTNr?= =?utf-8?B?ZkRNTVRDKzNaeDNVR0pYVlB1eitJZ3RjRHJEVmRiQXpmd2EyUDFEMjhFY1RD?= =?utf-8?B?eUFwRElaNnl4SHp0K2JQa3AyOWpZbVpGalhGaWZQS1RWODd6QUs1QjFGRHRa?= =?utf-8?B?MGZYRG9SbkJla3U3blVVM3VwbFcvVld2Y2RRbEwxdWkrRmw2b2hRWlg0Tktq?= =?utf-8?B?cHpXalcvVEpIWk9Pb2ZiWmVOczdHUnZkRlQrNWJ5T1NESFJPTlFWRXJlbVdT?= =?utf-8?B?Tlo1ZXI0bFkyRXlocXo1M2QwL3o3UlBRK2FpTHRmd3NlSlplTFJaMzZydGUv?= =?utf-8?B?QUFnb254eGdwWGY2MzdiME84b3J1ZmtJYTNadUpnVHo4bVVxQnFzVW5oNnBB?= =?utf-8?B?dzhCTHVWTkNaSEZrMzhjV283ZHIvMndZUmVVVVN1SGc3ZWFPTXQxRjBqcHRF?= =?utf-8?B?RVNwU3FDeUJVQzRBU05iSjByNC9hL1FpeUs2ZXlEK0xvVVpQcmFscDBjZTQv?= =?utf-8?Q?Ljw6XqXqRZZWKJ8RMLu4WxJCxE0BB0=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VVJ5dXFKejJtK1p0ZUk3cnhWQ1lJekkycWE2SEQ5d1ZrM1ozRTZ6MzNTRHBV?= =?utf-8?B?Z2R6K2xOellZODllak5CZjhCYzJNZFhQQUZjTDVCSlZsMUNESytvTVN4Wjc1?= =?utf-8?B?Y3FaL0VDeDF1OVQ4U0VoZS8yaEFBRlNoc2MxbGwxWm1ESmFMQnRDRmpFcmFM?= =?utf-8?B?eWRnVHFyL25CSG0zd0VPcHVYdjd1ZWpuWVBuajJyZ3RJS05xTkpzYTVmVjNa?= =?utf-8?B?bVRWUjJNVzJxZEErT3YvUEVFNGU4bERsRmRaL1JpUktqZC9WZ1VxU3JaRExj?= =?utf-8?B?UE0rUys2U1VSdGZVNm9YeENpZndYaVhYVVZTOW1Zd08yV1N1WXpNdHZtaEVC?= =?utf-8?B?T3M5N29NbVBkMEIvTXBqNUc5blVqWEQ4YUt1cGEvRkxadE16YnZ0NkFkam5l?= =?utf-8?B?VXJmNTJOd0I5a2M1ZkNVckticWlmU041YmFUNVdVRG5kK3h2Q1lMckZnMnZz?= =?utf-8?B?MFBrNVRSR0Y2UmtTSU56MHh6a3pNVng4akZWL3VCc0tiSU4yYnBreStONE1w?= =?utf-8?B?TElvWnNJTnNDNlF4ek8xWDVaSWxxU0wvVk9SeWJSQUt5NXRFOHJnNUJtNmhH?= =?utf-8?B?WUVZeTQvMm9UTk14emZZMmZWMWZXNzZnUC9NNWtHZUdsZmdOaS9UMTQ5ZDdx?= =?utf-8?B?RFhzNWoyVTYxcWZyaUlacnoyVjIrVFhacGRCOHhjZmxyWXN5dGMwajhlMTcy?= =?utf-8?B?ci94WndPdjlzSW8rUTJDdEhIa1JrRTBNVFRvMDRvczl3bmlzcXJOR0VweGx2?= =?utf-8?B?YlFVeVJwQU5kVFYwYXpwRmo4WGxYaHNWeG1QNk5LY2d3cUliVDdXK3NGV2Yx?= =?utf-8?B?UnUwNVhITm5kTk1xaWdKT0tXTzJ6emh4UnZ0elpHNllDY1lVVDlrRzY0WU8z?= =?utf-8?B?eGxzdFJlODNFL29jK2N2TXRmcElkeHJidDVCMXRZUWR5Y1RTaDlCdGh1TXBD?= =?utf-8?B?VlIySi95bVB2ZWhBTm9IS3Nmc203VTFhRHNlaDVmbmNrbi8zaTN0RHMyQU9C?= =?utf-8?B?WXBOWHlEcXB3UUVZSzM0MHFYVzhVNk9mSEtyRHduS3ZUMEFvS1lpQkduNm9r?= =?utf-8?B?d2xuWi95RXNzT2I3cVIrWnRDY0xzU2VOYlNqSE1STzZ4RkFTc3kwd0duNFZF?= =?utf-8?B?TXUrckJESE4zSlQ4OFNNdmF4UG1iM1BXbHc2MjFuckVBaUlLa0xnRFAvV0xl?= =?utf-8?B?d2drcnFXM0xTWHVyb08xNWhVVlhKME5YaG9ySjZJb0RacGszOWZwNDd6NUt6?= =?utf-8?B?UDVDQisrMk10eDBlNUV6aW5paDl0YmpXbklIL0VIYU01SEVtNmpmNm4yV1g4?= =?utf-8?B?SThpbTlEcEJrSm1rR0ZHMURoeDRYbjZ2dkJMQ1RsY1NvaGh5KzdVZ2doRlVZ?= =?utf-8?B?OU03aUp4QnZYNk0rbjNmck54Mnl3QkthMG5JaXVZeUplOTRFSk90Qzg1Yk41?= =?utf-8?B?S0RzNCtsdG5XK3Q4enRUU1QzWTNsU0xYZXMxV2plMzY1MjN6a1Z1MnovbXlB?= =?utf-8?B?eGJoQVN3YmlWUkpsSURTd0NqLzQ5dXFabmlyd25qM05JUUtBd0dINnE5TVpr?= =?utf-8?B?dENiV0xXR0NRUE55aWFXZDltZmk3eGVScmZWZlhqWFRCMUx0RGMzSjgrM201?= =?utf-8?B?dHdDaWhGbXU0Z25pQ0tZL3ovbUxNeklMYVVzc3J1WStUeWdTRFBLUlBTSFZn?= =?utf-8?B?OW5yNjA0WUpLMW1KUTE4eUNTSmd5SDE0N2ZBM1RJdlQvTGpNd1BpQ3lMelNj?= =?utf-8?B?Zm5wZ2Nkc1o0RGpIWTNJa3RaMUdySWs5akRESHZqTnZOZ05MTENLcnp0bW9H?= =?utf-8?B?SjhDc0hPSUU2bjB0Q1p5UzFKL3ZxR3JqTTkyN0ZOdXZ5T0VpSlI1c1VHYm9J?= =?utf-8?B?RXBuMDQ1MldNZlFJTmFQaDl3N095ZEVzUG1JTGZSTndvOWg1UDIwd0poS05p?= =?utf-8?B?ejVrbnROT2d1bUU2MUp1YTNKZllHSlNuOGZJcVBlY2tZUkQ2dGZjOFQ0VUc2?= =?utf-8?B?dWI1UXpOVjlZL29JdXhXTWluZTZxYmhKeS9qbzhSM3EvZUpwSlBxQ0p3aWky?= =?utf-8?B?dUlvL2VtU1hPbll0WXRPTUJqWDFpVzNSWWdUelpUVVVzV3IyWkxnSmQ5Q0RK?= =?utf-8?B?eTlkZFFNd3JNNUtpczRONjFoNkp0RllaSXVsZCtXZlk2SVZPN09aaWZqRVE0?= =?utf-8?B?R3dkdHVjWnkyS2VTUFFUUzFUbHhRdWppQzVTZG54U0E0ZDNsdjd4Qmk3OXJv?= =?utf-8?B?Y0dESyt1WUhaUEIrR0Ezby9HcWhCejcxcEMxSWRzMkxzMGJSKzd0czQzZW5n?= =?utf-8?B?aWhvTVlrQjdGRjNEVkNKK0lwMS9BMkNJWTAxc0VZM1NmVUtLcU9FNWJMTnV3?= =?utf-8?Q?WC15g8AtCcgQzddM=3D?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac078409-15cb-4237-906f-08de60155b91 X-MS-Exchange-CrossTenant-AuthSource: YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2026 15:36:38.1381 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AJfkLK6U0slDmoHXtn2EIr7r0ZSqrCtpdVlUNlubyLwCtEIuMWCSLsod7OHieY5nyaTqYRDTc1lhF7ZKIrTdxUIlFbb0qLrIMIHGSlxOco4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB8161 On 2026-01-29 16:20, Thomas Gleixner wrote: [...] > > -static void mm_cid_fixup_tasks_to_cpus(void) > +static void mm_cid_do_fixup_tasks_to_cpus(struct mm_struct *mm) > { > - struct mm_struct *mm = current->mm; > struct task_struct *p, *t; > unsigned int users; > > @@ -10590,6 +10598,15 @@ static void mm_cid_fixup_tasks_to_cpus(v > } > } > > +static void mm_cid_fixup_tasks_to_cpus(void) > +{ > + struct mm_struct *mm = current->mm; > + > + mm_cid_do_fixup_tasks_to_cpus(mm); > + /* Clear the transition bit in the mode */ > + WRITE_ONCE(mm->mm_cid.mode, MM_CID_ONCPU); I'm missing something here. Why not just move this write once to the end of cid_fixup_tasks_to_cpus ? Why the "do" wrapper that has a single caller ? Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com