From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 550FB30507B for ; Thu, 20 Nov 2025 13:23:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763644983; cv=none; b=AHO1CdmMOFScJXFgG9igjR/wj0AX8yReKMM2oH5s3b4WoC/awF1p3WgwAj8wlTh8MXY5TJYksvlCgj0fOzpB+ctxf/D3PVjbfpOUImmBJgl/uto0lxu8ura67IceGX4bsSZ10liy0ecCHNSgWfPwOc0va62k7YLWYeh3/aIgZgQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763644983; c=relaxed/simple; bh=9qtG9CkAZRsb3wsOb/RQUJ+xeL9HlwdjmU6wDSHWlxw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=G7vzbcVTyCt/metF6GnPdJaV/ncOQgrUy50WK2EKEoCDTLfP3tpcBEaFKMDVY+n3saKkyD3RSm0ZuEpDPLPjYTCro9ClLqyCr3DTZpuNKQicrbz4uMILG7BhAwcNaxEJZIboh2H02ArlKmxdsFRGryJ5Ix5kvuzLoUP5eK8ZoNw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GePUVYiO; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=pDh7AOtn; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GePUVYiO"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="pDh7AOtn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763644979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g9kLgsM1a2i43i4Ut85isBlu2SYExf3MkKcU6sJyq0M=; b=GePUVYiOzsUNe+M1Ka0w4cuxb3MTXqoYYp0oQNI+czHa+pI8ZjEjkRfJ6dBtCSF4+2SKJF Y1mJKD9WL9nwJL+T2SM/lcSbZUKOx83wZriRrOEifgT/KVfE/Uh8lm1Hse/fA5tk4jsrWx LSWt4NhW4jlgtUmCW52wEh46Vt+9+ZQ= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-331-wTguiYiBMmWvIhYrnpvDbA-1; Thu, 20 Nov 2025 08:22:57 -0500 X-MC-Unique: wTguiYiBMmWvIhYrnpvDbA-1 X-Mimecast-MFC-AGG-ID: wTguiYiBMmWvIhYrnpvDbA_1763644977 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8b2e41884a0so290598185a.1 for ; Thu, 20 Nov 2025 05:22:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1763644977; x=1764249777; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=g9kLgsM1a2i43i4Ut85isBlu2SYExf3MkKcU6sJyq0M=; b=pDh7AOtnyuWzhnp4R5VrT/G9EYNotPeeonPDo0ZfujKwngO9IGnwNvcVUZa/3nTnUO VyKuz1mQdoo5hExyLd2hbshMa981zNeZDrWvCgMbeYscq/DLIl0S5p5U0Rv6EJlX1Hvv IcWw2/oaow6J797MgbUl+riNQdjv6v77pr3aZ7Zo62NBQSqIT94QJMNpPpFDb2VHqOyo 77kcdbqp+nNZm34WWRWWHFDzlhw8V8YQT5IredXSljW9JCE/UjvZVOq0hQTyDXmjQ2BX DcCXLoWLrLiKlES5nPlO0rOZlgqny4ndu8NaV6UeBbvFSfqpck/GQ57jMtgk2oNZF4A5 sPPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763644977; x=1764249777; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=g9kLgsM1a2i43i4Ut85isBlu2SYExf3MkKcU6sJyq0M=; b=rscda9tazkToOpG2rpVjWiuTc6HX0WaV19TqPs6GOHqGw7tb8h1VW/soF/dLhU2vqa EAH7waqUL3RBkiN+eOIPmmlrXNljXix0z9P9CZh+IRXlfuYjrTE2Twv513BEWzrbjTr1 pK2w8V8zhYX8IOSQZBNGM1FcBz79YVxfVmLYhB0JiJ0eULOqF/ZXaR8q6g9S91SXC8r7 aiqGarXvHIRd8209UggnLAGhYuHZK3OAhqz6a6c4hblF2Faz2AYy4vF6d8zeKQ1J0fNw eJ0cgsd+bZnyRFx173d+wLsYEsAwC88lPKREhL+V16zOo82iXimIm5kXeCuv2YHHr05F rtyA== X-Gm-Message-State: AOJu0YzDS94IVMHQOCfjlOZDSXzRZXTI8CbQssnOYQAEcSGTZdC9q7qu sL/6zbDEejr3mqaG0y1k9GuseBRUsMlLOJTLler8VVpxb7trBAdZ7DbYokN0Krfw3kuoVQ32zlb rXQE7ZybEtcydVlf7ho3KhaMy7sL3Za8F2jv/QVp0MW6XhFCSuzf7OJDt33qhDKwm7A== X-Gm-Gg: ASbGnctWnVBVEuWGXMmU6WUjxNoAQmEiMowRGiRMN5ay8mtnYL22PXMchpYplwtpYPo PcAmrT/+A7mAlBlA68DjGweTs3CnCwOBbgAevLNsjoG18/Gbmv3x+jI9gfZbQOybHDMK2N/HXHO 2ehTcw98z6Te/0LRRWzBKkVk6O/CZtmsa93C3sztTpZgK7AMbEU+6zDzPbch+wrBn2M47k79mSW eq0lz4WgjoVGOTbPGiodnqIP09upcQt02paQvawKrIxzpp4qv1ARY9HBULESjgoWhiBaaZoYVpc kCortfMADSZ7PuQ9PJH9xiQTaWkSWMCdmNZVrPlXwbr7gUMCgVw9kz9WhBONsKr9f6RypAMP5ZK Qpg/9bCGCLg== X-Received: by 2002:a05:620a:2683:b0:8a3:87ef:9245 with SMTP id af79cd13be357-8b3274afdbemr395775885a.85.1763644976979; Thu, 20 Nov 2025 05:22:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IEc8oOJzkvKVhkAexfoiiZeXl3zNtHS/KFcZaK9jBanaZpFkfX4yBSJ0FsDLWlpVVKvZo4mUw== X-Received: by 2002:a05:620a:2683:b0:8a3:87ef:9245 with SMTP id af79cd13be357-8b3274afdbemr395773085a.85.1763644976615; Thu, 20 Nov 2025 05:22:56 -0800 (PST) Received: from [10.26.1.94] ([66.187.232.136]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8846e46a4b2sm16914256d6.19.2025.11.20.05.22.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Nov 2025 05:22:56 -0800 (PST) Message-ID: <54ffe25e-c697-4639-b405-af50416764c8@redhat.com> Date: Thu, 20 Nov 2025 08:22:55 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v2] intel_th: core: fix null pointer dereference in intel_th_irq To: Markus Elfring Cc: LKML , kernel-janitors@vger.kernel.org, Alexander Shishkin References: <20251118212106.541728-1-darcari@redhat.com> <32755d36-050e-413f-93b9-55d8306c165d@web.de> <0d5bad33-49ed-4531-b399-e548d3dfce66@web.de> Content-Language: en-US From: David Arcari In-Reply-To: <0d5bad33-49ed-4531-b399-e548d3dfce66@web.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/20/25 8:07 AM, Markus Elfring wrote: > …>>> the same array.  This can be fixed by disabling interrupts >>>> during the call to intel_th_output_enable(). >>> >>> 1. Would another imperative wording become helpful for an improved change description? >>>     https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc6#n94 >> >> I feel like the description explains the problem well. > > Perhaps? > > >> However, do you have alternate wording you would like to suggest? > > Under which circumstances would you get into the mood to convert the wording approach > “can be fixed by” into an imperative one? I see. I will make that change if a v3 is in order. Naturally, I'd like to hear back from Alexander before putting more effort into this. Best, -DA > > Regards, > Markus >