From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754431AbbCMLTq (ORCPT ); Fri, 13 Mar 2015 07:19:46 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:59090 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754068AbbCMLTm (ORCPT ); Fri, 13 Mar 2015 07:19:42 -0400 X-AuditID: cbfee68d-f79296d000004278-22-5502c7cb2585 Message-id: <5502C7CB.3010504@samsung.com> Date: Fri, 13 Mar 2015 20:19:39 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-version: 1.0 To: Doug Anderson , Jaehoon Chung , Seungwon Jeon , Ulf Hansson Cc: Addy Ke , Heiko Stuebner , Andrew Bresticker , linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, chris@printf.net, linux-rockchip@lists.infradead.org, Alim Akhtar , Sonny Rao , javier.martinez@collabora.co.uk, linux-arm-kernel@lists.infradead.org, Alexandru Stan Subject: Re: [PATCH] mmc: dw_mmc: Add a timeout for sending CMD11 References: <1425943101-11976-1-git-send-email-dianders@chromium.org> In-reply-to: <1425943101-11976-1-git-send-email-dianders@chromium.org> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLIsWRmVeSWpSXmKPExsWyRsSkUPfMcaZQg+VnmCxWvv/LaLHs/3cm iwfztrFZNLyYxGox4fJ2Rouzyw6yWfx/9JrV4ujvAosbv9pYLTY9vsZqcXnXHDaLI//7GS0+ PfjPbPHkzExGiw/3LzJbHF8b7iDgMbvhIovH3+fXWTzuXNvD5rF5Sb3HjVcLmTz+ztrP4tG3 ZRWjx/Zr85g9Pm+SC+CM4rJJSc3JLEst0rdL4MrY9fEMY8EHiYo3x9MbGG8LdzFyckgImEhc 2LCMFcIWk7hwbz0biC0ksJRRYtW6DJiavdsXsEDEpzNK/Fvs2MXIBWS/ZpR4df48I0iCV0BL 4v/jr8wgNouAqkTz/W1gQ9kEdCS2fzvOBGKLCoRJTLz5mBWiXlDix+R7YENFBBYySjzrCQWx mQUWMkus6VACsYUFHCVeHD7IBLHYVaLxyyKwXZwCbhK9by8CHcoBVK8ncf+iFkSrvMTmNW+Z QW6TEFjJIXF51nyoewQkvk0+xAJSLyEgK7HpADPEX5ISB1fcYJnAKDYLyUWzEKbOQjJ1ASPz KkbR1ILkguKk9CJDveLE3OLSvHS95PzcTYzAWD/971nvDsbbB6wPMQpwMCrx8HZUMYUKsSaW FVfmHmI0BTpiIrOUaHI+MKHklcQbGpsZWZiamBobmVuaKYnzKkr9DBYSSE8sSc1OTS1ILYov Ks1JLT7EyMTBKdXAKMK7IX5urpjF30er5h7+OoO3P+azeOPSYweuPvwipRUj27ajsu2arrve pYR+p6fBXev1jnzeu8j905HqJvb+gA/zPGstcuWafA4tnjjJLb8gL6Hy09rTidk9qmfOyeiy xso5raqxtVe8M2+uB3NZ/tzrlpU8+86I3vl/SEnqwLJPO/6LbX4/WYmlOCPRUIu5qDgRAE34 H87wAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBKsWRmVeSWpSXmKPExsVy+t9jQd3Tx5lCDXbtMrVY+f4vo8Wy/9+Z LB7M28Zm0fBiEqvFhMvbGS3OLjvIZvH/0WtWi6O/Cyxu/Gpjtdj0+BqrxeVdc9gsjvzvZ7T4 9OA/s8WTMzMZLT7cv8hscXxtuIOAx+yGiywef59fZ/G4c20Pm8fmJfUeN14tZPL4O2s/i0ff llWMHtuvzWP2+LxJLoAzqoHRJiM1MSW1SCE1Lzk/JTMv3VbJOzjeOd7UzMBQ19DSwlxJIS8x N9VWycUnQNctMwfoCyWFssScUqBQQGJxsZK+HaYJoSFuuhYwjRG6viFBcD1GBmggYQ1jxq6P ZxgLPkhUvDme3sB4W7iLkZNDQsBEYu/2BSwQtpjEhXvr2UBsIYHpjBL/Fjt2MXIB2a8ZJV6d P88IkuAV0JL4//grM4jNIqAq0Xx/GyuIzSagI7H923EmEFtUIExi4s3HrBD1ghI/Jt8DWyAi sJBR4llPKIjNLLCQWWJNhxKILSzgKPHi8EEmiMWuEo1fFoHt4hRwk+h9exHoIA6gej2J+xe1 IFrlJTavecs8gVFgFpINsxCqZiGpWsDIvIpRNLUguaA4KT3XUK84Mbe4NC9dLzk/dxMjOJU8 k9rBuLLB4hCjAAejEg9vRxVTqBBrYllxZe4hRgkOZiUR3tjVQCHelMTKqtSi/Pii0pzU4kOM pkD/T2SWEk3OB6a5vJJ4Q2MTMyNLI3NDCyNjcyVxXiX7thAhgfTEktTs1NSC1CKYPiYOTqkG xomzr6ouvvgu5mebZnynBvvM5POq1wrjdFUvLee8++5o1qree0q/l7VrTOra1/TtwJXdx30W +toqr9s753D2+lU58xauF/hUpTdVI+fpn4i84/5reCQsDDVkLqbPK+Sw5hAKzl63WOvOk7w9 uy59XJu841WOS/ib6a4Rn40UOx12LTFknTjl+mUlluKMREMt5qLiRACs/uJ+OwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Doug. This patch is a right process. Just i wonder something. On 03/10/2015 08:18 AM, Doug Anderson wrote: > In the Designware databook's description of the "Voltage Switch Normal > Scenario" it instructs us to set a timer and fail the voltage change > if we don't see the voltage change interrupt within 2ms. Let's > implement that. Without implementing this I have often been able to > reproduce a hang while trying to send CMD11 on an rk3288-based board > while constantly ejecting and inserting UHS cards. > > Signed-off-by: Doug Anderson > --- > drivers/mmc/host/dw_mmc.c | 26 ++++++++++++++++++++++++++ > include/linux/mmc/dw_mmc.h | 2 ++ > 2 files changed, 28 insertions(+) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 47dfd0e..d259662 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -1020,6 +1020,15 @@ static void __dw_mci_start_request(struct dw_mci *host, > > dw_mci_start_command(host, cmd, cmdflags); > > + if (cmd->opcode == SD_SWITCH_VOLTAGE) { > + /* > + * Databook says to fail after 2ms w/ no response; give an > + * extra jiffy just in case we're about to roll over. > + */ > + mod_timer(&host->cmd11_timer, > + jiffies + msecs_to_jiffies(2) + 1); What's "plus one"? > + } > + > if (mrq->stop) > host->stop_cmdr = dw_mci_prepare_command(slot->mmc, mrq->stop); > else > @@ -2158,6 +2167,8 @@ static irqreturn_t dw_mci_interrupt(int irq, void *dev_id) > /* Check volt switch first, since it can look like an error */ > if ((host->state == STATE_SENDING_CMD11) && > (pending & SDMMC_INT_VOLT_SWITCH)) { > + del_timer(&host->cmd11_timer); > + > mci_writel(host, RINTSTS, SDMMC_INT_VOLT_SWITCH); > pending &= ~SDMMC_INT_VOLT_SWITCH; > dw_mci_cmd_interrupt(host, pending); > @@ -2571,6 +2582,18 @@ ciu_out: > return ret; > } > > +static void dw_mci_cmd11_timer(unsigned long arg) > +{ > + struct dw_mci *host = (struct dw_mci *)arg; > + > + if (host->state != STATE_SENDING_CMD11) > + dev_info(host->dev, "Unexpected CMD11 timeout\n"); If Unexpected CMD11 timeout, can it do just" return"? Well, I think Unexpected CMD11 timeout is an rare case. Best Regards, Jaehoon Chung > + > + host->cmd_status = SDMMC_INT_RTO; > + set_bit(EVENT_CMD_COMPLETE, &host->pending_events); > + tasklet_schedule(&host->tasklet); > +} > + > #ifdef CONFIG_OF > static struct dw_mci_of_quirks { > char *quirk; > @@ -2745,6 +2768,9 @@ int dw_mci_probe(struct dw_mci *host) > } > } > > + setup_timer(&host->cmd11_timer, > + dw_mci_cmd11_timer, (unsigned long)host); > + > host->quirks = host->pdata->quirks; > > spin_lock_init(&host->lock); > diff --git a/include/linux/mmc/dw_mmc.h b/include/linux/mmc/dw_mmc.h > index 471fb31..9efc567 100644 > --- a/include/linux/mmc/dw_mmc.h > +++ b/include/linux/mmc/dw_mmc.h > @@ -202,6 +202,8 @@ struct dw_mci { > int irq; > > int sdio_id0; > + > + struct timer_list cmd11_timer; > }; > > /* DMA ops for Internal/External DMAC interface */ >