From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757204AbbCMQHp (ORCPT ); Fri, 13 Mar 2015 12:07:45 -0400 Received: from lists.s-osg.org ([54.187.51.154]:39945 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755823AbbCMQHm (ORCPT ); Fri, 13 Mar 2015 12:07:42 -0400 Message-ID: <55030B4C.1080000@osg.samsung.com> Date: Fri, 13 Mar 2015 10:07:40 -0600 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Andrey Vagin , linux-kernel@vger.kernel.org, Shuah Khan Subject: Re: [PATCH] selftests/exec: take into account that zero is a success code References: <1426262228-14688-1-git-send-email-avagin@openvz.org> In-Reply-To: <1426262228-14688-1-git-send-email-avagin@openvz.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/13/2015 09:57 AM, Andrey Vagin wrote: > Cc: Shuah Khan > Signed-off-by: Andrey Vagin Andrey, Please add a meaningful commit log for this patch and resend. -- Shuah > --- > tools/testing/selftests/exec/execveat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/exec/execveat.c b/tools/testing/selftests/exec/execveat.c > index e238c95..6747a3f 100644 > --- a/tools/testing/selftests/exec/execveat.c > +++ b/tools/testing/selftests/exec/execveat.c > @@ -47,7 +47,7 @@ static int _check_execveat_fail(int fd, const char *path, int flags, > fd, path?:"(null)", flags, errno_str); > rc = execveat_(fd, path, argv, envp, flags); > > - if (rc > 0) { > + if (rc >= 0) { > printf("[FAIL] (unexpected success from execveat(2))\n"); > return 1; > } > -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978