From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753215AbbCNCQz (ORCPT ); Fri, 13 Mar 2015 22:16:55 -0400 Received: from www62.your-server.de ([213.133.104.62]:58486 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750781AbbCNCQw (ORCPT ); Fri, 13 Mar 2015 22:16:52 -0400 Message-ID: <55039A0D.20000@iogearbox.net> Date: Sat, 14 Mar 2015 03:16:45 +0100 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Alexei Starovoitov , "David S. Miller" CC: Thomas Graf , linux-api@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 net-next 1/2] bpf: allow extended BPF programs access skb fields References: <1426273064-4837-1-git-send-email-ast@plumgrid.com> <1426273064-4837-2-git-send-email-ast@plumgrid.com> <550392F7.9040308@iogearbox.net> <550397B0.5070409@iogearbox.net> <5503981C.6000801@plumgrid.com> In-Reply-To: <5503981C.6000801@plumgrid.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/14/2015 03:08 AM, Alexei Starovoitov wrote: > On 3/13/15 7:06 PM, Daniel Borkmann wrote: >> On 03/14/2015 02:46 AM, Daniel Borkmann wrote: >> ... >>> Previously, it was much more consistent, which I like better. And only >>> because of the simple BUILD_BUG_ON()? :/ >> >> Alternative is to move all of them into a central place, something like >> in twsk_build_assert() or __mld2_query_bugs[]. > > nope. that defeats the purpose of bug_on. Well, it doesn't. ;) It throws a build error thus the user is forced to investigate that further.