From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760127AbcAKWvD (ORCPT ); Mon, 11 Jan 2016 17:51:03 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:60871 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752518AbcAKWvA (ORCPT ); Mon, 11 Jan 2016 17:51:00 -0500 From: "Rafael J. Wysocki" To: Guenter Roeck , Fabio Estevam Cc: Tony Lindgren , "Rafael J. Wysocki" , Russell King , Tomeu Vizoso , Kevin Hilman , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: arm qemu boot failures in -next due to 'PM / Domains: add setter for dev.pm_domain' Date: Mon, 11 Jan 2016 23:51:31 +0100 Message-ID: <5504959.X4Psnlei2y@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.4.0; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160111204819.GA10522@roeck-us.net> References: <5693EB8A.40802@roeck-us.net> <20160111204819.GA10522@roeck-us.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, January 11, 2016 12:48:19 PM Guenter Roeck wrote: > On Mon, Jan 11, 2016 at 06:14:31PM -0200, Fabio Estevam wrote: > > [Adding Rafael] > > > > On Mon, Jan 11, 2016 at 4:55 PM, Tony Lindgren wrote: > > > > >> I see 6 out of 24 arm qemu tests failing in next-20160111. Bisect points > > >> to commit 989561de9b51 ("PM / Domains: add setter for dev.pm_domain"). > > >> Failures are silent - there is no output on the console. > > >> Affected tests are > > >> > > >> arm:beagle:multi_v7_defconfig:omap3-beagle > > >> arm:beaglexm:multi_v7_defconfig:omap3-beagle-xm > > >> arm:overo:multi_v7_defconfig:omap3-overo-tobi > > >> arm:beagle:omap2plus_defconfig:omap3-beagle > > >> arm:beaglexm:omap2plus_defconfig:omap3-beagle-xm > > >> arm:overo:omap2plus_defconfig:omap3-overo-tobi > > >> > > >> For details please see the 'next' column at http://server.roeck-us.net:8010/builders. > > >> > > >> Reverting the offending commit fixes the problems. > > >> > > >> Please let me know if there is anything I can do to help tracking down the problem. > > > > > > The following fixes the booting, but I wonder if it's a > > > proper fix? > > > > > > --- a/drivers/base/power/common.c > > > +++ b/drivers/base/power/common.c > > > @@ -145,9 +145,10 @@ void dev_pm_domain_set(struct device *dev, struct dev_pm_domain *pd) > > > { > > > if (dev->pm_domain == pd) > > > return; > > > - > > > - WARN(device_is_bound(dev), > > > - "PM domains can only be changed for unbound devices\n"); > > > + if (device_is_registered(dev)) { > > > + WARN(device_is_bound(dev), > > > + "PM domains can only be changed for unbound devices\n"); > > > + } > > > dev->pm_domain = pd; > > > device_pm_check_callbacks(dev); > > > > Commit 989561de9b51 ("PM / Domains: add setter for dev.pm_domain") > > causes issues for me after doing a 'reboot' command. > > > > Rafael proposed a patch which fixed the 'reboot' problem: > > http://www.spinics.net/lists/arm-kernel/msg473562.html > > Looks like a different problem. Yes, it is a different problem. Fabio, thanks for CCing me. Thanks, Rafael