From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753906AbbCPMVO (ORCPT ); Mon, 16 Mar 2015 08:21:14 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:31196 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751732AbbCPMVL (ORCPT ); Mon, 16 Mar 2015 08:21:11 -0400 X-AuditID: cbfee68e-f79b46d000002b74-3a-5506cab411d7 Message-id: <5506CAB4.7000204@samsung.com> Date: Mon, 16 Mar 2015 21:21:08 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Jaewon Kim Cc: Kamil Debski , Kukjin Kim , Kishon Vijay Abraham I , Vivek Gautam , Felipe Balbi , Inki Dae , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] phy: exynos5-usbdrd: Add to support for Exynos5433 SoC References: <1426155073-22356-1-git-send-email-jaewon02.kim@samsung.com> In-reply-to: <1426155073-22356-1-git-send-email-jaewon02.kim@samsung.com> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFIsWRmVeSWpSXmKPExsWyRsSkUHfLKbZQg6YdJhYH79dbtF05yG4x 6f4EFosdDUdYLX68vsBm0f/4NbPFhac9bBaXd81hs5hxfh+TxaJlrcwOXB6bVnWyefRtWcXo cfzGdiaPz5vkAliiuGxSUnMyy1KL9O0SuDKu/fjBWtAlW3F8Yxd7A+ND8S5GTg4JAROJ7+ca mSFsMYkL99azgdhCAksZJQ5PVIGp2XjhNWMXIxdQfDqjxOfdx5ggil4zSsz/agxi8wpoSezr 7WbvYuTgYBFQldg8RQokzAYU3v/iBthMUYEwiZXTr7BAlAtK/Jh8D8wWEdCUOHLkCNh8ZoGd TBJbbjwEO0hYwFvi8LyJ7BC7PCSu9M9kBpnPKeAp8fCNOUiYWUBHYn/rNDYIW15i85q3zCBz JATusUu82LUB7E4WAQGJb5MPsYD0SgjISmw6APWvpMTBFTdYJjCKzUJy0iwkY2chGbuAkXkV o2hqQXJBcVJ6kZFecWJucWleul5yfu4mRmAUnv73rG8H480D1ocYBTgYlXh4V0ixhQqxJpYV V+YeYjQFumIis5Rocj4w1vNK4g2NzYwsTE1MjY3MLc2UxHkTpH4GCwmkJ5akZqemFqQWxReV 5qQWH2Jk4uCUamC0v+i9tKE5TG76zrdTc88U3b3FzFGxNtB1CYv+4k1rq8TuzlnhvJdH/1jm LK88VbXJPDtmdSgfZJM1n7Vha860+Q9ZA32/tM8uu/N439Irome3l6lwps/Wl5e/dzrt0e0v n617Ov2reV9MzVlyuJLniITuSkGzZUsDcn4vvFg11VrkrGatN8chJZbijERDLeai4kQAK2VL Yr0CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKIsWRmVeSWpSXmKPExsVy+t9jQd0tp9hCDV7t0rY4eL/eou3KQXaL SfcnsFjsaDjCavHj9QU2i/7Hr5ktLjztYbO4vGsOm8WM8/uYLBYta2V24PLYtKqTzaNvyypG j+M3tjN5fN4kF8AS1cBok5GamJJapJCal5yfkpmXbqvkHRzvHG9qZmCoa2hpYa6kkJeYm2qr 5OIToOuWmQN0kJJCWWJOKVAoILG4WEnfDtOE0BA3XQuYxghd35AguB4jAzSQsIYx49qPH6wF XbIVxzd2sTcwPhTvYuTkkBAwkdh44TUjhC0mceHeerYuRi4OIYHpjBKfdx9jAkkICbxmlJj/ 1RjE5hXQktjX283excjBwSKgKrF5ihRImA0ovP/FDTYQW1QgTGLl9CssEOWCEj8m3wOzRQQ0 JY4cOcIIMp9ZYCeTxJYbD5lBEsIC3hKH501kh9jlIXGlfyYzyHxOAU+Jh2/MQcLMAjoS+1un sUHY8hKb17xlnsAoMAvJillIymYhKVvAyLyKUTS1ILmgOCk910ivODG3uDQvXS85P3cTIzjK n0nvYFzVYHGIUYCDUYmHd4UUW6gQa2JZcWXuIUYJDmYlEd5PJ4FCvCmJlVWpRfnxRaU5qcWH GE2BATCRWUo0OR+YgPJK4g2NTcyMLI3MDS2MjM2VxHmV7NtChATSE0tSs1NTC1KLYPqYODil Ghi11j5/r3Gh8cofseQFu+P7tk3Uv7v1QbHk3n4mPeacJM1dO9XuGQYc7HESPMqSO/PUL5nM C9NvMzT1ayxSL7Q9oFS0R1SiPy36e15m+KPe5xzXL+9W7l8kx77u4zMlvb8vmSfeOFGv9OP7 pBdt34OzH+9Z4PXm1Z9JiU1OUyPKnu6XbOa7Vc2sxFKckWioxVxUnAgAbauTCwgDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/12/2015 07:11 PM, Jaewon Kim wrote: > This patch adds driver data to support for Exynos5433 SoC. > The Exynos5433 has one USB3.0 Host and USB3.0 DRD(Dual Role Device). > Exynos5433 is simplar to Eyxnos7 but Exynos5433 have > one more USB3.0 Host controller. > > Signed-off-by: Jaewon Kim > --- > .../devicetree/bindings/phy/samsung-phy.txt | 3 ++- > drivers/phy/phy-exynos5-usbdrd.c | 10 ++++++++++ > include/linux/mfd/syscon/exynos5-pmu.h | 3 +++ > 3 files changed, 15 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt b/Documentation/devicetree/bindings/phy/samsung-phy.txt > index 91e38cf..60c6f2a 100644 > --- a/Documentation/devicetree/bindings/phy/samsung-phy.txt > +++ b/Documentation/devicetree/bindings/phy/samsung-phy.txt > @@ -128,6 +128,7 @@ Required properties: > - compatible : Should be set to one of the following supported values: > - "samsung,exynos5250-usbdrd-phy" - for exynos5250 SoC, > - "samsung,exynos5420-usbdrd-phy" - for exynos5420 SoC. > + - "samsung,exynos5433-usbdrd-phy" - for exynos5433 SoC. > - "samsung,exynos7-usbdrd-phy" - for exynos7 SoC. > - reg : Register offset and length of USB DRD PHY register set; > - clocks: Clock IDs array as required by the controller > @@ -139,7 +140,7 @@ Required properties: > PHY operations, associated by phy name. It is used to > determine bit values for clock settings register. > For Exynos5420 this is given as 'sclk_usbphy30' in CMU. > - - optional clocks: Exynos7 SoC has now following additional > + - optional clocks: Exynos5433 & Exynos7 SoC has now following additional > gate clocks available: > - phy_pipe: for PIPE3 phy > - phy_utmi: for UTMI+ phy > diff --git a/drivers/phy/phy-exynos5-usbdrd.c b/drivers/phy/phy-exynos5-usbdrd.c > index 0437401..597e7dd 100644 > --- a/drivers/phy/phy-exynos5-usbdrd.c > +++ b/drivers/phy/phy-exynos5-usbdrd.c > @@ -624,6 +624,13 @@ static const struct exynos5_usbdrd_phy_drvdata exynos5250_usbdrd_phy = { > .has_common_clk_gate = true, > }; > > +static const struct exynos5_usbdrd_phy_drvdata exynos5433_usbdrd_phy = { > + .phy_cfg = phy_cfg_exynos5, > + .pmu_offset_usbdrd0_phy = EXYNOS5_USBDRD_PHY_CONTROL, > + .pmu_offset_usbdrd1_phy = EXYNOS5433_USBHOST30_PHY_CONTROL, > + .has_common_clk_gate = false, > +}; > + > static const struct exynos5_usbdrd_phy_drvdata exynos7_usbdrd_phy = { > .phy_cfg = phy_cfg_exynos5, > .pmu_offset_usbdrd0_phy = EXYNOS5_USBDRD_PHY_CONTROL, > @@ -638,6 +645,9 @@ static const struct of_device_id exynos5_usbdrd_phy_of_match[] = { > .compatible = "samsung,exynos5420-usbdrd-phy", > .data = &exynos5420_usbdrd_phy > }, { > + .compatible = "samsung,exynos5433-usbdrd-phy", > + .data = &exynos5433_usbdrd_phy > + }, { > .compatible = "samsung,exynos7-usbdrd-phy", > .data = &exynos7_usbdrd_phy > }, > diff --git a/include/linux/mfd/syscon/exynos5-pmu.h b/include/linux/mfd/syscon/exynos5-pmu.h > index 00ef24b..9352adc 100644 > --- a/include/linux/mfd/syscon/exynos5-pmu.h > +++ b/include/linux/mfd/syscon/exynos5-pmu.h > @@ -36,6 +36,9 @@ > #define EXYNOS5420_MTCADC_PHY_CONTROL (0x724) > #define EXYNOS5420_DPTX_PHY_CONTROL (0x728) > > +/* Exynos5433 specific register definitions */ > +#define EXYNOS5433_USBHOST30_PHY_CONTROL (0x728) > + > #define EXYNOS5_PHY_ENABLE BIT(0) > > #define EXYNOS5_MIPI_PHY_S_RESETN BIT(1) > I tested this patch for USB on Exynos5433-based board. Tested-by: Chanwoo Choi Thanks, Chanwoo Choi