From: Wang Nan <wangnan0@huawei.com>
To: Ingo Molnar <mingo@redhat.com>, Ingo Molnar <mingo@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>, <jolsa@kernel.org>,
<acme@kernel.org>, <lizefan@huawei.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 -tip] perf tools: fix building error for arm64.
Date: Thu, 19 Mar 2015 14:23:16 +0800 [thread overview]
Message-ID: <550A6B54.7080505@huawei.com> (raw)
In-Reply-To: <20150318071935.GT943@sejong>
Hi Ingo,
Could you please pick this patch for -tip tree? It fixes a bug which makes
arm64 -tip building failure.
Thank you.
On 2015/3/18 15:19, Namhyung Kim wrote:
> On Tue, Mar 17, 2015 at 01:29:47PM +0000, Wang Nan wrote:
>> Commit b11db6581beaccef8ae9a388ae96074aa5cc144f ("perf tools: Fix build
>> error on ARCH=i386/x86_64/sparc64") uses sed on ARCH, which triggers a
>> bug in sequence of sed expression, where 's/arm.*/arm/' will replace
>> 'arm64' to 'arm', causes arm64 building failure.
>>
>> This patch prevent 'arm64' to be mached for 'arm.*' case.
>>
>> Signed-off-by: Wang Nan <wangnan0@huawei.com>
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>
>
> Thanks,
> Namhyung
>
>
>> ---
>> v2 -> v3:
>> Make the 'arm.*' expression complete according to Jiri Olsa's suggestion.
>> ---
>> tools/perf/config/Makefile.arch | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/perf/config/Makefile.arch b/tools/perf/config/Makefile.arch
>> index e972057..e11fbd6 100644
>> --- a/tools/perf/config/Makefile.arch
>> +++ b/tools/perf/config/Makefile.arch
>> @@ -4,7 +4,7 @@ endif
>>
>> ARCH := $(shell echo $(ARCH) | sed -e s/i.86/x86/ -e s/x86_64/x86/ \
>> -e s/sun4u/sparc/ -e s/sparc64/sparc/ \
>> - -e s/arm.*/arm/ -e s/sa110/arm/ \
>> + -e /arm64/!s/arm.*/arm/ -e s/sa110/arm/ \
>> -e s/s390x/s390/ -e s/parisc64/parisc/ \
>> -e s/ppc.*/powerpc/ -e s/mips.*/mips/ \
>> -e s/sh[234].*/sh/ -e s/aarch64.*/arm64/ \
>> --
>> 1.8.3.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2015-03-19 6:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 11:33 [PATCH v2 " Wang Nan
2015-03-17 13:12 ` Jiri Olsa
2015-03-17 13:29 ` [PATCH v3 " Wang Nan
2015-03-18 7:19 ` Namhyung Kim
2015-03-19 6:23 ` Wang Nan [this message]
2015-03-19 14:02 ` Arnaldo Carvalho de Melo
2015-03-22 10:05 ` [tip:perf/core] perf tools: Fix " tip-bot for Wang Nan
2015-03-17 13:30 ` [PATCH v2 -tip] perf tools: fix " Wang Nan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550A6B54.7080505@huawei.com \
--to=wangnan0@huawei.com \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome