From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752004AbbCTSsY (ORCPT ); Fri, 20 Mar 2015 14:48:24 -0400 Received: from smtp-out-075.synserver.de ([212.40.185.75]:1084 "EHLO smtp-out-075.synserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751337AbbCTSpZ (ORCPT ); Fri, 20 Mar 2015 14:45:25 -0400 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 29648 Message-ID: <550C6ACF.3040902@metafoo.de> Date: Fri, 20 Mar 2015 19:45:35 +0100 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.5.0 MIME-Version: 1.0 To: Peter Meerwald , Antoine Tenart CC: sebastian.hesselbarth@gmail.com, jic23@kernel.org, knaack.h@gmx.de, zmxu@marvell.com, jszhang@marvell.com, yrliao@marvell.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] iio: adc: add support for Berlin References: <1426858565-31053-1-git-send-email-antoine.tenart@free-electrons.com> <1426858565-31053-2-git-send-email-antoine.tenart@free-electrons.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/20/2015 06:43 PM, Peter Meerwald wrote: > Hello Antoine, > >> This patch adds the support of the Berlin ADC, available on Berlin SoCs. >> This ADC has 8 channels available, with one connected to a temperature >> sensor. >> >> The particularity here, is that the temperature sensor connected to the >> ADC has its own registers, and both the ADC and the temperature sensor >> must be configured when using it. > > some quick comments inline below; > sometimes this refers to berlin, sometimes to berlin2? > > probably these regmap_read() / _write() pairs could be MACRO()'d away > somehow There is regmap_update_bits(), which does the read-modify-update cycle.