From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8347394788 for ; Mon, 20 Jul 2026 03:43:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784519040; cv=none; b=kVYvl4KEdQnsW/ryRZ0iDhufYn1P1JzN6YPH9lWt+sBcNuRCvryTEeklmAtby+iNnimkdQKPfeMqovsQnCm4QQ36tygEvZI3I1DDenuoOV9koJ9h7gpHwKuz/fVrn5nAWajJ2qmsNARbtvwWAryYMYHDeCjlR/Apd3wwrFhPnAU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784519040; c=relaxed/simple; bh=lkA0s6iwAeRPJSPxUGB5e5hM+vCSlA4PndnijjVFqJA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QvBkZ2MEHrxYiN8+QFqUEWLe27cZHKHwNfUHPmMKlI6PIsIb3ftQ3gLV3TtzeKkldqm3ZTzR+3AAQ6qXO7XQtmuwtHSbC8RrhpZ6/Ko43lGBUs4hOAXsvrwojDImuC0hJTV3Y56X4sXUPr5qJFy1Xfh6JaLX89HIksXlNsEvhpg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nby672tN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GzO03bvt; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nby672tN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GzO03bvt" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66JNsAZc564348 for ; Mon, 20 Jul 2026 03:43:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zbGvV7HPSAZ+/yd6PZ8nTYa5fEnloeHvv5FpQWxD+QI=; b=nby672tNvryi5a6B 2Ch42w/16HK3npzuuYLCMq4ONshteHUO7whefnAKXYJpOpa7aXcL1fyhD2H8G85L 239rI4XOKmT6kNiv4Z1xpwQI3MdxfgkSVp4WgpAPv7DhW2dCuehXu8hHJCtrl2WD ePKRQ+fkrhjXSlx1gZQucl4JW2NXDRUaK3Tg5vBs2YrxPm+qmYmt4FADsH6kxvxZ flxrZZoKHvCFFrCG31nhGrOFCnV7uBUT2I6CVhQSpjBdS1q6tIXeQK0vkJU8Ap3C GOiPcxlXYicWJ8/TDnp0WqIbwzrp+rk0yYWsGSPpC9n+eC9afMxSlG+Tl6QrGUNM yxCi9g== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fg2s7v51t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Jul 2026 03:43:58 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-ca124bf0189so2161810a12.0 for ; Sun, 19 Jul 2026 20:43:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784519037; x=1785123837; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=zbGvV7HPSAZ+/yd6PZ8nTYa5fEnloeHvv5FpQWxD+QI=; b=GzO03bvtiNlIaOs1uatFVcUXhYuhH3yRRgF7rL8IO4hWPu3gBVKNvu3XVrUG9Iw4Kb XOFqmPEV1JQD4msLrWQcg17m4o0LIG8z6/Irk1Q7tprO3TNk/8dB9yizpPBIZo52sEhI hgRSMBBBqEvXjyA16XU3NjoMf/rd1n4eMRFUjp1DycRf2rluZBEzLI/OdHY1KlLRFdv+ NcCmPa76eqe37SLLwLqvaaay2MeghScrTyCOhIsmsGgvbVwc3OCLXZAf9Nk4lal9hnih drtin76zKZ0cSPZSOU1qJqv3sDGcKzg+cmvGGEl0goNfVgH59o6kVXqHlTHsiyKz2Hc7 Im5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784519037; x=1785123837; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zbGvV7HPSAZ+/yd6PZ8nTYa5fEnloeHvv5FpQWxD+QI=; b=nmwAcjhTqOAHR8JngSnitUQEvIWf3/XqmzGlGfGoJeO6lLvQf40WjqKUAoaANQJZRe FVS6MOWIPog+MfwBQWDS/H2iPHbk7rrVDZ6Ay1y31Qwgv7cyWc9Uj3RyGAjoy1d7wzzR QKhNF85q3A5hssy8N2sLLEbO3ddoYIX5v6FTn3vpJ0pPhuoaYmLFMt95HXV7HgHp/NQF cf32FAT3vsehURrog5Y89nBdgDx7Y9Oop2WtVyvEx5jVOg3mcIHDf4Ll5Uui5v1YQDWm 5vygZ1oFXk0hxGnhOE4FsLa2YwDolgsfUkKKPiwPqwDWMrOlF874bU6C7tQdB/p9LL6q 9Syg== X-Forwarded-Encrypted: i=1; AHgh+Rok1rj3cj14a3v2OU1hz5biGtdX/x1H54oQczRqrzNgwl910vtqm8nXAZjnkLmLwfd3TMB+ivkbv4ifvCA=@vger.kernel.org X-Gm-Message-State: AOJu0YwD+hEocgxfChVeMPKgwWlJBSvVATUWLgXmlOR8qg390cuOt18e mnXvSMNoXJxD82MKsWwG2Zvp4yoi9eqFCh5qwSzWmM292+hX1VEc0Tm1qieSdSOa+wAO9lYBTh8 MqaFLfk+B7TcrxyGhnLENAvsvla3ajZS2YS9h5tqIvJ7gZK/JXbsCenKliWrmnsZQxw8= X-Gm-Gg: AfdE7cmRAItxoo2m12A10XBYpo6LjBMlizm52XMqwFmCoCB5PpGVkOpDEKyRaM5oZ85 31140gLHiVKp6xK+479/YrKp8CIpdOuytBjB4Ey9oQtiEGqvR/+u6fZGTzpUjzWrMpIVhmk2dOq cqHyphMsjjCZ7LBC/1973Za2FhBXhTwjEFzrsqQZ2Y52Ini5HX1yZz8klywCZNLSDJ/7YkKAJaH scjqBXRGIHqYokSW0QGFi8ZqOlRkwST3XNAEmIx+em0GCgkUgXLjzm1a0aMZabaCpy+QMNbebCB C3mHXHvcvtVwPVUcUvCCqoxHkKcL0oqstowFhfa6CZrs7KNTryrUFcW/ZJRmECOubVo5MtVLbMF vU2n3xMyYa4vX8Ww3CuWcZsnV3ELOaDsi0Nrr/i3tjkt1XqY= X-Received: by 2002:a17:90a:ec8b:b0:38d:ec55:7aa7 with SMTP id 98e67ed59e1d1-38e3d29a193mr18242459a91.19.1784519037492; Sun, 19 Jul 2026 20:43:57 -0700 (PDT) X-Received: by 2002:a17:90a:ec8b:b0:38d:ec55:7aa7 with SMTP id 98e67ed59e1d1-38e3d29a193mr18242444a91.19.1784519037034; Sun, 19 Jul 2026 20:43:57 -0700 (PDT) Received: from [192.168.126.30] ([157.51.77.155]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13ce29c2a48sm22695420c88.2.2026.07.19.20.43.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Jul 2026 20:43:56 -0700 (PDT) Message-ID: <550bad80-c4b3-4e24-9103-fac714862f97@oss.qualcomm.com> Date: Mon, 20 Jul 2026 09:13:50 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH ath-next] wifi: ath12k: Avoid buffer overread in ath12k_wmi_op_rx() To: Jeff Johnson , Jeff Johnson Cc: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260716-ath12k_wmi_op_rx-overread-v1-1-327a4b1c2372@oss.qualcomm.com> From: Rameshkumar Sundaram Content-Language: en-US In-Reply-To: <20260716-ath12k_wmi_op_rx-overread-v1-1-327a4b1c2372@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIwMDAzNyBTYWx0ZWRfXz4Q6FG9DqHQW 3AC9cLOH5W2DNOAASLF4RZhmLqC+/tsek1WcHtiLNtZJwyZ6i5AlGXWEDbEwUTTBFb8jegSXSfB K5rbDPGTfooREPagXTOSbiGLBMwAaU+VFprN/NbRdruzJSC7lVObd/UVnoK82kiJ4yhb0s+G6Zp Z1/ICOuhJt6mMaiWMi6xaB+/lC3YeRFYc5d6xlCTwE6uewnEga/mNDNp6kCZpdm++RfBD+P1ewN VQGDl/7h2n8xA0hx536iREBsu0jqX9MGzfLwcGKyKsQgB67vmKSyVq2+Ar/gxILrESEe+9Zbura 6GzA31fpe/qkFEnqx9T233vXTS9tdcbKuGd5uImZO/15WgWmrba0pLrHXbq6W1oWQEYtcBti//i P4/LRzp39IAeRVkpXdQxqYKqhEiaWxp/4l4dKj6RRxiOjOWDzlddZdhc1H+d06up8jwa2ULaREV NODmIoSeLOX29G8TR2w== X-Authority-Analysis: v=2.4 cv=eKsjSnp1 c=1 sm=1 tr=0 ts=6a5d997e cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=Jeo/xMHqCPjs4yjtUlRiiA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=ymRfW-ZP9UeHRcWsrQ4A:9 a=QEXdDO2ut3YA:10 a=ZXulRonScM0A:10 a=zZCYzV9kfG8A:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-ORIG-GUID: e648lMUAuZF-_SdnJ8onIeYuwFa_oA3b X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIwMDAzNyBTYWx0ZWRfX6egLgLt+Rn2h 380oqoUWN0mZujoLJSO2kjpOr7l5/c0O6SAnDv500VALzcU9APkd9DcFN41YehmltZ/Yl1EdzGG OvJ+7w4/CA2qy/XkKDJVO0LyR9pFfmw= X-Proofpoint-GUID: e648lMUAuZF-_SdnJ8onIeYuwFa_oA3b X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-19_08,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 impostorscore=0 malwarescore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607200037 On 7/17/2026 1:31 AM, Jeff Johnson wrote: > Currently, in ath12k_wmi_op_rx(), the firmware buffer is read without > first verifying that the buffer has enough data to hold a header. This > could result in a buffer overread. > > Update the logic to verify the buffer contains at least enough data to > hold a wmi_cmd_hdr before reading from the buffer. > > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3 > > Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices") > Assisted-by: Claude:claude-sonnet-4-6 > Signed-off-by: Jeff Johnson Reviewed-by: Rameshkumar Sundaram