From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E75DC1BD9DA; Wed, 30 Oct 2024 18:29:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.69.126.157 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730312981; cv=none; b=uaPflV4Qmi2YQ/VB44/oVZ322fKGNA0SRKd6pkWinvNZ+aJ+nl9oeL0Oqfbe/yZcplq2YAkAnrj6bZhfekTCDn4eN+ErD3uGurKaCemWdQnlrw6Q5VlWijdFuKyAaKlHzbD0gbw9Im9IvqhvMWvWaOqvbNdwjF9dstahyiRz+9Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730312981; c=relaxed/simple; bh=hYoR0YqPyvmejtGbq8Tt3Ox/H/FdThrUkxzrtIn2j1o=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=mURA4feeFiuoiAtJv2Qi1lelK0shtovRTw5NfrPzGLMbTAw6jvfYfouqiUan2XVexI0REZDvbEpOhShj8qrh44ehtASbfang2kFunPgGpVNSREASHxbfupG3f2NSWhs8sDwJLLJktwFYiMbF2epsHIWHjXHwcBih5t5nEcij++U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net; spf=pass smtp.mailfrom=weissschuh.net; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b=BBLI19gx; arc=none smtp.client-ip=159.69.126.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b="BBLI19gx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1730312976; bh=hYoR0YqPyvmejtGbq8Tt3Ox/H/FdThrUkxzrtIn2j1o=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=BBLI19gxXBoRT2hGgIYHeg3Xte60wUM5Ul+uXHj0WHDqcuuZtR36NZ1QmmJ6QTjYd 8LtSmmd3mYpk12vavBj3NbqIiQH4bwu50hnmv1OAjCRXDjq1ZV+l2JBeeSQP93lWAc 5DxY2HeydBl2DYgVZ9lSl1YrdFbYileezlNKhLtE= Date: Wed, 30 Oct 2024 12:29:31 -0600 (CST) From: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= To: Andy Shevchenko Cc: "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Len Brown Message-ID: <550e1dd5-91fb-44ae-bbd5-a10ce1b73ad4@weissschuh.net> In-Reply-To: References: <20241030162754.2110946-1-andriy.shevchenko@linux.intel.com> <63b16433-9f80-492f-9389-633a9852a223@weissschuh.net> Subject: Re: [PATCH v1 1/1] ACPI: battery: Check for error code from devm_mutex_init() call Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Correlation-ID: <550e1dd5-91fb-44ae-bbd5-a10ce1b73ad4@weissschuh.net> Oct 30, 2024 11:31:21 Andy Shevchenko : > On Wed, Oct 30, 2024 at 10:42:18AM -0600, Thomas Wei=C3=9Fschuh wrote: >> Oct 30, 2024 10:28:03 Andy Shevchenko : > > ... >> wouldn't it make sense to mark devm_mutex_init() as __must_check? > > It's macro, any idea how to do that for the macros? It should work on __devm_mutex_init(). I don't think the expression macro=C2=A0 in between should interfere. Unfortunately I can't test it myself right now.