mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Tudor Ambarus <tudor.ambarus@microchip.com>,
	<alexandre.belloni@bootlin.com>,
	<ludovic.desroches@microchip.com>
Cc: <claudiu.beznea@microchip.com>, <eugen.hristev@microchip.com>,
	<codrin.ciubotariu@microchip.com>, <emil.velikov@collabora.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ARM: dts: at91: sama5d4_xplained: Remove spi0 node
Date: Fri, 16 Jul 2021 21:15:08 +0200	[thread overview]
Message-ID: <550ed90d-d28f-d191-f00a-c073e133d063@microchip.com> (raw)
In-Reply-To: <20210716154739.835738-1-tudor.ambarus@microchip.com>

On 16/07/2021 at 17:47, Tudor Ambarus wrote:
> sama5d4_xplained has an optional on-board serial DataFlash (AT25DF321A),
> which does not come populated on board by default. Since the spi0 node
> does not have any child populated by default, thus no user on
> sama5d4_xplained, remove it. This avoids the following error in SPI NOR,
> which reads the values of the pulled downed lines, unrecognizing the flash:
> 
> spi-nor spi0.0: unrecognized JEDEC id bytes: 00 00 00 00 00 00
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Queued in at91-dt.

Regards,
   Nicolas

> ---
>   arch/arm/boot/dts/at91-sama5d4_xplained.dts | 10 ----------
>   1 file changed, 10 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> index 0b3ad1b580b8..046796c5b9b0 100644
> --- a/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> @@ -38,16 +38,6 @@ uart0: serial@f8004000 {
>   				status = "okay";
>   			};
>   
> -			spi0: spi@f8010000 {
> -				cs-gpios = <&pioC 3 0>, <0>, <0>, <0>;
> -				status = "okay";
> -				m25p80@0 {
> -					compatible = "atmel,at25df321a";
> -					spi-max-frequency = <50000000>;
> -					reg = <0>;
> -				};
> -			};
> -
>   			i2c0: i2c@f8014000 {
>   				i2c-digital-filter;
>   				status = "okay";
> 


-- 
Nicolas Ferre

      reply	other threads:[~2021-07-16 19:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-16 15:47 Tudor Ambarus
2021-07-16 19:15 ` Nicolas Ferre [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550ed90d-d28f-d191-f00a-c073e133d063@microchip.com \
    --to=nicolas.ferre@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=claudiu.beznea@microchip.com \
    --cc=codrin.ciubotariu@microchip.com \
    --cc=emil.velikov@collabora.com \
    --cc=eugen.hristev@microchip.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=tudor.ambarus@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome