From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752568AbbCYN2l (ORCPT ); Wed, 25 Mar 2015 09:28:41 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:55966 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752188AbbCYN2i (ORCPT ); Wed, 25 Mar 2015 09:28:38 -0400 Message-ID: <5512B7DE.60108@roeck-us.net> Date: Wed, 25 Mar 2015 06:27:58 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Lee Jones , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, wim@iguana.be, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, david.paris@st.com, a.zummo@towertech.it CC: kernel@stlinux.com Subject: Re: [PATCH v6 5/9] watchdog: bindings: Provide ST bindings for ST's LPC Watchdog device References: <1427189140-1935-1-git-send-email-lee.jones@linaro.org> <1427189140-1935-6-git-send-email-lee.jones@linaro.org> In-Reply-To: <1427189140-1935-6-git-send-email-lee.jones@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020206.5512B806.0101,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 9 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/24/2015 02:25 AM, Lee Jones wrote: > On current ST platforms the LPC controls a number of functions including > Watchdog and Real Time Clock. This patch provides the bindings used to > configure LPC in Watchdog mode. > > Signed-off-by: Lee Jones > --- > .../devicetree/bindings/watchdog/st_lpc_wdt.txt | 38 ++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt > > diff --git a/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt b/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt > new file mode 100644 > index 0000000..1bdf023 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt > @@ -0,0 +1,38 @@ > +STMicroelectronics Low Power Controller (LPC) - Watchdog > +======================================================== > + > +LPC currently supports Watchdog OR Real Time Clock functionality. > + > +[See: ../rtc/rtc-st-lpc.txt for RTC options] > + > +Required properties > + > +- compatible : Must be one of: "st,stih407-lpc" "st,stih416-lpc" > + "st,stih415-lpc" "st,stid127-lpc" > +- reg : LPC registers base address + size > +- interrupts : LPC interrupt line number and associated flags > +- clocks : Clock used by LPC device (See: ../clock/clock-bindings.txt) > +- st,lpc-mode : The LPC can run either one of two modes ST_LPC_MODE_RTC [0] or > + ST_LPC_MODE_WDT [1]. One (and only one) mode must be > + selected. > + > +Required properties [watchdog mode] > + > +- st,syscfg : Phandle to syscfg node used to enable watchdog and configure > + CPU reset type. > +- timeout-sec : Watchdog timeout in seconds > + > +Optional properties [watchdog mode] > + > +- st,warm-reset : If present reset type will be 'warm' - if not it will be cold > + > +Example: > + lpc@fde05000 { > + compatible = "st,stih416-lpc-watchdog"; Hi Lee, Just noticed: That doesn't match the above description, nor the match statement in the drivers. Guenter > + reg = <0xfde05000 0x1000>; > + clocks = <&clk_s_d3_flexgen CLK_LPC_0>; > + st,syscfg = <&syscfg_core>; > + timeout-sec = <120>; > + st,lpc-mode = ; > + st,warm-reset; > + }; >