From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: linux-kernel@vger.kernel.org, Stephen Boyd <sboyd@codeaurora.org>,
Mike Turquette <mturquette@linaro.org>,
Lee Jones <lee@kernel.org>,
Bryan Huntsman <bryanh@codeaurora.org>,
Ralf Baechle <ralf@linux-mips.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>
Subject: Re: [PATCH v3 1/1] clkdev: change prototype of clk_register_clkdev()
Date: Fri, 27 Mar 2015 11:23:35 +0100 [thread overview]
Message-ID: <55152FA7.80708@samsung.com> (raw)
In-Reply-To: <1426857509-6297-2-git-send-email-andriy.shevchenko@linux.intel.com>
Hello Andy,
On 20/03/15 14:18, Andy Shevchenko wrote:
> Since clk_register_clkdev() is exported for modules the caller should get a
> pointer to the allocated resources. Otherwise the memory leak is guaranteed on
> the ->remove() stage.
>
> Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> arch/arm/mach-msm/clock-pcom.c | 9 +++++----
> arch/arm/mach-vexpress/spc.c | 5 ++++-
> arch/mips/ath79/clock.c | 6 +++---
> drivers/clk/clk-bcm2835.c | 12 +++++++-----
> drivers/clk/clk-max-gen.c | 9 ++++-----
> drivers/clk/clk-xgene.c | 6 +++---
> drivers/clk/clkdev.c | 15 ++++++++++-----
> drivers/clk/samsung/clk-pll.c | 15 +++++++++------
> drivers/clk/samsung/clk-s3c2410-dclk.c | 22 +++++++++++----------
> drivers/clk/samsung/clk.c | 35 +++++++++++++++++++---------------
> include/linux/clkdev.h | 2 +-
> 11 files changed, 78 insertions(+), 58 deletions(-)
I tested this on exynos, for clk/samsung
Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
--
Thanks,
Sylwester
prev parent reply other threads:[~2015-03-27 10:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 13:18 [PATCH v3 0/1] clkdev: prevent potential memory leak when used in modules Andy Shevchenko
2015-03-20 13:18 ` [PATCH v3 1/1] clkdev: change prototype of clk_register_clkdev() Andy Shevchenko
2015-03-27 10:23 ` Sylwester Nawrocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55152FA7.80708@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bryanh@codeaurora.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=mturquette@linaro.org \
--cc=ralf@linux-mips.org \
--cc=sboyd@codeaurora.org \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome