From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752679AbbC2SRK (ORCPT <rfc822;w@1wt.eu>);
	Sun, 29 Mar 2015 14:17:10 -0400
Received: from a.ns.miles-group.at ([95.130.255.143]:65275 "EHLO radon.swed.at"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752264AbbC2SRI (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 29 Mar 2015 14:17:08 -0400
Message-ID: <5518419E.8010007@nod.at>
Date: Sun, 29 Mar 2015 20:17:02 +0200
From: Richard Weinberger <richard@nod.at>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Hajime Tazaki <tazaki@sfc.wide.ad.jp>, linux-arch@vger.kernel.org
CC: Arnd Bergmann <arnd@arndb.de>, Jonathan Corbet <corbet@lwn.net>,
        Jhristoph Lameter <cl@linux.com>, Jekka Enberg <penberg@kernel.org>,
        Javid Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Jndrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
        netdev@vger.kernel.org, linux-mm@kvack.org,
        Jeff Dike <jdike@addtoit.com>, Rusty Russell <rusty@rustcorp.com.au>,
        Mathieu Lacage <mathieu.lacage@gmail.com>,
        Christoph Paasch <christoph.paasch@gmail.com>
Subject: Re: [RFC PATCH 08/11] lib: other kernel glue layer code
References: <1427202642-1716-1-git-send-email-tazaki@sfc.wide.ad.jp> <1427202642-1716-9-git-send-email-tazaki@sfc.wide.ad.jp>
In-Reply-To: <1427202642-1716-9-git-send-email-tazaki@sfc.wide.ad.jp>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 24.03.2015 um 14:10 schrieb Hajime Tazaki:
> These files are used to provide the same function calls so that other
> network stack code keeps untouched.
> 
> Signed-off-by: Hajime Tazaki <tazaki@sfc.wide.ad.jp>
> Signed-off-by: Christoph Paasch <christoph.paasch@gmail.com>
> ---
>  arch/lib/cred.c     |  16 +++
>  arch/lib/dcache.c   |  93 +++++++++++++++
>  arch/lib/filemap.c  |  27 +++++
>  arch/lib/fs.c       | 287 ++++++++++++++++++++++++++++++++++++++++++++
>  arch/lib/glue.c     | 336 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  arch/lib/inode.c    | 146 +++++++++++++++++++++++
>  arch/lib/modules.c  |  36 ++++++
>  arch/lib/pid.c      |  29 +++++
>  arch/lib/print.c    |  56 +++++++++
>  arch/lib/proc.c     | 164 +++++++++++++++++++++++++
>  arch/lib/random.c   |  53 +++++++++
>  arch/lib/security.c |  45 +++++++
>  arch/lib/seq.c      | 122 +++++++++++++++++++
>  arch/lib/splice.c   |  20 ++++
>  arch/lib/super.c    | 210 ++++++++++++++++++++++++++++++++
>  arch/lib/sysfs.c    |  83 +++++++++++++
>  arch/lib/vmscan.c   |  26 ++++
>  17 files changed, 1749 insertions(+)

BTW: Why do you need these stub implementations at all?
If I read your code correctly it is because you're linking against the whole net/ directory.
Let's take register_filesystem() again as example. net/socket.c references it in sock_init().
Maybe it would make sense to split socket.c into two files, net/socket.c and net/sockfs.c.
Such that you could link only net/socket.o.
Of course you'd have to convince networking folks first. :D

By linking selectively objects files from net/ you could get rid of a lot unneeded stubs.

Thanks,
//richard