From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757855AbbFQVe0 (ORCPT ); Wed, 17 Jun 2015 17:34:26 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:42691 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753463AbbFQVeZ (ORCPT ); Wed, 17 Jun 2015 17:34:25 -0400 From: "Rafael J. Wysocki" To: Dan Williams Cc: linux-nvdimm@ml01.01.org, mingo@kernel.org, sfr@canb.auug.org.au, rafael@kernel.org, neilb@suse.de, gregkh@linuxfoundation.org, "Rafael J. Wysocki" , Robert Moore , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, jmoyer@redhat.com, axboe@kernel.dk, linux-api@vger.kernel.org, akpm@linux-foundation.org, hch@lst.de Subject: Re: [PATCH v6 03/21] libnvdimm: control character device and nvdimm_bus sysfs attributes Date: Thu, 18 Jun 2015 00:00:24 +0200 Message-ID: <55195804.2G24WjSeEI@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20150611201024.25175.7686.stgit@dwillia2-desk3.amr.corp.intel.com> References: <20150611183830.25175.51256.stgit@dwillia2-desk3.amr.corp.intel.com> <20150611201024.25175.7686.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, June 11, 2015 04:10:24 PM Dan Williams wrote: > The control device for a nvdimm_bus is registered as an "nd" class > device. The expectation is that there will usually only be one "nd" bus > registered under /sys/class/nd. However, we allow for the possibility > of multiple buses and they will listed in discovery order as > ndctl0...ndctlN. This character device hosts the ioctl for passing > control messages. The initial command set has a 1:1 correlation with > the commands listed in the by the "NFIT DSM Example" document [1], but > this scheme is extensible to future command sets. > > Note, nd_ioctl() and the backing ->ndctl() implementation are defined in > a subsequent patch. This is simply the initial registrations and sysfs > attributes. > > [1]: http://pmem.io/documents/NVDIMM_DSM_Interface_Example.pdf > > Cc: Neil Brown > Cc: Greg KH > Cc: > Cc: Robert Moore > Cc: Rafael J. Wysocki > Signed-off-by: Dan Williams For the ACPI part: Acked-by: Rafael J. Wysocki