From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752830AbbC3ORn (ORCPT ); Mon, 30 Mar 2015 10:17:43 -0400 Received: from mail-bn1on0117.outbound.protection.outlook.com ([157.56.110.117]:12704 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752263AbbC3ORh (ORCPT ); Mon, 30 Mar 2015 10:17:37 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; intel.com; dkim=none (message not signed) header.d=none; X-WSS-ID: 0NM13P6-07-23T-02 X-M-MSG: Message-ID: <55195AE6.2050801@amd.com> Date: Mon, 30 Mar 2015 09:17:10 -0500 From: Suravee Suthikulanit User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "Moore, Robert" , "rjw@rjwysocki.net" , "mika.westerberg@linux.intel.com" , "Zheng, Lv" , "hanjun.guo@linaro.org" CC: "lenb@kernel.org" , "hdegoede@redhat.com" , "tj@kernel.org" , "mjg59@srcf.ucam.org" , "gregkh@linuxfoundation.org" , "al.stone@linaro.org" , "graeme.gregory@linaro.org" , "leo.duran@amd.com" , "linux-ide@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linaro-acpi@lists.linaro.org" Subject: Re: [V7 PATCH 1/3] ACPICA: Add ACPI _CLS processing References: <1427397195-15273-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1427397195-15273-2-git-send-email-Suravee.Suthikulpanit@amd.com> <94F2FBAB4432B54E8AACC7DFDE6C92E37D2A5F70@ORSMSX112.amr.corp.intel.com> In-Reply-To: <94F2FBAB4432B54E8AACC7DFDE6C92E37D2A5F70@ORSMSX112.amr.corp.intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;BMV:1;SFV:NSPM;SFS:(10019020)(6009001)(428002)(377454003)(164054003)(24454002)(51704005)(199003)(479174004)(189002)(2501003)(50466002)(59896002)(76176999)(50986999)(87266999)(54356999)(2950100001)(105586002)(36756003)(47776003)(106466001)(46102003)(65816999)(101416001)(65956001)(92566002)(19580395003)(83506001)(77156002)(62966003)(77096005)(120886001)(86362001)(87936001)(33656002)(99136001)(2201001);DIR:OUT;SFP:1102;SCL:1;SRVR:SN1PR02MB1310;H:atltwp01.amd.com;FPR:;SPF:None;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR02MB1310; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5002010)(5005006);SRVR:SN1PR02MB1310;BCL:0;PCL:0;RULEID:;SRVR:SN1PR02MB1310; X-Forefront-PRVS: 05315CBE52 X-OriginatorOrg: amd4.onmicrosoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2015 14:17:32.8908 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR02MB1310 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/27/2015 12:51 PM, Moore, Robert wrote: > + cls_objects = obj_desc->package.elements; > + > + if (obj_desc->common.type == ACPI_TYPE_PACKAGE && > + obj_desc->package.count == 3 && > + cls_objects[0]->common.type == ACPI_TYPE_INTEGER && > + cls_objects[1]->common.type == ACPI_TYPE_INTEGER && > + cls_objects[2]->common.type == ACPI_TYPE_INTEGER) { > + > + /* Allocate a buffer for the CLS */ > + cls = ACPI_ALLOCATE_ZEROED(sizeof(struct acpi_pnp_device_id) + > + (acpi_size) 7); > > I would like to see an error returned if an object or subobject is of the incorrect type. > Then, the caller knows not to attempt to look at it. > Ok. I will return AE_TYPE if the condition is false here. Thanks, Suravee