From: Yunlong Song <yunlong.song@huawei.com>
To: David Ahern <dsahern@gmail.com>, <a.p.zijlstra@chello.nl>,
<paulus@samba.org>, <mingo@redhat.com>, <acme@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <wangnan0@huawei.com>
Subject: Re: [PATCH 2/9] perf sched replay: Increase the MAX_PID value to fix assertion failure problem
Date: Wed, 1 Apr 2015 15:10:32 +0800 [thread overview]
Message-ID: <551B99E8.9060205@huawei.com> (raw)
In-Reply-To: <551AAE74.8060402@gmail.com>
On 2015/3/31 22:25, David Ahern wrote:
> On 3/31/15 7:46 AM, Yunlong Song wrote:
>> diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
>> index a1893e8..c466104 100644
>> --- a/tools/perf/builtin-sched.c
>> +++ b/tools/perf/builtin-sched.c
>> @@ -28,7 +28,7 @@
>> #define MAX_CPUS 4096
>> #define COMM_LEN 20
>> #define SYM_LEN 129
>> -#define MAX_PID 65536
>> +#define MAX_PID 1024000
>>
>> struct sched_atom;
>
> # cat /proc/sys/kernel/pid_max
> 1048576
>
> so your proposed change is still not high enough for what I need.
>
> It would be best to make it dynamic, not static, with run time reallocations as needed.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>
Yes, please see my 3rd and 4th patch in the patch sets, which dynamic allocate the memory
in run time.
--
Thanks,
Yunlong Song
next prev parent reply other threads:[~2015-04-01 7:10 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 13:46 [PATCH 0/9] perf sched replay: Make some improvements and fixes Yunlong Song
2015-03-31 13:46 ` [PATCH 1/9] perf sched replay: Use struct task_desc instead of struct task_task for correct meaning Yunlong Song
2015-04-08 15:11 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-31 13:46 ` [PATCH 2/9] perf sched replay: Increase the MAX_PID value to fix assertion failure problem Yunlong Song
2015-03-31 14:25 ` David Ahern
2015-04-01 7:10 ` Yunlong Song [this message]
2015-04-08 15:11 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-31 13:46 ` [PATCH 3/9] perf sched replay: Alloc the memory of pid_to_task dynamically to adapt to the unexpected change of pid_max Yunlong Song
2015-03-31 14:32 ` David Ahern
2015-03-31 15:56 ` Arnaldo Carvalho de Melo
2015-04-01 7:06 ` Yunlong Song
2015-04-07 13:23 ` Yunlong Song
2015-04-07 15:02 ` Arnaldo Carvalho de Melo
2015-03-31 20:25 ` Arnaldo Carvalho de Melo
2015-03-31 22:26 ` David Ahern
2015-03-31 22:35 ` Arnaldo Carvalho de Melo
2015-04-01 7:23 ` Yunlong Song
2015-04-08 15:12 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-31 13:46 ` [PATCH 4/9] perf sched replay: Realloc the memory of pid_to_task stepwise to adapt to the different pid_max configurations Yunlong Song
2015-04-08 15:12 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-31 13:46 ` [PATCH 5/9] perf sched replay: Fix the segmentation fault problem caused by pr_err in threads Yunlong Song
2015-04-08 15:12 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-31 13:46 ` [PATCH 6/9] perf sched replay: Handle the dead halt of sem_wait when create_tasks() fails for any task Yunlong Song
2015-04-08 15:13 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-31 13:46 ` [PATCH 7/9] perf sched replay: Fix the EMFILE error caused by the limitation of the maximum open files Yunlong Song
2015-04-07 16:49 ` David Ahern
2015-04-08 15:13 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-03-31 13:46 ` [PATCH 8/9] perf sched replay: Support using -f to override perf.data file ownership Yunlong Song
2015-04-08 15:13 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-09-21 13:54 ` [RFC] Perf: Trigger and dump sample info to perf.data from user space ring buffer Yunlong Song
2015-09-21 15:12 ` Borislav Petkov
2015-03-31 13:46 ` [PATCH 9/9] perf sched replay: Use replay_repeat to calculate the runavg of cpu usage instead of the default value 10 Yunlong Song
2015-04-08 15:13 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-04-07 3:20 ` [PATCH 0/9] perf sched replay: Make some improvements and fixes Yunlong Song
2015-04-07 13:53 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551B99E8.9060205@huawei.com \
--to=yunlong.song@huawei.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome