mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <shuahkh@osg.samsung.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: akpm@linux-foundation.org, mpe@ellerman.id.au,
	linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
	Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH] selftests: Change memory on-off-test.sh name to be unique
Date: Wed, 01 Apr 2015 07:06:15 -0600	[thread overview]
Message-ID: <551BED47.6030303@osg.samsung.com> (raw)
In-Reply-To: <20150401120400.GA3218@kroah.com>

On 04/01/2015 06:04 AM, Greg KH wrote:
> On Tue, Mar 31, 2015 at 06:10:59PM -0600, Shuah Khan wrote:
>> cpu and memory hotplug scripts use the same name. Change
>> memory on-off-test.sh to mem-on-off-test.sh.
>>
>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>> ---
>>  tools/testing/selftests/memory-hotplug/Makefile    |   6 +-
>>  .../selftests/memory-hotplug/mem-on-off-test.sh    | 238 +++++++++++++++++++++
>>  .../selftests/memory-hotplug/on-off-test.sh        | 238 ---------------------
>>  3 files changed, 241 insertions(+), 241 deletions(-)
>>  create mode 100755 tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
>>  delete mode 100755 tools/testing/selftests/memory-hotplug/on-off-test.sh
> 
> Hint, when making patches that rename files, use '-M' as a git diff
> output, it will show the move much easier than adding and removing the
> file.

Thanks for the tip. That would have made it easier to review.

> 
> Anyway, I have no problem with this:
> 
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 

thanks,
-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978

      reply	other threads:[~2015-04-01 13:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01  0:10 Shuah Khan
2015-04-01 12:04 ` Greg KH
2015-04-01 13:06   ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551BED47.6030303@osg.samsung.com \
    --to=shuahkh@osg.samsung.com \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®