Hi Andrew, On 04/01/2015 11:41 PM, Andrew Morton wrote: > On Wed, 1 Apr 2015 14:47:20 +0200 Greg KH wrote: > >> On Tue, Mar 31, 2015 at 03:11:34PM +0200, Daniel Mack wrote: >>> Give the kdbus sample its own config switch and only build it if it's >>> explicitly switched on. >>> >>> Signed-off-by: Daniel Mack >>> Reviewed-by: David Herrmann >>> Reported-by: Jiri Slaby >>> --- >>> samples/Kconfig | 7 +++++++ >>> samples/kdbus/Makefile | 2 +- >>> 2 files changed, 8 insertions(+), 1 deletion(-) >> >> Now applied, thanks. > > Is this going to fix i386 allmodconfig, currently unhappy on my Fedora > Core 6 (lol) machine? As allmodconfig will select CONFIG_SAMPLE_KDBUS just as it selected CONFIG_SAMPLES, that won't help, no. > samples/kdbus/kdbus-workers.c:73:26: error: sys/signalfd.h: No such file or directory > samples/kdbus/kdbus-workers.c: In function 'master_new': > samples/kdbus/kdbus-workers.c:231: warning: implicit declaration of function 'signalfd' > samples/kdbus/kdbus-workers.c:231: error: 'SFD_CLOEXEC' undeclared (first use in this function) > samples/kdbus/kdbus-workers.c:231: error: (Each undeclared identifier is reported only once > samples/kdbus/kdbus-workers.c:231: error: for each function it appears in.) > samples/kdbus/kdbus-workers.c: In function 'master_handle_signal': > samples/kdbus/kdbus-workers.c:406: error: storage size of 'val' isn't known > samples/kdbus/kdbus-workers.c:406: warning: unused variable 'val' > samples/kdbus/kdbus-workers.c: In function 'child_run': > samples/kdbus/kdbus-workers.c:773: error: 'CLOCK_MONOTONIC_COARSE' undeclared (first use in this function) > samples/kdbus/kdbus-workers.c: In function 'bus_open_connection': > samples/kdbus/kdbus-workers.c:1038: error: 'O_CLOEXEC' undeclared (first use in this function) > samples/kdbus/kdbus-workers.c: In function 'bus_make': > samples/kdbus/kdbus-workers.c:1275: error: 'O_CLOEXEC' undeclared (first use in this function) Hmm, so your libc headers lack support for signalfds, which were introduced in kernel v2.6.22 (2007), one year after the release of your distribution. We can't probe for the existance of files in the local toolchain before compilation with kdbuild, so we have to stub out the code for glibc version that are known to lack features. This isn't particularly nice, but it should work. Does the attached patch work for you? Thanks, Daniel