From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751995AbdATMcb (ORCPT ); Fri, 20 Jan 2017 07:32:31 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:51424 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751812AbdATMc2 (ORCPT ); Fri, 20 Jan 2017 07:32:28 -0500 X-AuditID: b6c32a2e-f79f46d000002a13-5c-58820359863b Subject: Re: [PATCH] clk: samsung: exynos5420: Mark CLK_ACLK432_SCALER as CLK_IS_CRITICAL To: Javier Martinez Canillas , Michael Turquette , Stephen Boyd Cc: linux-kernel@vger.kernel.org, Inki Dae , Andi Shyti , Shuah Khan , Mauro Carvalho Chehab , Marek Szyprowski , Kukjin Kim , Chanwoo Choi , linux-clk@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Tomasz Figa , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org From: Sylwester Nawrocki Message-id: <551ac156-0cfa-29be-335f-d8a1f171cd8a@samsung.com> Date: Fri, 20 Jan 2017 13:32:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-version: 1.0 In-reply-to: <1484908891-11820-1-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02Se0iTURjGOd9l36c1OW1aL2ZaowKFvFDBIUu6mYv6IyTKLlAjP1TyMvZl aH+kTi213MxLrWFpokFmqMtuJhFeUivTOcjK0sCwMm+VyrK0nN8C/3ue5/0d3vMcDk8rOlhP Pib+lKCL18SqZK7M/SZf33WHaH1E4PTsWvKgeZAlPROfWZLfn8eQ4ZEqihgHvtGks7OGI5aB 1yz5frGPJbb6YhkxdT6hyJ3mDxy5aflDEevzUGJ/eYEhRRPjDKms/4O2YvXYm0xObTPkUupH 5g+c2lKZLVPfLU9R1xnnnKGuEql/Wrz38YddN0cKsTGnBV1AyHHX6C+ZqTJtLZtUP/pYlooa mBzkwgPeAFfz71CSXgpdfdWyHOTKK3AFgoyhC/MDBT5PQXaH8v8B2+/PtAQVI5i9V4Qk04+g V59FOyglPgLdaXrGMXDH2QhumMycw9B4kIbhW+XIQclwEOS2GOa1HIfA+2tf55bzPIPXwETn XkfsgSOg8VkvLSFLwF7QxzgQFxwGWbZwR0zjQDAVNlGS9oG7VSO0dNNfHIy3iA4c8AqwPHXG O2Hy8ltneyUMtdZxkl4OMxXv5rsANiJoq0p3GhOC9+fznG8UDE2tVlZa5ga5vz9R0gI5ZJ1T SIgaGsp7WUlvA+tzOyc9kBnB1Lu3sjzkY15Qx7ygg3lBh1JEV6KlglaMixLEjdr1/qImTkyM j/I/kRBnQfOfzM//IZot3dOIMI9Ui+VZKWkRClZzWkyOa0TA0yp3eebfuUgeqUk+I+gSjukS YwWxES3nGdUyeWlScIQCR2lOCScFQSvo/k8p3sUzFT0e2GGcDlxS7PHEsihjZOh2q/mjdcZL WTthmHpZds+Ndl95bczbTXs0JuxV4fq8/fqNJH23F3Xg+vbqVd0HA9s8+Ci/hi2FteOD7TuK zq7Y5ftitD11p31otAS9uXypJyC8ZLc+tL0/6Qo3sKkgdzyhS/nDnlGz0jy5mk7OCSlLTFcx YrQmyI/WiZp/eaHZIWADAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDIsWRmVeSWpSXmKPExsVy+t9jQd1I5qYIgzkfBCy2H3nGanH9y3NW i0n3J7BYvHm7hsmi//FrZovz5zewW2x6fI3V4mPPPVaLy7vmsFnMOL+PyWLtkbvsFss2/WGy uHjK1eLHmW4Wi6lfPrBYrNr1h9FBwOP9jVZ2j8t9vUweO2fdZffYtKqTzWPzknqPLf1AXt+W VYwenzfJBXBEudlkpCampBYppOYl56dk5qXbKoWGuOlaKCnkJeam2ipF6PqGBCkplCXmlAJ5 RgZowME5wD1YSd8uwS3jRWsDW8FG1opd73azNTDuYeli5OSQEDCRuPz7OTOELSZx4d56ti5G Lg4hgVmMEv9+rGWBcB4ySsyfuBSsQ1ggWuJSYxNYQkSgm1Fiz8SP7BBVcxglHk75A1bFLPCM WeLLzwQQm03AUKL3aB8jiM0rYCdxZ+5LoB0cHCwCqhJfzvuAmKICERINh9MhKgQlfky+xwIS 5hRwl+i4HARiMgvoSdy/qAUxW15i85q3zBMYgY5EaJiFUDULSdUCRuZVjBKpBckFxUnpuUZ5 qeV6xYm5xaV56XrJ+bmbGMEx/Ux6B+PhXe6HGAU4GJV4eDMkGiOEWBPLiitzDzFKcDArifC2 /gcK8aYkVlalFuXHF5XmpBYfYjQF+mEis5Rocj4w3eSVxBuamJuYGxtYmFtamhgpifM2zn4W LiSQnliSmp2aWpBaBNPHxMEp1cAo6Xyd10pzybQouQWHCy3kU6J/LDtkdVJ0Bqtw0ZndnKXr d0U//cx4cc2N1a+8d3om3jefe+fB72OHEr+pfJFPvrV1Z3Lh+ZWtzJGrW0UE3I9e1pNTu3zT SvbwrwCj62eDtzjtXWTXFtyaUq6z9JZsg5tJ38qSs6v0p5VbGz+aM2OirQPL06M3lFiKMxIN tZiLihMBzCN8Of8CAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170120123225epcas5p45ae3378c57fbaf01fc8c1ae3a7e95916 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G+yCvOyEseyghOyekBtTZW5pb3IgU29mdHdhcmUgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-HopCount: 7 X-CMS-RootMailID: 20170120104148epcas5p11af0e630f0881092a9b3b43e8b5b1aac X-RootMTR: 20170120104148epcas5p11af0e630f0881092a9b3b43e8b5b1aac References: <1484908891-11820-1-git-send-email-javier@osg.samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/20/2017 11:41 AM, Javier Martinez Canillas wrote: > On Exynos5800 SoC the SCALER block uses 2 input clocks: CLK_ACLK_300_GSCL > and CLK_ACLK432_SCALER, so both needs to be ungated in order to access it. > > But Exynos5420 only has the CLK_ACLK_300_GSCL as gsc_pd clk. So just using > this definition from exynos5420.dtsi in Exynos5800 leads to the following: [...] > So until a proper solution based on runtime PM gets merged, mark the clock > as critical to prevent it to be gated. > > Suggested-by: Marek Szyprowski > Signed-off-by: Javier Martinez Canillas Acked-by: Sylwester Nawrocki