From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E269326943 for ; Fri, 5 Dec 2025 12:03:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764936199; cv=none; b=Z2Bt8yRyFRL1RkD6pEvcY0APp7X+Rys36rQvwOKpwPBxcOGjpzX8PscagTwe9ZEsy+ibgCacYfHMawYFGUvad7E3Zqj7XMFU004o4iYDozWvnxXSf/SCmEv6fKGqgLFDrZJ0dpQ3nUkOAdpsA5c+B9VCoJ8MZ5s9rgWSehSgUdU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764936199; c=relaxed/simple; bh=v9h+kkuk56zMsB4Du/PwkY7JPFHXv/drmxI+Nn0ItY4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pdNH1x/vi72p4FmHnslJfQbkMDQCGbN+vNjmv4TuEhc2oz+xHe3OWARRbLg+5YK+oj3U53sgDVHIzA6ZBtDdoXh3Gfv2sJESccC639cvnSw67ydeg77YCgdplHoiWz3sPCJLL6FGWbsLNfGIb2wMFO9AerUljtYnNYeD9hVW9D8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HLiHqHen; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZYleLIDG; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HLiHqHen"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZYleLIDG" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B54JxeI3643667 for ; Fri, 5 Dec 2025 12:03:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7ibRns9NpT7LfaypmozZ00h9uMW/vCu+51UfOTwa4xw=; b=HLiHqHen3PiMkldG 650qsThVHMEsBaLSxlhAqqxkXk9hyckjX3twAM+eVhqgQPo+buHuUVkViDY4U5M3 x4mjcu+QuAVSXxAJEZGIFzlwFJ9A3urUPBK89UyW0aOYcdMl2LXBtqoutVl/xLX3 2YMDjUDdmcQPNNiezzjWfbzFc8+/40uzOfO++SQdqu+doThtkmzU/kdxoJnMC0UF 3/sti3IUArB9nsozpPc3e39+uHwWfGA/UzaDY2yoFuetG2l6+MhdxTpYJVEupz49 qI1eJlXHXr9ppj2MGZucS7ebu3RbhBoMRClYC0uTfHBrOs2tcBYCmDWZFh4qRH/I K2knPQ== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4aur9as86a-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 05 Dec 2025 12:03:15 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4f030d18ed6so2229841cf.3 for ; Fri, 05 Dec 2025 04:03:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764936195; x=1765540995; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7ibRns9NpT7LfaypmozZ00h9uMW/vCu+51UfOTwa4xw=; b=ZYleLIDG4nAxGsMeG6j4nUxbKEPAFpcQqY1HtzYYUxjIqM6mkVZpkCLCCqBBVoB6g3 nWoZ3ab7dwO94sYhKvrqHAbetitDUy7yOkK7JB1RySZetRtd3+OOxKxEoH1hiYCmJe9E q8p2udcbu6/9fm18C3cuYO0BAxOz+qSpA/FySTBl7CrtOIw5LCjKDayh+e1DvYK/sWwn hvT0xzLAY7zSa+aM8HaADx2259aR7Vj5wLUbkbYUd8xFE7/nkqTnJ03Fibr9sbqZH1uc BdZDQI2CVgJ8++f15fhXYIeK0rQz621rQoyT4+bbC7mZRGRAmrWNzKywyHMHFqmZdf5X VNHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764936195; x=1765540995; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7ibRns9NpT7LfaypmozZ00h9uMW/vCu+51UfOTwa4xw=; b=mMBUsGASvMozd3/OncIwptmHvOKa+6ScqxT34fBbFDOb5AMya9tBAEoWDKVK7TZWgB bSdEuakoW6gqwp0w2R2uRRSuh6ymQdPf0Hh1/mJgK/6EQOtcp1eEdDI9wqNOWHkUQg1S W2sjf0hAuiYqf55p2DRqWiZSKW9pQL5+d+4AkmJtHg39kZthbyCBVxmek8YI6OKwM0bb HRRWl1Gx0+Xc/6EvA5wzAYjPd+gTAdFAXwfIE0dOXdVVn3LMLET6ao2QOxrNv1L32Uju XFq1+tjxlQjVbPgZoiipj+zjsMjlUwFjl7jDPUOUjLcBLz8XAQRDeraOTFBhY5t7C1Gb bgiQ== X-Forwarded-Encrypted: i=1; AJvYcCUJsnIqN0mnOStyf3pdUw7BAp3BS/bwksMEfV/oV+6+uyMwctdlAY+weIYDs3H/izmbTlJb5nIam+zOSic=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6dU9pCxpkXjxrA6LYL5L3xlv+WkOarcZLH3eULPgJJRGjAsIp PZl5meRp17EniGdbMzRW36y2HiFQF7CbvdwgY+v2G5gD3SVZsytXncM5q15cVdw9O6Ro4SVoBXw Zu9VFQC6IFDmLvU+8ENN4JcObTA5QGTqpXyt5uhST8UBJ1JcKrbhLytufyyqRrIuLviU= X-Gm-Gg: ASbGnctsP0SP0ckpv1Oz/eKS8daEI85RY8Q/1vDmEgBVOACe4XPQDWB8RutRg1F30SV 7n0hCCprBNk/9KgKFbDfXOvbYj3j845uR5EJ/68nUi8EZxvKWY489hPgl0XKwk2NUp0hyhQ/u3d /WErcOv66GYjSvZ3MnhcTTU8gWuXlV6Li3DFSwgHBr6iE1mlQ0urJLJFQ0PmBUUHLDWL9sf7hbt aVyvqAY+9uBwsl2pD0DjdRzvagNBGhQEBdAqSsc8Pd6zcxrwz+YfTUg8w/iPpVLhbRqTGNchNTY KeQOvReUgdBQ0hHZh4aOU6QiXhcLDGIi5QaX6Fw4pw9xtTsppHBR20bmcA0SOuFGZhXr0BKR+qS f4p83pIbB5tjABI41PybgKRCL6DoXgOdoUMRuhdk+4DCWocgVQqRzlCfEwoCkYPwj8w== X-Received: by 2002:ac8:7f54:0:b0:4ee:1588:6186 with SMTP id d75a77b69052e-4f0176844ddmr100919611cf.11.1764936195069; Fri, 05 Dec 2025 04:03:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IHDtA69UwRIJoySS2OMMEYNqbCpINvG3hPdksp1reab8w5GlGFxHYYfb5cJEmOse38qlA5hXQ== X-Received: by 2002:ac8:7f54:0:b0:4ee:1588:6186 with SMTP id d75a77b69052e-4f0176844ddmr100918911cf.11.1764936194568; Fri, 05 Dec 2025 04:03:14 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b79f4975dc1sm345503666b.32.2025.12.05.04.03.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Dec 2025 04:03:13 -0800 (PST) Message-ID: <551b45ae-0980-4bd5-bb83-2fac6d7e2ce7@oss.qualcomm.com> Date: Fri, 5 Dec 2025 13:03:11 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/6] drm/msm/a6xx: Retrieve gmu core range by index To: rob.clark@oss.qualcomm.com Cc: Akhil P Oommen , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Jessica Zhang , Dan Carpenter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20251122-qcs615-spin-2-v3-0-9f4d4c87f51d@oss.qualcomm.com> <20251122-qcs615-spin-2-v3-1-9f4d4c87f51d@oss.qualcomm.com> <9cc55934-6980-4673-8501-2d1efe2f816e@oss.qualcomm.com> <936b6a48-a5e5-4efb-be7c-215ac670677d@oss.qualcomm.com> <7b4bcb6e-fbb1-45f6-921e-dd1340a8cece@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=Veb6/Vp9 c=1 sm=1 tr=0 ts=6932ca03 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=QGPp5zjhHj0ErSlcMgEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: PdnO9Mx5kVRpLay1eaGTR2Z_w-5BTcTB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA1MDA4NiBTYWx0ZWRfXwijZiQp5D2dt hy7FsWNNS6WAXXoGf3oKGaY3ZJWkiFGySXpf/hXBHCIOwCafmS0isbcuKY1sXqptiGtr22glyKF C5+iY6+pluI5zy8/4+2Jf9XhRF8hT9spKma2wFNS1e1Zu6Ee41EZUf2glUvaRkPzzlkIokBV4TE u3sjYXg0o0vunQTmlsqAv6hSur0fLcAG81k0F6yCwe4OwJa1oYtYlG3Piopr7BtIdZUU/CX6dP/ pT/ASmkbHpCdIXulAiU4KgyPfW29nuQinTSWmgZIgJT2RQTxuGWAevEo733AK/Qe5YsuvI9NSFj QSPZa0u31TNgfSFqrKPeJTL5Rw1rp4Ijk+HDHjhCcw35bzbdvQL0CKgY/eB46bPrUm6IqzpGBRV t9VWTMwy6gfp9LNwrY1lq+YptR1+OQ== X-Proofpoint-ORIG-GUID: PdnO9Mx5kVRpLay1eaGTR2Z_w-5BTcTB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-05_04,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 impostorscore=0 adultscore=0 suspectscore=0 spamscore=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512050086 On 12/4/25 3:34 PM, Rob Clark wrote: > On Thu, Dec 4, 2025 at 5:30 AM Konrad Dybcio > wrote: >> >> On 12/4/25 2:10 PM, Akhil P Oommen wrote: >>> On 11/22/2025 7:08 PM, Konrad Dybcio wrote: >>>> On 11/21/25 10:52 PM, Akhil P Oommen wrote: >>>>> Some GPUs like A612 doesn't use a named register range resource. This >>>>> is because the reg-name property is discouraged when there is just a >>>>> single resource. >>>>> >>>>> To address this, retrieve the 'gmu' register range by its index. It is >>>>> always guaranteed to be at index 0. >>>>> >>>>> Signed-off-by: Akhil P Oommen >>>>> --- >>>>> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 14 ++++++-------- >>>>> 1 file changed, 6 insertions(+), 8 deletions(-) >>>>> >>>>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c >>>>> index 5903cd891b49..9662201cd2e9 100644 >>>>> --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c >>>>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c >>>>> @@ -2029,21 +2029,19 @@ static int cxpd_notifier_cb(struct notifier_block *nb, >>>>> return 0; >>>>> } >>>>> >>>>> -static void __iomem *a6xx_gmu_get_mmio(struct platform_device *pdev, >>>>> - const char *name, resource_size_t *start) >>>>> +static void __iomem *a6xx_gmu_get_mmio(struct platform_device *pdev, resource_size_t *start) >>>> >>>> Can we drop this and just use devm_platform_get_and_ioremap_resource()? >>> >>> This API seems to lock the io region and fails with -EBUSY if the region >>> is already in use. I am worried it may regress other chipsets. So, I >>> dropped this idea at the last moment. >> >> Is there any specific platform where this would be an issue? > > IIRC we've had this problem before and ended up reverting a similar > change, due to gpucc and gpu overlap Argh, sm8350.dtsi for example seems to be affected.. Hopefully one day we can fix that.. Konrad