From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760256AbcISIEq convert rfc822-to-8bit (ORCPT ); Mon, 19 Sep 2016 04:04:46 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:49672 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751914AbcISIEm (ORCPT ); Mon, 19 Sep 2016 04:04:42 -0400 From: Arnd Bergmann To: Christian =?ISO-8859-1?Q?K=F6nig?= Cc: Baoyou Xie , alexander.deucher@amd.com, airlied@linux.ie, Qingqing.Wang@amd.com, Monk.Liu@amd.com, JinHuiEric.Huang@amd.com, Rex.Zhu@amd.com, nils.wallmenius@gmail.com, ray.huang@amd.com, Young.Yang@amd.com, Flora.Cui@amd.com, Jammy.Zhou@amd.com, funfunctor@folklore1984.net, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn Subject: Re: [PATCH] drm/amd/powerplay/smumgr: mark symbols static where possible Date: Mon, 19 Sep 2016 10:04:15 +0200 Message-ID: <55201260.bZuRN8tJlX@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <15c872e1-8931-68ca-846e-c909e6e3d5af@amd.com> References: <1474270119-8500-1-git-send-email-baoyou.xie@linaro.org> <2392100.i5YbeLyK7H@wuerfel> <15c872e1-8931-68ca-846e-c909e6e3d5af@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" X-Provags-ID: V03:K0:h0A0R1qKqSAO4imyixVkYICOwyr8+3NErNstr4pCtZJUyl4HAHB rF8ZVgHuzxR5gzXUD0L0P00puTO4mqvE5+pxrvsj+ARvTK5ng9RU9OOL0uO/rJUl1wqz7r+ 55delHubrM5VO8pC3bGFtJAffm97M6eFaMhIZcSaGol8KGRv6pdq3LjQ0myh5mSoi+Q6dxR Q1zcDoSP2jQT7gTDruARg== X-UI-Out-Filterresults: notjunk:1;V01:K0:9HcOUCZOoYE=:UAV+VfZqMC91XzzebxtEls uIEig18G5vDUi6wYGS834gT3QwwDnB6XwGfm0pfKkXQwberLBB1Z563oIQP1Dk3ZO5hlZcgt6 MRCk4cCA8DNj+RD9Na8WaXEWAlrlu3qIdnoSMeHM5/8NT7FHccFxU88p7Ciaq93KgjHk9DuOl bhC4kT/GL5Zj/YrOzz2zFFRHwthK9S+++MA+XiIwLX3gjl/x1gSSv9jwCH93FRrAUyyG6gIrP FhrO9cFNrPqKq64CxbD8SJu85/fRuO6QyR7Lc6Xx3kWBCawDU8S4MLxxeI62M5vg8yjN1sAb0 r6FCPkgewpiNOjRTbncQtIH+U/ZiC9sB/d9DyA1ugLrEJnEyQ1lRwvI12w3esTLeAMIP+ICG+ Ob5ZHSMMX+XDHn7YAsY7sbwt4/Zbie6TXNago8xAIa9UsEv3xUVW5Hj12h36WY4R+tB6z5BjM FfcEg9acY1nut1ur8J6THOqJ0cL/HP/vIQXefjLMJ5vXIHSFED1P1adB+gFkxeDAcsEZmuRa+ ry1JuQSKzrlaUqawLelzYpXFOY0Jn4fzRFlYfhBzTzHCkLIfiFS7z7TPd5XtyUPJwxo6Y5K/W jomEnIACVmcUIcP7o1LcQd31KUVcl2CdI0ZGMzBjGQ3SHhn4OecBlayxb3DHfegCsdhh5h1Ph AuZtxamXEPrxtPtQXSpNYFZaE2lwOZUMNnhVD5j7yheS6uhFauPw9bCFsMijoVZcpKg5Qz+tb eUJm8Na+Ww2/+5JX Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, September 19, 2016 9:59:56 AM CEST Christian König wrote: > Am 19.09.2016 um 09:34 schrieb Arnd Bergmann: > > On Monday, September 19, 2016 3:28:39 PM CEST Baoyou Xie wrote: > >> We get a few warnings when building kernel with W=1: > >> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/tonga_smumgr.c:146:5: warning: no previous prototype for 'tonga_program_jump_on_start' [-Wmissing-prototypes] > >> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/fiji_smumgr.c:816:5: warning: no previous prototype for 'fiji_save_vft_table' [-Wmissing-prototypes] > >> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/polaris10_smumgr.c:743:5: warning: no previous prototype for 'polaris10_avfs_event_mgr' [-Wmissing-prototypes] > >> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/iceland_smumgr.c:167:5: warning: no previous prototype for 'iceland_program_jump_on_start' [-Wmissing-prototypes] > >> .... > >> > >> In fact, these functions are only used in the file in which they are > >> declared and don't need a declaration, but can be made static. > >> So this patch marks these functions with 'static'. > >> > >> Signed-off-by: Baoyou Xie > >> > > Hi Baoyou, > > > > All your drm/amd patches seem fine to me, but again (as with the nouveau > > driver patches before), I think it would make more sense to consolidate > > them, and do a small number of patches such as > > > > [PATCH 1/3] drm/amdgpu: add missing includes > > [PATCH 2/3] drm/amdgpu: remove unused functions > > [PATCH 3/3] drm/amdgpu: mark symbol static where possible > > > > This is all one big driver, > > No it isn't. The different parts are developed by different teams at > AMD, so the splitting them up is rather welcome here. > > So please keep your style as it is, at least for the amdgpu driver. Ok, fair enough. Thanks for the clarification! Arnd