mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Wang <yun.wang@profitbricks.com>
To: Steve Wise <swise@opengridcomputing.com>,
	"'Jason Gunthorpe'" <jgunthorpe@obsidianresearch.com>
Cc: "'Roland Dreier'" <roland@kernel.org>,
	"'Sean Hefty'" <sean.hefty@intel.com>,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
	"'Hal Rosenstock'" <hal.rosenstock@gmail.com>,
	"'Tom Tucker'" <tom@opengridcomputing.com>,
	"'Hoang-Nam Nguyen'" <hnguyen@de.ibm.com>,
	"'Christoph Raisch'" <raisch@de.ibm.com>,
	"'Mike Marciniszyn'" <infinipath@intel.com>,
	"'Eli Cohen'" <eli@mellanox.com>,
	"'Faisal Latif'" <faisal.latif@intel.com>,
	"'Upinder Malhi'" <umalhi@cisco.com>,
	"'Trond Myklebust'" <trond.myklebust@primarydata.com>,
	"'J. Bruce Fields'" <bfields@fieldses.org>,
	"'David S. Miller'" <davem@davemloft.net>,
	"'Ira Weiny'" <ira.weiny@intel.com>,
	"'PJ Waskiewicz'" <pj.waskiewicz@solidfire.com>,
	"'Tatyana Nikolova'" <Tatyana.E.Nikolova@intel.com>,
	"'Or Gerlitz'" <ogerlitz@mellanox.com>,
	"'Jack Morgenstein'" <jackm@dev.mellanox.co.il>,
	"'Haggai Eran'" <haggaie@mellanox.com>,
	"'Ilya Nelkenbaum'" <ilyan@mellanox.com>,
	"'Yann Droneaud'" <ydroneaud@opteya.com>,
	"'Bart Van Assche'" <bvanassche@acm.org>,
	"'Shachar Raindel'" <raindel@mellanox.com>,
	"'Sagi Grimberg'" <sagig@mellanox.com>,
	"'Devesh Sharma'" <devesh.sharma@emulex.com>,
	"'Matan Barak'" <matanb@mellanox.com>,
	"'Moni Shoua'" <monis@mellanox.com>,
	"'Jiri Kosina'" <jkosina@suse.cz>,
	"'Selvin Xavier'" <selvin.xavier@emulex.com>,
	"'Mitesh Ahuja'" <mitesh.ahuja@emulex.com>,
	"'Li RongQing'" <roy.qing.li@gmail.com>,
	"'Rasmus Villemoes'" <linux@rasmusvillemoes.dk>,
	"'Alex Estrin'" <alex.estrin@intel.com>,
	"'Doug Ledford'" <dledford@redhat.com>,
	"'Eric Dumazet'" <edumazet@google.com>,
	"'Erez Shitrit'" <erezsh@mellanox.com>,
	"'Tom Gundersen'" <teg@jklm.no>,
	"'Chuck Lever'" <chuck.lever@oracle.com>
Subject: Re: [PATCH v2 10/17] IB/Verbs: Adopt management helpers for IB helpers
Date: Wed, 08 Apr 2015 10:28:10 +0200	[thread overview]
Message-ID: <5524E69A.6050400@profitbricks.com> (raw)
In-Reply-To: <008401d0716f$bc41c5c0$34c55140$@opengridcomputing.com>

Hi, Steve

Thanks for the comment :-)

On 04/07/2015 10:16 PM, Steve Wise wrote:
[snip]
>>>
>>> -	force_grh = rdma_port_get_link_layer(device, port_num) == IB_LINK_LAYER_ETHERNET;
>>> +	force_grh = !rdma_transport_ib(device, port_num);
>>
>> Maybe these tests should be called cap_mandatory_grh - but I'm not
>> really sure how iWarp uses the GRH fields in the AH...
>>
> 
> iWARP runs on top of TCP...this SA code is all IB-specific.  The reason it was checking for ETHERNET, I think, is for RoCE.    So
> this change is totally incorrect,  I think,  because RoCE is an IB transport, but it runs on ETHERNET.

I guess it's the name 'transport' which confusing folks... actually (!rdma_transport_ib)
including RoCE/IBoE, but yes, here it's for IBoE only, so let's change it to
rdma_transport_iboe ;-)

Regards,
Michael Wang

> 
> Steve.
> 
> 
> 

  reply	other threads:[~2015-04-08  8:28 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-07 12:25 [PATCH v2 00/17] IB/Verbs: IB Management Helpers Michael Wang
2015-04-07 12:28 ` [PATCH 01/17] IB/Verbs: Implement new callback query_transport() for each HW Michael Wang
2015-04-07 12:44   ` Michael Wang
2015-04-07 12:29 ` [PATCH v2 02/17] IB/Verbs: Implement raw management helpers Michael Wang
2015-04-07 21:25   ` Hefty, Sean
2015-04-08  8:41     ` Michael Wang
2015-04-07 12:30 ` [PATCH v2 03/17] IB/Verbs: Use management helper cap_ib_mad() for mad-check Michael Wang
2015-04-07 17:26   ` Jason Gunthorpe
2015-04-08  8:13     ` Michael Wang
2015-04-07 12:31 ` [PATCH v2 04/17] IB/Verbs: Use management helper cap_ib_smi() for smi-check Michael Wang
2015-04-07 12:32 ` [PATCH v2 05/17] IB/Verbs: Use management helper cap_ib_cm() for cm-check Michael Wang
2015-04-07 12:32 ` [PATCH v2 06/17] IB/Verbs: Use management helper cap_ib_sa() for sa-check Michael Wang
2015-04-07 12:33 ` [PATCH v2 07/17] IB/Verbs: Use management helper cap_ib_mcast() for mcast-check Michael Wang
2015-04-07 12:34 ` [PATCH v2 08/17] IB/Verbs: Use management helper cap_ipoib() for ipoib-check Michael Wang
2015-04-07 12:34 ` [PATCH v2 09/17] IB/Verbs: Use helper cap_read_multi_sge() and reform svc_rdma_accept() Michael Wang
2015-04-07 15:46   ` Tom Talpey
2015-04-07 16:05     ` Michael Wang
2015-04-07 17:42     ` Jason Gunthorpe
2015-04-08  8:51       ` Michael Wang
2015-04-07 12:35 ` [PATCH v2 10/17] IB/Verbs: Adopt management helpers for IB helpers Michael Wang
2015-04-07 18:40   ` Hefty, Sean
2015-04-08  8:24     ` Michael Wang
2015-04-07 20:12   ` Jason Gunthorpe
2015-04-07 20:16     ` Steve Wise
2015-04-08  8:28       ` Michael Wang [this message]
2015-04-09  5:36       ` ira.weiny
2015-04-07 20:18     ` Hefty, Sean
2015-04-07 12:36 ` [PATCH v2 11/17] IB/Verbs: Reform link_layer_show() and ib_uverbs_query_port() Michael Wang
2015-04-07 18:49   ` Hefty, Sean
2015-04-07 18:56     ` Steve Wise
2015-04-08  8:29     ` Michael Wang
2015-04-07 12:36 ` [PATCH v2 12/17] IB/Verbs: Use management helper cap_ib_cm_dev() for cm-device-check Michael Wang
2015-04-07 12:37 ` [PATCH v2 13/17] IB/Verbs: Reform cma/ucma with management helpers Michael Wang
2015-04-07 21:11   ` Steve Wise
2015-04-08  8:39     ` Michael Wang
2015-04-07 21:36   ` Hefty, Sean
2015-04-08  9:37     ` Michael Wang
2015-04-08 17:02       ` Hefty, Sean
2015-04-09  8:05         ` Michael Wang
2015-04-07 12:38 ` [PATCH v2 14/17] IB/Verbs: Reserve legacy transport type for 'struct rdma_dev_addr' Michael Wang
2015-04-07 12:38 ` [PATCH v2 15/17] IB/Verbs: Reform cma_acquire_dev() with management helpers Michael Wang
2015-04-07 12:39 ` [PATCH v2 16/17] IB/Verbs: Cleanup rdma_node_get_transport() Michael Wang
2015-04-07 12:39 ` [PATCH v2 17/17] IB/Verbs: Move rdma_port_get_link_layer() to mlx4 head file Michael Wang
2015-04-07 12:42 ` [PATCH v2 01/17] IB/Verbs: Implement new callback query_transport() for each HW Michael Wang
2015-04-08 18:29   ` Doug Ledford
2015-04-08 18:41     ` Hefty, Sean
2015-04-08 19:35       ` Jason Gunthorpe
2015-04-08 20:10     ` Jason Gunthorpe
2015-04-08 20:55       ` Tom Talpey
2015-04-09  9:45       ` Michael Wang
2015-04-09 12:42       ` Michael Wang
2015-04-09 16:00         ` Jason Gunthorpe
2015-04-10  8:19           ` Michael Wang
2015-04-09 14:34       ` Doug Ledford
2015-04-09 16:01         ` Jason Gunthorpe
2015-04-09 21:19           ` Doug Ledford
2015-04-09 21:36             ` Jason Gunthorpe
2015-04-10  7:46             ` Michael Wang
2015-04-10 16:48               ` Doug Ledford
2015-04-10  6:16       ` ira.weiny
2015-04-10  8:25         ` Michael Wang
2015-04-10 14:56           ` ira.weiny
2015-04-10 16:15         ` Jason Gunthorpe
2015-04-10 17:38           ` ira.weiny
2015-04-10 17:49             ` Doug Ledford
2015-04-10 18:11               ` ira.weiny
2015-04-10 18:04             ` Jason Gunthorpe
2015-04-10 18:24               ` Doug Ledford
2015-04-10 19:17                 ` Jason Gunthorpe
2015-04-10 21:06                   ` ira.weiny
2015-04-11  0:01                     ` Tom Talpey
2015-04-10 20:38               ` ira.weiny
2015-04-09  9:34     ` Michael Wang
2015-04-10  7:48     ` ira.weiny
2015-04-10 17:10       ` Doug Ledford
2015-04-10 17:36         ` Jason Gunthorpe
2015-04-13  7:40           ` Michael Wang
2015-04-10 17:50         ` Tom Talpey
2015-04-10 18:17           ` Doug Ledford
2015-04-08 11:38 ` [PATCH v2 00/17] IB/Verbs: IB Management Helpers Tom Talpey
2015-04-08 12:41   ` Michael Wang
2015-04-08 15:51     ` Jason Gunthorpe
2015-04-08 16:05       ` Michael Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5524E69A.6050400@profitbricks.com \
    --to=yun.wang@profitbricks.com \
    --cc=Tatyana.E.Nikolova@intel.com \
    --cc=alex.estrin@intel.com \
    --cc=bfields@fieldses.org \
    --cc=bvanassche@acm.org \
    --cc=chuck.lever@oracle.com \
    --cc=davem@davemloft.net \
    --cc=devesh.sharma@emulex.com \
    --cc=dledford@redhat.com \
    --cc=edumazet@google.com \
    --cc=eli@mellanox.com \
    --cc=erezsh@mellanox.com \
    --cc=faisal.latif@intel.com \
    --cc=haggaie@mellanox.com \
    --cc=hal.rosenstock@gmail.com \
    --cc=hnguyen@de.ibm.com \
    --cc=ilyan@mellanox.com \
    --cc=infinipath@intel.com \
    --cc=ira.weiny@intel.com \
    --cc=jackm@dev.mellanox.co.il \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=matanb@mellanox.com \
    --cc=mitesh.ahuja@emulex.com \
    --cc=monis@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=pj.waskiewicz@solidfire.com \
    --cc=raindel@mellanox.com \
    --cc=raisch@de.ibm.com \
    --cc=roland@kernel.org \
    --cc=roy.qing.li@gmail.com \
    --cc=sagig@mellanox.com \
    --cc=sean.hefty@intel.com \
    --cc=selvin.xavier@emulex.com \
    --cc=swise@opengridcomputing.com \
    --cc=teg@jklm.no \
    --cc=tom@opengridcomputing.com \
    --cc=trond.myklebust@primarydata.com \
    --cc=umalhi@cisco.com \
    --cc=ydroneaud@opteya.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome