From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752688AbbDMBDo (ORCPT ); Sun, 12 Apr 2015 21:03:44 -0400 Received: from mga01.intel.com ([192.55.52.88]:41362 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752045AbbDMBDn (ORCPT ); Sun, 12 Apr 2015 21:03:43 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,567,1422950400"; d="scan'208";a="712638075" Message-ID: <552B15EB.7030806@linux.intel.com> Date: Mon, 13 Apr 2015 09:03:39 +0800 From: "Jin, Yao" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: kbuild test robot CC: alsa-devel@alsa-project.org, Takashi Iwai , linux-kernel@vger.kernel.org, Liam Girdwood , Mark Brown , kbuild-all@01.org Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: fix ifnullfree.cocci warnings References: <201504130318.BufQJB8v%fengguang.wu@intel.com> <20150412190626.GA28170@athens.lkp.intel.com> In-Reply-To: <20150412190626.GA28170@athens.lkp.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The NULL check here is to proivde the protection for current code and future potential code. It's possible that in future some code may change the pointer ipc->msg and the author may miss the kfree here. But anyway I'm ok if removing null check is the coding philosophy we need to follow. Thanks JIn Yao On 2015/4/13 3:06, kbuild test robot wrote: > sound/soc/intel/common/sst-ipc.c:287:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. > > NULL check before some freeing functions is not needed. > > Based on checkpatch warning > "kfree(NULL) is safe this check is probably not required" > and kfreeaddr.cocci by Julia Lawall. > > Generated by: scripts/coccinelle/free/ifnullfree.cocci > > CC: Jin Yao > Signed-off-by: Fengguang Wu > --- > > sst-ipc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > --- a/sound/soc/intel/common/sst-ipc.c > +++ b/sound/soc/intel/common/sst-ipc.c > @@ -283,8 +283,7 @@ void sst_ipc_fini(struct sst_generic_ipc > if (ipc->tx_thread) > kthread_stop(ipc->tx_thread); > > - if (ipc->msg) > - kfree(ipc->msg); > + kfree(ipc->msg); > } > EXPORT_SYMBOL_GPL(sst_ipc_fini); > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >