From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753783AbbDMJp4 (ORCPT ); Mon, 13 Apr 2015 05:45:56 -0400 Received: from mail5.surf-town.net ([212.97.132.45]:34310 "EHLO mailgw10.surf-town.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752221AbbDMJpz (ORCPT ); Mon, 13 Apr 2015 05:45:55 -0400 X-Spam-Flag: NO X-Spam-Score: -1.44 Message-ID: <552B9045.4040709@xelmo.com> Date: Mon, 13 Apr 2015 11:45:41 +0200 From: Pelle Nilsson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Mark Brown CC: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, nios2-dev@lists.rocketboards.org Subject: Re: [PATCH 1/1] spi: altera: Add empty implementation of setup_transfer callback References: <1428591822-24279-1-git-send-email-per.nilsson@xelmo.com> <1428591822-24279-2-git-send-email-per.nilsson@xelmo.com> <20150409154045.GZ6023@sirena.org.uk> <55269FDC.8040306@xelmo.com> <20150409161059.GA6023@sirena.org.uk> In-Reply-To: <20150409161059.GA6023@sirena.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015-04-09 18:10, Mark Brown wrote: > On Thu, Apr 09, 2015 at 05:50:52PM +0200, Pelle Nilsson wrote: What > I'm trying to suggest is that you're perhaps fixing the wrong > problem - make the callback optional if there's a good reason for > it. Yes, the callback can be made optional, I'll send a new patch.