From: Michael Wang <yun.wang@profitbricks.com>
To: Roland Dreier <roland@kernel.org>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Tom Tucker <tom@opengridcomputing.com>,
Steve Wise <swise@opengridcomputing.com>,
Hoang-Nam Nguyen <hnguyen@de.ibm.com>,
Christoph Raisch <raisch@de.ibm.com>,
Mike Marciniszyn <infinipath@intel.com>,
Eli Cohen <eli@mellanox.com>,
Faisal Latif <faisal.latif@intel.com>,
Jack Morgenstein <jackm@dev.mellanox.co.il>,
Or Gerlitz <ogerlitz@mellanox.com>,
Haggai Eran <haggaie@mellanox.com>,
Ira Weiny <ira.weiny@intel.com>, Tom Talpey <tom@talpey.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Doug Ledford <dledford@redhat.com>,
Michael Wang <yun.wang@profitbricks.com>
Subject: [PATCH v3 00/28] IB/Verbs: IB Management Helpers
Date: Mon, 13 Apr 2015 14:20:00 +0200 [thread overview]
Message-ID: <552BB470.4090407@profitbricks.com> (raw)
Since v2:
* Apply suggestions from Doug, Ira, Jason, Tom, Steve, thanks for the comments :-)
and please remind me if I missed anything :-P
There are plenty of lengthy code to check the transport type of IB device,
or the link layer type of it's port, but actually we are just speculating
whether a particular management/feature is supported by the device/port.
Thus instead of inferring, we should have our own mechanism for IB management
capability/protocol/feature checking, several proposals below.
This patch set will reform the method of getting transport type, we will
now using query_transport() instead of inferring from transport and link
layer respectively, also we defined the new transport type to make the
concept more reasonable.
Mapping List:
node-type link-layer old-transport new-transport
nes RNIC ETH IWARP IWARP
amso1100 RNIC ETH IWARP IWARP
cxgb3 RNIC ETH IWARP IWARP
cxgb4 RNIC ETH IWARP IWARP
usnic USNIC_UDP ETH USNIC_UDP USNIC_UDP
ocrdma IB_CA ETH IB IBOE
mlx4 IB_CA IB/ETH IB IB/IBOE
mlx5 IB_CA IB IB IB
ehca IB_CA IB IB IB
ipath IB_CA IB IB IB
mthca IB_CA IB IB IB
qib IB_CA IB IB IB
For example:
if (transport == IB) && (link-layer == ETH)
will now become:
if (query_transport() == IBOE)
Thus we will be able to get rid of the respective transport and link-layer
checking, and it will help us to add new protocol/Technology (like OPA) more
easier, also with the introduced management helpers, IB management logical
will be more clear and easier for extending.
Highlights:
The patch set covered a wide range of IB stuff, thus for those who are
familiar with the particular part, your suggestion would be invaluable ;-)
Patches haven't been tested yet, we appreciate if any one who have these
HW willing to provide his Tested-by :-)
Doug suggested the bitmask mechanism:
https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg23765.html
which could be the plan for future reforming, we prefer that to be another
series which focus on semantic and performance.
This patch-set is somewhat 'bloated' now and it may be a good timing for
staging, I'd like to suggest we focus on improving existed helpers and push
all the further reforms into next series ;-)
Proposals:
Sean:
https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg23339.html
Doug:
https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg23418.html
https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg23765.html
Jason:
https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg23425.html
Michael Wang (28):
[PATCH v3 01/28] IB/Verbs: Implement new callback query_transport()
[PATCH v3 02/28] IB/Verbs: Implement raw management helpers
[PATCH v3 03/28] IB/Verbs: Reform IB-core mad/agent/user_mad
[PATCH v3 04/28] IB/Verbs: Reform IB-core cm
[PATCH v3 05/28] IB/Verbs: Reform IB-core sa_query
[PATCH v3 06/28] IB/Verbs: Reform IB-core multicast
[PATCH v3 07/28] IB/Verbs: Reform IB-ulp ipoib
[PATCH v3 08/28] IB/Verbs: Reform IB-ulp xprtrdma
[PATCH v3 09/28] IB/Verbs: Reform IB-core verbs/uverbs_cmd/sysfs
[PATCH v3 10/28] IB/Verbs: Reform cm related part in IB-core cma
[PATCH v3 11/28] IB/Verbs: Reform route related part in IB-core cma
[PATCH v3 12/28] IB/Verbs: Reform mcast related part in IB-core cma
[PATCH v3 13/28] IB/Verbs: Reserve legacy transport type in 'dev_addr'
[PATCH v3 14/28] IB/Verbs: Reform cma_acquire_dev()
[PATCH v3 15/28] IB/Verbs: Reform rest part in IB-core cma
[PATCH v3 16/28] IB/Verbs: Use management helper cap_ib_mad()
[PATCH v3 17/28] IB/Verbs: Use management helper cap_ib_smi()
[PATCH v3 18/28] IB/Verbs: Use management helper cap_ib_cm()
[PATCH v3 19/28] IB/Verbs: Use management helper cap_iw_cm()
[PATCH v3 20/28] IB/Verbs: Use management helper cap_ib_sa()
[PATCH v3 21/28] IB/Verbs: Use management helper cap_ib_mcast()
[PATCH v3 22/28] IB/Verbs: Use management helper cap_ipoib()
[PATCH v3 23/28] IB/Verbs: Use management helper cap_read_multi_sge()
[PATCH v3 24/28] IB/Verbs: Use management helper cap_ib_cm_dev()
[PATCH v3 25/28] IB/Verbs: Use management helper cap_af_ib()
[PATCH v3 26/28] IB/Verbs: Use management helper cap_eth_ah()
[PATCH v3 27/28] IB/Verbs: Clean up rdma_ib_or_iboe()
[PATCH v3 28/28] IB/Verbs: Cleanup rdma_node_get_transport()
---
drivers/infiniband/core/agent.c | 4
drivers/infiniband/core/cm.c | 28 +-
drivers/infiniband/core/cma.c | 331 ++++++++++++---------------
drivers/infiniband/core/device.c | 1
drivers/infiniband/core/mad.c | 28 +-
drivers/infiniband/core/multicast.c | 18 -
drivers/infiniband/core/sa_query.c | 41 +--
drivers/infiniband/core/sysfs.c | 8
drivers/infiniband/core/ucm.c | 3
drivers/infiniband/core/ucma.c | 27 --
drivers/infiniband/core/user_mad.c | 32 +-
drivers/infiniband/core/uverbs_cmd.c | 6
drivers/infiniband/core/verbs.c | 33 --
drivers/infiniband/hw/amso1100/c2_provider.c | 7
drivers/infiniband/hw/cxgb3/iwch_provider.c | 7
drivers/infiniband/hw/cxgb4/provider.c | 7
drivers/infiniband/hw/ehca/ehca_hca.c | 6
drivers/infiniband/hw/ehca/ehca_iverbs.h | 3
drivers/infiniband/hw/ehca/ehca_main.c | 1
drivers/infiniband/hw/ipath/ipath_verbs.c | 7
drivers/infiniband/hw/mlx4/main.c | 10
drivers/infiniband/hw/mlx5/main.c | 7
drivers/infiniband/hw/mthca/mthca_provider.c | 7
drivers/infiniband/hw/nes/nes_verbs.c | 6
drivers/infiniband/hw/ocrdma/ocrdma_main.c | 1
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 6
drivers/infiniband/hw/ocrdma/ocrdma_verbs.h | 3
drivers/infiniband/hw/qib/qib_verbs.c | 7
drivers/infiniband/hw/usnic/usnic_ib_main.c | 1
drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 6
drivers/infiniband/hw/usnic/usnic_ib_verbs.h | 2
drivers/infiniband/ulp/ipoib/ipoib_main.c | 17 -
include/rdma/ib_verbs.h | 224 +++++++++++++++++-
net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 6
net/sunrpc/xprtrdma/svc_rdma_transport.c | 51 +---
35 files changed, 599 insertions(+), 353 deletions(-)
next reply other threads:[~2015-04-13 12:20 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 12:20 Michael Wang [this message]
2015-04-13 12:22 ` [PATCH v3 01/28] IB/Verbs: Implement new callback query_transport() Michael Wang
2015-04-15 18:36 ` Hal Rosenstock
2015-04-15 19:29 ` Hefty, Sean
2015-04-15 20:39 ` ira.weiny
2015-04-15 20:33 ` ira.weiny
2015-04-16 11:40 ` Hal Rosenstock
2015-04-16 7:30 ` Michael Wang
2015-04-13 12:22 ` [PATCH v3 02/28] IB/Verbs: Implement raw management helpers Michael Wang
2015-04-13 12:23 ` [PATCH v3 03/28] IB/Verbs: Reform IB-core mad/agent/user_mad Michael Wang
2015-04-13 12:23 ` [PATCH v3 04/28] IB/Verbs: Reform IB-core cm Michael Wang
2015-04-13 18:12 ` ira.weiny
2015-04-13 18:40 ` Hefty, Sean
2015-04-13 19:29 ` Jason Gunthorpe
2015-04-13 19:52 ` ira.weiny
2015-04-14 7:57 ` Michael Wang
2015-04-14 7:50 ` Michael Wang
2015-04-13 12:24 ` [PATCH v3 05/28] IB/Verbs: Reform IB-core sa_query Michael Wang
2015-04-13 18:14 ` ira.weiny
2015-04-13 18:45 ` Hefty, Sean
2015-04-14 8:03 ` Michael Wang
2015-04-13 12:24 ` [PATCH v3 06/28] IB/Verbs: Reform IB-core multicast Michael Wang
2015-04-13 12:25 ` [PATCH v3 07/28] IB/Verbs: Reform IB-ulp ipoib Michael Wang
2015-04-13 18:16 ` ira.weiny
2015-04-13 19:27 ` Jason Gunthorpe
2015-04-13 19:46 ` ira.weiny
2015-04-13 20:01 ` Jason Gunthorpe
2015-04-14 14:18 ` ira.weiny
2015-04-14 14:32 ` Michael Wang
2015-04-14 15:40 ` ira.weiny
2015-04-14 15:51 ` Michael Wang
2015-04-14 17:09 ` Hefty, Sean
2015-04-14 17:25 ` Jason Gunthorpe
2015-04-14 17:43 ` ira.weiny
2015-04-14 17:59 ` Jason Gunthorpe
2015-04-14 18:02 ` Hefty, Sean
2015-04-14 18:21 ` Jason Gunthorpe
2015-04-15 7:58 ` Michael Wang
2015-04-16 16:44 ` Jason Gunthorpe
2015-04-16 17:02 ` Roland Dreier
2015-04-16 17:21 ` Hefty, Sean
2015-04-16 17:45 ` Jason Gunthorpe
2015-04-17 7:35 ` Michael Wang
2015-04-16 17:05 ` Weiny, Ira
2015-04-17 7:40 ` Michael Wang
2015-04-14 8:08 ` Michael Wang
2015-04-13 12:25 ` [PATCH v3 08/28] IB/Verbs: Reform IB-ulp xprtrdma Michael Wang
2015-04-13 12:26 ` [PATCH v3 09/28] IB/Verbs: Reform IB-core verbs/uverbs_cmd/sysfs Michael Wang
2015-04-13 12:26 ` [PATCH v3 10/28] IB/Verbs: Reform cm related part in IB-core cma Michael Wang
2015-04-13 19:25 ` Hefty, Sean
2015-04-13 19:50 ` Jason Gunthorpe
2015-04-13 20:31 ` Hefty, Sean
2015-04-15 18:36 ` Hal Rosenstock
2015-04-14 8:35 ` Michael Wang
2015-04-14 15:50 ` ira.weiny
2015-04-14 15:58 ` Michael Wang
2015-04-13 12:27 ` [PATCH v3 11/28] IB/Verbs: Reform route " Michael Wang
2015-04-13 12:28 ` [PATCH v3 12/28] IB/Verbs: Reform mcast " Michael Wang
2015-04-13 12:28 ` [PATCH v3 13/28] IB/Verbs: Reserve legacy transport type in 'dev_addr' Michael Wang
2015-04-13 12:29 ` [PATCH v3 14/28] IB/Verbs: Reform cma_acquire_dev() Michael Wang
2015-04-13 12:29 ` [PATCH v3 15/28] IB/Verbs: Reform rest part in IB-core cma Michael Wang
2015-04-13 12:30 ` [PATCH v3 16/28] IB/Verbs: Use management helper cap_ib_mad() Michael Wang
2015-04-13 12:30 ` [PATCH v3 17/28] IB/Verbs: Use management helper cap_ib_smi() Michael Wang
2015-04-13 12:31 ` [PATCH v3 18/28] IB/Verbs: Use management helper cap_ib_cm() Michael Wang
2015-04-13 12:32 ` [PATCH v3 19/28] IB/Verbs: Use management helper cap_iw_cm() Michael Wang
2015-04-13 12:32 ` [PATCH v3 20/28] IB/Verbs: Use management helper cap_ib_sa() Michael Wang
2015-04-13 12:33 ` [PATCH v3 21/28] IB/Verbs: Use management helper cap_ib_mcast() Michael Wang
2015-04-13 12:33 ` [PATCH v3 22/28] IB/Verbs: Use management helper cap_ipoib() Michael Wang
2015-04-13 12:34 ` [PATCH v3 23/28] IB/Verbs: Use management helper cap_read_multi_sge() Michael Wang
2015-04-13 12:34 ` [PATCH v3 24/28] IB/Verbs: Use management helper cap_ib_cm_dev() Michael Wang
2015-04-13 12:35 ` [PATCH v3 25/28] IB/Verbs: Use management helper cap_af_ib() Michael Wang
2015-04-16 13:57 ` Or Gerlitz
2015-04-16 14:16 ` Hal Rosenstock
2015-04-16 15:09 ` Hefty, Sean
2015-04-16 15:28 ` Michael Wang
2015-04-13 12:35 ` [PATCH v3 26/28] IB/Verbs: Use management helper cap_eth_ah() Michael Wang
2015-04-13 12:36 ` [PATCH v3 27/28] IB/Verbs: Clean up rdma_ib_or_iboe() Michael Wang
2015-04-13 20:33 ` Jason Gunthorpe
2015-04-14 9:13 ` Michael Wang
2015-04-16 16:43 ` Jason Gunthorpe
2015-04-16 18:07 ` Steve Wise
2015-04-17 8:04 ` Michael Wang
2015-04-17 8:00 ` Michael Wang
2015-04-13 12:37 ` [PATCH v3 28/28] IB/Verbs: Cleanup rdma_node_get_transport() Michael Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552BB470.4090407@profitbricks.com \
--to=yun.wang@profitbricks.com \
--cc=dledford@redhat.com \
--cc=eli@mellanox.com \
--cc=faisal.latif@intel.com \
--cc=haggaie@mellanox.com \
--cc=hal.rosenstock@gmail.com \
--cc=hnguyen@de.ibm.com \
--cc=infinipath@intel.com \
--cc=ira.weiny@intel.com \
--cc=jackm@dev.mellanox.co.il \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=raisch@de.ibm.com \
--cc=roland@kernel.org \
--cc=sean.hefty@intel.com \
--cc=swise@opengridcomputing.com \
--cc=tom@opengridcomputing.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome