From: Krzysztof Kozlowski <krzk@kernel.org>
To: Bingwu Zhang <xtex@envs.net>, Tony Luck <tony.luck@intel.com>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Bingwu Zhang <xtexchooser@duck.com>, Rong Zhang <i@rong.moe>,
Daniele Debernardi <drebrez@gmail.com>,
Luca Weiss <luca@z3ntu.xyz>,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-hardening@vger.kernel.org, ~xtex/staging@lists.sr.ht
Subject: Re: [PATCH] ARM: dts: qcom: msm8974pro-samsung-klte: Add pstore node
Date: Mon, 15 Jul 2024 10:57:54 +0200 [thread overview]
Message-ID: <552dac56-8915-4b26-8c90-769d09924861@kernel.org> (raw)
In-Reply-To: <20240715083245.80169-2-xtex@envs.net>
On 15/07/2024 10:32, Bingwu Zhang wrote:
> From: Bingwu Zhang <xtexchooser@duck.com>
>
> Add pstore node to allow for retrieving crash logs.
>
> Tested-by: Bingwu Zhang <xtexchooser@duck.com> # on SM-G9008W (samsung-kltechn)
Tested-by tags are provided by others, not by yourself. It's expected
that you test youro own patches. Drop the tag.
> Signed-off-by: Bingwu Zhang <xtexchooser@duck.com>
> ---
> .../qcom-msm8974pro-samsung-klte-common.dtsi | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi
> index b5443fd5b425..ff98b9362b0d 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi
> @@ -126,6 +126,23 @@ led@3 {
> };
> };
>
> + reserved-memory {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
Don't duplicate the nodes, but rather extend via phandle/label. Or at
least drop duplicated properties.
> +
> + ramoops@3e8e0000 {
> + compatible = "ramoops";
> + reg = <0x3e8e0000 0x200000>;
> +
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-15 8:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 8:32 Bingwu Zhang
2024-07-15 8:57 ` Krzysztof Kozlowski [this message]
2024-07-15 9:22 ` Bingwu Zhang
2024-07-15 9:23 ` Bingwu Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552dac56-8915-4b26-8c90-769d09924861@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=drebrez@gmail.com \
--cc=gpiccoli@igalia.com \
--cc=i@rong.moe \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=robh@kernel.org \
--cc=tony.luck@intel.com \
--cc=xtex@envs.net \
--cc=xtexchooser@duck.com \
--cc=~xtex/staging@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®