Re: [PATCH v4 10/27] IB/Verbs: Reform cm related part in IB-core cma/ucm

[Michael Wang <yun.wang@profitbricks.com>]

On 04/16/2015 07:30 PM, Hefty, Sean wrote:
>>> To be confirmed:
>>> 				PORT ASSIGNED
>>> 	rdma_init_qp_attr	Y
>>> 	rdma_destroy_id		unknown
>>> 	cma_listen_on_dev	N
>>> 	cma_bind_loopback	N
> 
> Bind loopback will attach to a port, but the id does not have on entry.
> 
>>> 	rdma_listen		N
>>
>> Why "N"? rdma_listen() can be constrained to a single port, right?
>> And even if wildcarded, it needs to act on multiple ports, which is
>> to say, it will fail only if no ports are eligible.
> 
> Rdma listen should be unknown.  The id may be assigned to a port.  It depends on the source address.

Agree, so for those 'N' or 'unknow', let's use port 1 directly.

> 
>>> 	rdma_connect		Y
>>> 	rdma_accept		Y
>>> 	rdma_reject		Y
>>> 	rdma_disconnect		Y
>>> 	ib_ucm_add_one		N
> 
> Others look correct.
> 
> Btw, thanks for your work on this.  I know this is becoming a much bigger change than you originally intended.  :)

My pleasure :-) It do exceeded my expectations, fortunately I have you guys
on my side, without your comments, it's impossible to make it so far :-)

Regards,
Michael Wang

> 
> - Sean
>