From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Dan Murphy <dmurphy@ti.com>, pavel@ucw.cz
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v23 02/16] leds: multicolor: Introduce a multicolor class definition
Date: Sat, 2 May 2020 23:51:21 +0200 [thread overview]
Message-ID: <5533a7b4-12b4-90b8-2731-a9cdfbee5e12@gmail.com> (raw)
In-Reply-To: <20200429202816.26501-3-dmurphy@ti.com>
Dan,
I've converted drivers/leds/leds-an30259a.c to LED mc framework
and tested it on Samsung Galaxy S3 (exysnos4412-trats2 board).
Works as expected. And now the framework usability is indeed neater.
One thing to improve: LED mc based drivers' entries in Kconfig should
have this dependency:
depends on LEDS_CLASS_MULTI_COLOR || !LEDS_CLASS_MULTI_COLOR
It is required to enforce building driver as a module if
LED mc framework is configured as such.
With this (and DT bindings nits) addressed, for patches 1-6:
Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
It's been a long journey. Thank you for your determination to drive
this work to the end.
Best regards,
Jacek Anaszewski
On 4/29/20 10:28 PM, Dan Murphy wrote:
> Introduce a multicolor class that groups colored LEDs
> within a LED node.
>
> The multi color class groups monochrome LEDs and allows controlling two
> aspects of the final combined color: hue and lightness. The former is
> controlled via the intensity file and the latter is controlled
> via brightness file.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
> .../ABI/testing/sysfs-class-led-multicolor | 34 +++
> Documentation/leds/index.rst | 1 +
> Documentation/leds/leds-class-multicolor.rst | 86 +++++++
> MAINTAINERS | 8 +
> drivers/leds/Kconfig | 10 +
> drivers/leds/Makefile | 1 +
> drivers/leds/led-class-multicolor.c | 210 ++++++++++++++++++
> include/linux/led-class-multicolor.h | 121 ++++++++++
> 8 files changed, 471 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-class-led-multicolor
> create mode 100644 Documentation/leds/leds-class-multicolor.rst
> create mode 100644 drivers/leds/led-class-multicolor.c
> create mode 100644 include/linux/led-class-multicolor.h
[...]
next prev parent reply other threads:[~2020-05-02 21:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 20:28 [PATCH v23 00/16] Multicolor Framework v23 Dan Murphy
2020-04-29 20:28 ` [PATCH v23 01/16] dt: bindings: Add multicolor class dt bindings documention Dan Murphy
2020-05-02 21:51 ` Jacek Anaszewski
2020-04-29 20:28 ` [PATCH v23 02/16] leds: multicolor: Introduce a multicolor class definition Dan Murphy
2020-05-02 21:51 ` Jacek Anaszewski [this message]
2020-05-03 12:26 ` Dan Murphy
2020-04-29 20:28 ` [PATCH v23 03/16] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers Dan Murphy
2020-04-29 20:28 ` [PATCH v23 04/16] leds: lp50xx: Add the LP50XX family of the RGB LED driver Dan Murphy
2020-04-29 20:28 ` [PATCH v23 05/16] dt: bindings: lp55xx: Be consistent in the document with LED acronym Dan Murphy
2020-04-29 20:28 ` [PATCH v23 06/16] dt: bindings: lp55xx: Update binding for Multicolor Framework Dan Murphy
2020-04-29 20:28 ` [PATCH v23 07/16] ARM: dts: n900: Add reg property to the LP5523 channel node Dan Murphy
2020-04-29 20:28 ` [PATCH v23 08/16] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 " Dan Murphy
2020-04-29 20:28 ` [PATCH v23 09/16] ARM: dts: ste-href: Add reg property to the LP5521 channel nodes Dan Murphy
2020-04-29 20:28 ` [PATCH v23 10/16] leds: lp55xx: Convert LED class registration to devm_* Dan Murphy
2020-04-29 20:28 ` [PATCH v23 11/16] leds: lp55xx: Add multicolor framework support to lp55xx Dan Murphy
2020-04-29 20:28 ` [PATCH v23 12/16] leds: lp5523: Update the lp5523 code to add multicolor brightness function Dan Murphy
2020-04-29 20:28 ` [PATCH v23 13/16] leds: lp5521: Add multicolor framework multicolor brightness support Dan Murphy
2020-04-29 20:28 ` [PATCH v23 14/16] leds: lp55xx: Fix checkpatch file permissions issues Dan Murphy
2020-04-29 20:28 ` [PATCH v23 15/16] leds: lp5523: Fix checkpatch issues in the code Dan Murphy
2020-04-29 20:28 ` [PATCH v23 16/16] dt: bindings: Update lp55xx binding to recommended LED naming Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5533a7b4-12b4-90b8-2731-a9cdfbee5e12@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®