From: "Jan Beulich" <JBeulich@suse.com>
To: "Linus Torvalds" <torvalds@linux-foundation.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: regression from your recent change to x86's copy_user_handle_tail()
Date: Wed, 22 Apr 2015 07:33:07 +0100 [thread overview]
Message-ID: <55375CC30200007800074A08@mail.emea.novell.com> (raw)
Linus,
while the description of commit cae2a173fe certainly makes sense, the
change itself ignores the __probe_kernel_write() code path, for which
the destination address is expected to be in kernel space but accesses
may still fault. I.e. the use of plain memset() causes
__probe_kernel_write() to oops rather than return an error. Shouldn't
the "(unsigned long)to >= TASK_SIZE_MAX" be relaxed to take the
effect of set_fs() into account?
Thanks, Jan
next reply other threads:[~2015-04-22 6:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 6:33 Jan Beulich [this message]
2015-04-23 15:33 ` Linus Torvalds
2015-04-23 15:43 ` Jan Beulich
2015-04-23 15:52 ` Linus Torvalds
2015-04-24 6:51 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55375CC30200007800074A08@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®