From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932492AbbD0JbQ (ORCPT ); Mon, 27 Apr 2015 05:31:16 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:34566 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932417AbbD0JbO (ORCPT ); Mon, 27 Apr 2015 05:31:14 -0400 X-AuditID: cbfee68d-f79266d0000049c9-8a-553e01e1079f Message-id: <553E01E0.6060309@samsung.com> Date: Mon, 27 Apr 2015 18:31:12 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Chanwoo Choi Cc: mturquette@linaro.org, sboyd@codeaurora.org, s.nawrocki@samsung.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] clk: Show the clock rate when fail to set clock rate References: <1430124809-21765-1-git-send-email-cw00.choi@samsung.com> In-reply-to: <1430124809-21765-1-git-send-email-cw00.choi@samsung.com> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprCIsWRmVeSWpSXmKPExsWyRsSkSPcho12owc9J7BbXvzxntbi8aw6b xdMJF9ksDr9pZ7X4caabxYHV43JfL5PHnWt72Dz6tqxi9Pi8SS6AJYrLJiU1J7MstUjfLoEr 4+u0HUwFG7gqNvw+wNLA2MfRxcjJISFgIvH+xw1GCFtM4sK99WxdjFwcQgJLGSWmbNjIBlO0 dms/E0RiOqPElpf/WCGcB4wSG5btBaviFdCSeD2vAWwUi4CqxOs7q5hBbDag+P4XN8BqRAXC JFZOv8ICUS8o8WPyPTBbREBDYubfK0C9HBzMAukSE3oqQcLCAj4S27ZNAhsjJOAq0TT/DpjN KeAm8XnpH1YQm1lAR2J/6zQ2CFteYvOat8wgt0kIbGOXuH7wBAvEPQIS3yYfYgGZLyEgK7Hp ADPEY5ISB1fcYJnAKDYLyUWzkIydhWTsAkbmVYyiqQXJBcVJ6UWGesWJucWleel6yfm5mxiB kXX637PeHYy3D1gfYhTgYFTi4ZWYaBsqxJpYVlyZe4jRFOiKicxSosn5wPjNK4k3NDYzsjA1 MTU2Mrc0UxLnVZT6GSwkkJ5YkpqdmlqQWhRfVJqTWnyIkYmDU6qBUcXve9qaVXadyYwnL5SF v1hXUGIkpqCr+Jfvr/+NK4xH73G7Hcji+216ouTz7dsdxf9WPKs59Cg+RcyW+dDU/GeXP8j9 CvJVkOc69Wt+n3hDlvY55s2G4a5st9a3mr9dpngm72BunXuQh8DHU0aqb+vdmPdLOYkyZKyt 7K5ac0jUz+NDabazEktxRqKhFnNRcSIAegagS6cCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHIsWRmVeSWpSXmKPExsVy+t9jQd2HjHahBv9fMVlc//Kc1eLyrjls Fk8nXGSzOPymndXix5luFgdWj8t9vUwed67tYfPo27KK0ePzJrkAlqgGRpuM1MSU1CKF1Lzk /JTMvHRbJe/geOd4UzMDQ11DSwtzJYW8xNxUWyUXnwBdt8wcoMVKCmWJOaVAoYDE4mIlfTtM E0JD3HQtYBojdH1DguB6jAzQQMIaxoyv03YwFWzgqtjw+wBLA2MfRxcjJ4eEgInE2q39TBC2 mMSFe+vZuhi5OIQEpjNKbHn5jxXCecAosWHZXjaQKl4BLYnX8xoYQWwWAVWJ13dWMYPYbEDx /S9ugNWICoRJrJx+hQWiXlDix+R7YLaIgIbEzL9XgHo5OJgF0iUm9FSChIUFfCS2bZsENkZI wFWiaf4dMJtTwE3i89I/rCA2s4COxP7WaWwQtrzE5jVvmScwCsxCsmEWkrJZSMoWMDKvYhRN LUguKE5KzzXUK07MLS7NS9dLzs/dxAiO22dSOxhXNlgcYhTgYFTi4ZWYaBsqxJpYVlyZe4hR goNZSYR3x2egEG9KYmVValF+fFFpTmrxIUZTYABMZJYSTc4HppS8knhDYxMzI0sjc0MLI2Nz JXHeObpyoUIC6YklqdmpqQWpRTB9TBycUg2Mpe2H55UyVlVOjnt+YgFHw7eF0Rq8t0Kt5BJ+ XllZdaj/TMsOMR3WDr3zlobL5niUy/dOets8I/foP9kz/vYejJcSzmx1je8p9VBruvi9eLs8 +1yO88zt93s816UY6TxLr35kqKgVfoz1ysdNx5KmCkhHrLy8i2F2w/37t0vOzDzYl3O5I+mH EktxRqKhFnNRcSIAHUkIs/ECAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear all, Please ignore this patch. I'll send v4 patch. Thanks, Chanwoo Choi On 04/27/2015 05:53 PM, Chanwoo Choi wrote: > This patch shows the current clock rate when fail to set the clock rate. > because original error message show the error value instead of currrent clock > rate. > > Cc: Mike Turquette > Cc: Stephen Boyd > Cc: Sylwester Nawrocki > Signed-off-by: Chanwoo Choi > --- > Changes from v2: > - Show the current clock rate when fail to set clock rate > Changes from v1: > - Add error value of clk_set_rate() with current clock rate > > drivers/clk/clk-conf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/clk-conf.c b/drivers/clk/clk-conf.c > index 48a65b2..53d7449 100644 > --- a/drivers/clk/clk-conf.c > +++ b/drivers/clk/clk-conf.c > @@ -106,8 +106,8 @@ static int __set_clk_rates(struct device_node *node, bool clk_supplier) > > rc = clk_set_rate(clk, rate); > if (rc < 0) > - pr_err("clk: couldn't set %s clock rate: %d\n", > - __clk_get_name(clk), rc); > + pr_err("clk: couldn't set %s clk rate to %ld\n", > + __clk_get_name(clk), rate); > clk_put(clk); > } > index++; >