From: Dan Carpenter <dan.carpenter@linaro.org>
To: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Cc: vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org,
elder@kernel.org, gregkh@linuxfoundation.org,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
ivan.orlov0322@gmail.com
Subject: Re: [PATCH] staging: greybus: Refactor gb_audio_gb_get_topology() into separate calls
Date: Sat, 5 Aug 2023 19:14:30 +0300 [thread overview]
Message-ID: <553ef4ed-9f0a-4ab1-b7f2-0175f6cb4dca@kadam.mountain> (raw)
In-Reply-To: <20230804203134.GA618419@madhu-kernel>
On Fri, Aug 04, 2023 at 03:31:34PM -0500, Madhumitha Prabakaran wrote:
> Refactor gb_audio_gb_get_topology() into separate calls for better modularity.
>
This is too vague. Just say "There is a comment which says 'Split into
separate calls' so I have done it." But actually, please just delete
the comment instead. This code is already an endless series of wrappers
around wrappers.
Also, please run your patch through scripts/checkpatch.pl.
Btw, I just want to emphasize again that I was 100% serious when I asked
you to delete the comment.
regards,
dan carpenter
prev parent reply other threads:[~2023-08-05 16:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 20:31 Madhumitha Prabakaran
2023-08-04 22:09 ` kernel test robot
2023-08-05 16:14 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553ef4ed-9f0a-4ab1-b7f2-0175f6cb4dca@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=ivan.orlov0322@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=madhumithabiw@gmail.com \
--cc=mgreer@animalcreek.com \
--cc=skhan@linuxfoundation.org \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®