From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753354AbdDJUSp (ORCPT ); Mon, 10 Apr 2017 16:18:45 -0400 Received: from mout.web.de ([212.227.17.11]:54138 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751890AbdDJUSn (ORCPT ); Mon, 10 Apr 2017 16:18:43 -0400 Subject: [PATCH 1/3] ACPI/int340x_thermal: Use kcalloc() in two functions From: SF Markus Elfring To: linux-pm@vger.kernel.org, Eduardo Valentin , Srinivas Pandruvada , Zhang Rui Cc: LKML , kernel-janitors@vger.kernel.org References: <3ba36cc1-8445-462c-ca75-2b0928f3290a@users.sourceforge.net> Message-ID: <55405e33-2a1a-ea40-743f-eb8e53a1a399@users.sourceforge.net> Date: Mon, 10 Apr 2017 22:18:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <3ba36cc1-8445-462c-ca75-2b0928f3290a@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:n/zxeqpcgbSntNOp4c4EqD4nwMrJ9reDLrlxHCjS3XW1iDoIv2o LoJ2d9GV1qv6KaI/mem2x+NtN1lfa3NRKminOP/sYquEmbFHvHVc3+nW2F28EsgaE26dyHE gPeVyCO39gmgAO+210UqabyZS5hGxb58QnX22Z+f7Khe+f6cayYzgl8XGD5pYniF4A17JLT NLk4Ty1Pu9QZdK0icNVoA== X-UI-Out-Filterresults: notjunk:1;V01:K0:Q3qXtawmtOc=:Gq68VCDC4cyxsgavr3AVM9 VETp7rhMOjpQ2ZsO5w++nQCOyP3NxHREFiD0njJqpUweaqpnseJiMLnH6IK7JIMgxWCpvma8Y IdK+G8bYfdw8qBckVcZChlhxetSC0+oN2N3AALgzdO6XpNsYybe+tAkI3b7Xr6KRP/y0uc/3e A/drVH32sELTyvzCcDkMjbK7XQ5qscS1rHY29CQZpeEqSpy8Nia3TUiPZVEVuczBByN6XKlr3 i8LARsZjktOiWQ4sUrWPyvQSx7vNttdfJO8TV7UPGRc9qeSIXun5iHW61/bBnh+9srdEfAuFT bL37ncLfMAHXUH0w+rxcVzcNXqMFYLVQpDvVzIJhW/yrxVDGi3+sUlxkafm7VrSxPVcuHhN/j ZcQBCoNDZqNuOpllG7wUxVV++I7XkTyVVVVFPvqubQ4CYgxjeyHyPHcIoWBF6u1QlJscTcRwQ bV/V8N8sWT7HKvg5FtWMWaXPkoKG4SsrZtNfMC+rOVKIydwUL608uvOWaFwiovItLlhx7eHDv 38gIA41dOyYKkm7uoOxt6bZRM8/PVSGKpQWmQGdkJFVwUiyHADEwr3c218XKaYcYbsMi7b8++ mv9rZPvS9ur3lp20mVUwrKEvPAt7JnxmOhxtMXazmmfFIrZGqR4HbrKI8Kr+GzmC6A/sgutxJ RWqRE4hWlBFLa7tCIgmL9VCL6CB/ucuULa1IdSB0rqNe+3oeXj5LsybrgKiRNcKc9f6Xurum1 /BpYap8Hg+f5K3irTKfUg652jp6foCmOuN1FiZpzX3bYBamKmuk3Nv84N3c6fy76POaQpohAU /c4TwIr Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 10 Apr 2017 21:30:47 +0200 * Multiplications for the size determination of memory allocations indicated that array data structures should be processed. Thus use the corresponding function "kcalloc". This issue was detected by using the Coccinelle software. * Replace the specification of data structures by pointer dereferences to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/thermal/int340x_thermal/acpi_thermal_rel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/int340x_thermal/acpi_thermal_rel.c b/drivers/thermal/int340x_thermal/acpi_thermal_rel.c index 2c2ec7666eb1..52a5fe0f81e8 100644 --- a/drivers/thermal/int340x_thermal/acpi_thermal_rel.c +++ b/drivers/thermal/int340x_thermal/acpi_thermal_rel.c @@ -96,7 +96,7 @@ int acpi_parse_trt(acpi_handle handle, int *trt_count, struct trt **trtp, } *trt_count = p->package.count; - trts = kzalloc(*trt_count * sizeof(struct trt), GFP_KERNEL); + trts = kcalloc(*trt_count, sizeof(*trts), GFP_KERNEL); if (!trts) { result = -ENOMEM; goto end; @@ -178,7 +178,7 @@ int acpi_parse_art(acpi_handle handle, int *art_count, struct art **artp, /* ignore p->package.elements[0], as this is _ART Revision field */ *art_count = p->package.count - 1; - arts = kzalloc(*art_count * sizeof(struct art), GFP_KERNEL); + arts = kcalloc(*art_count, sizeof(*arts), GFP_KERNEL); if (!arts) { result = -ENOMEM; goto end; -- 2.12.2