From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752818AbbD3THx (ORCPT ); Thu, 30 Apr 2015 15:07:53 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:35785 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751085AbbD3THt (ORCPT ); Thu, 30 Apr 2015 15:07:49 -0400 Message-ID: <55427D83.3060900@codeaurora.org> Date: Thu, 30 Apr 2015 12:07:47 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Dong Aisheng , linux-clk@vger.kernel.org CC: linux-kernel@vger.kernel.org, mturquette@linaro.org, shawn.guo@linaro.org, b29396@freescale.com, linux-arm-kernel@lists.infradead.org, Ranjani.Vaidyanathan@freescale.com, b20596@freescale.com, r64343@freescale.com, b20788@freescale.com Subject: Re: [PATCH RFC v1 2/5] clk: add missing lock when call clk_core_enable in clk_set_parent References: <1429107999-24413-1-git-send-email-aisheng.dong@freescale.com> <1429107999-24413-3-git-send-email-aisheng.dong@freescale.com> In-Reply-To: <1429107999-24413-3-git-send-email-aisheng.dong@freescale.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/15/15 07:26, Dong Aisheng wrote: > clk_core_enable is executed without &enable_clock in clk_set_parent function. > Adding it to avoid potential race condition issue. > > Fixes: 035a61c314eb ("clk: Make clk API return per-user struct clk instances") > Cc: Mike Turquette > Cc: Stephen Boyd > Signed-off-by: Dong Aisheng > --- Can you please describe the race condition? From what I can tell there is not a race condition here and we've gone around on this part of the code before to fix any race conditions. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project