From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752540AbbD3TJV (ORCPT ); Thu, 30 Apr 2015 15:09:21 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:35947 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750891AbbD3TJU (ORCPT ); Thu, 30 Apr 2015 15:09:20 -0400 Message-ID: <55427DDE.4090907@codeaurora.org> Date: Thu, 30 Apr 2015 12:09:18 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Dong Aisheng , linux-clk@vger.kernel.org CC: linux-kernel@vger.kernel.org, mturquette@linaro.org, shawn.guo@linaro.org, b29396@freescale.com, linux-arm-kernel@lists.infradead.org, Ranjani.Vaidyanathan@freescale.com, b20596@freescale.com, r64343@freescale.com, b20788@freescale.com Subject: Re: [PATCH RFC v1 3/5] clk: remove unneeded __clk_enable and __clk_disable References: <1429107999-24413-1-git-send-email-aisheng.dong@freescale.com> <1429107999-24413-4-git-send-email-aisheng.dong@freescale.com> In-Reply-To: <1429107999-24413-4-git-send-email-aisheng.dong@freescale.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/15/15 07:26, Dong Aisheng wrote: > The only thing __clk_enable/__clk_disable does is NULL pointer checking > of clk except calling clk_core_{enable|disable} which is already handled > by clk_core_{enable|disable}. > So remove this unneeded function. > > Cc: Mike Turquette > Cc: Stephen Boyd > Signed-off-by: Dong Aisheng > --- No. You can call clk_enable() and clk_disable() with NULL and it should be a no-op. With this change it would cause a NULL pointer exception. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project