From: Marc Bejarano <beej@beej.org>
To: "René Bolldorf" <xsecute@googlemail.com>
Cc: linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
James Bottomley <James.Bottomley@suse.de>,
linux-kernel@vger.kernel.org, jgarzik@pobox.com
Subject: Re: [PATCH]drivers/ata/libata-eh.c:1509 unneeded memset()
Date: Mon, 11 Jan 2010 16:55:45 -0800 [thread overview]
Message-ID: <5543f88f1001111655t7ae4a4eamd4f010b5ab7e7c82@mail.gmail.com> (raw)
In-Reply-To: <4B4B877A.8060106@googlemail.com>
2010/1/11 René Bolldorf <xsecute@googlemail.com>:
> I hope that's good enough explained :-).
definitely an improvement, but i think jeff is going to want your
S-O-B and at least a patch title, if no description :)
> + /* make sure sense_buf is cleared then atapi_eh_request_sense is
> called.
s/then/when/ ?
> + * (to make sure nothing get's reused.)
probably not necessary
> + * thanks to James Bottomley
this may be better in a patch description
cheers,
marc
next prev parent reply other threads:[~2010-01-12 0:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5543f88f1001111129u362be554kd97027d977b5dff3@mail.gmail.com>
2010-01-11 19:41 ` Marc Bejarano
2010-01-11 20:18 ` René Bolldorf
2010-01-12 0:55 ` Marc Bejarano [this message]
2009-12-30 22:59 René Bolldorf
2010-01-07 19:15 ` Jeff Garzik
2010-01-07 20:34 ` René Bolldorf
2010-01-07 20:40 ` René Bolldorf
2010-01-08 11:30 ` Rolf Eike Beer
2010-01-08 15:28 ` James Bottomley
2010-01-08 20:47 ` René Bolldorf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5543f88f1001111655t7ae4a4eamd4f010b5ab7e7c82@mail.gmail.com \
--to=beej@beej.org \
--cc=James.Bottomley@suse.de \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=xsecute@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®