From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752111AbbEBLeW (ORCPT ); Sat, 2 May 2015 07:34:22 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:35496 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751502AbbEBLeT (ORCPT ); Sat, 2 May 2015 07:34:19 -0400 Message-ID: <5544B62D.1010701@redhat.com> Date: Sat, 02 May 2015 13:34:05 +0200 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Bandan Das CC: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, rkrcmar@redhat.com Subject: Re: [PATCH] KVM: x86: dump VMCS on invalid entry References: <1430391448-21471-1-git-send-email-pbonzini@redhat.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/04/2015 20:17, Bandan Das wrote: >> > Code and format roughly based on Xen's vmcs_dump_vcpu. > Nice, but isn't it better to keep the output format and behavior the > same for both dump_vmcb and dump_vmcs() ? why not pr_error ? I didn't think of looking at dump_vmcb. :) I knew it existed, but I didn't remember it's called in these exact circumstances. The output seems a bit too verbose for pr_error... Maybe it's worth changing dump_vmcb instead. Regarding the output format, some things could be adjusted to match (especially the segments) but overall the data is pretty different apart from the segments and a handful of other fields. Paolo